Antoine Pitrou pit...@free.fr added the comment:
I corrected the patches (they were breaking the property of inheriting daemon
by default) and committed them in r88618. Thank you!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Miki Tebeka miki.teb...@gmail.com added the comment:
Thank you!
On Fri, Feb 25, 2011 at 2:08 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
I corrected the patches (they were breaking the property of inheriting daemon
by default) and
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: jnoller -
stage: - patch review
type: behavior - feature request
versions: +Python 3.3 -Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
Steven Alderson s...@nildram.co.uk added the comment:
Hello, I've taken the liberty of updating the two patch files here for
python3.2 at revision 83065. Apologies if I'm treading on anyones toes here.
I'm taking part in a europython sprint and this is the first time I've tried
this.
I've
Steven Alderson s...@nildram.co.uk added the comment:
Here's the patch for multiprocessing based on python 3 revision 83065, all
credit to the original author, all problems probably mine!
Steven
--
Added file: http://bugs.python.org/file18153/multiprocessing3k.diff
Brian Brazil brian.bra...@gmail.com added the comment:
I've updated the patch for 3.2 and improved the documentation formatting.
--
nosy: +bbrazil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
Brian Brazil brian.bra...@gmail.com added the comment:
Looks like it lost my patch, but Steven's does the same.
One tweak: in threading.rst put all of the class signature on one line or the
html formatting will be a bit off.
--
___
Python tracker
Ask Solem a...@opera.com added the comment:
Patch for multiprocessing, adding the daemon kwarg attached.
--
nosy: +asksol
Added file:
http://bugs.python.org/file15376/6064-multiprocessing-daemon-kwarg.patch
___
Python tracker rep...@bugs.python.org
Changes by Jesse Noller jnol...@gmail.com:
--
assignee: - jnoller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
___
Python-bugs-list
Jesse Noller jnol...@gmail.com added the comment:
+1 to this, and I'd need to make the same patch/change to
multiprocessing.Process as well
--
nosy: +jnoller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
Pablo Torres Navarrete tn.pa...@gmail.com added the comment:
+1, but I can't apply the patch cleanly:
$ patch -p0 threading.diff
patching file Doc/library/threading.rst
Hunk #1 succeeded at 198 (offset -17 lines).
Hunk #2 succeeded at 211 (offset -17 lines).
Hunk #3 succeeded at 230 (offset
Miki Tebeka miki.teb...@gmail.com added the comment:
I'm attaching a new diff (svn diff threading.diff), hope this one's OK.
--
Added file: http://bugs.python.org/file14312/threading.diff
___
Python tracker rep...@bugs.python.org
Pablo Torres Navarrete tn.pa...@gmail.com added the comment:
Nope. Our working copies seem to be different. I'm uploading mine,
which I just update to revision 73468. Please diff yours against that
and against HEAD too, just in case.
Hunk 2 on threading.py fails because your attributes use
Miki Tebeka miki.teb...@gmail.com added the comment:
I'm diffing against the 2.7 branch, I guess your comes from the 3.2?
Will checkout 3.2 and do it there as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
Miki Tebeka miki.teb...@gmail.com added the comment:
Attaching a diff against the py3k branch on revision 73468
--
Added file: http://bugs.python.org/file14314/threading3k.diff
___
Python tracker rep...@bugs.python.org
Pablo Torres Navarrete tn.pa...@gmail.com added the comment:
I'm diffing against the 2.7 branch, I guess your comes from the 3.2?
*forehead meets desktop*
Patch applies cleanly and all tests pass. I used it for a while and
everything seemed OK. After someone else tests, I say we go for it
Lucas Prado Melo lukepada...@gmail.com added the comment:
+1 to the py3k diff. :)
Hey, I think this daemon property should be set as a keyword argument of
the Thread constructor.
--
nosy: +conf
___
Python tracker rep...@bugs.python.org
Pablo Torres Navarrete tn.pa...@gmail.com added the comment:
+1 on making it a keyword-only argument.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
Antoine Pitrou pit...@free.fr added the comment:
+1 from me as well.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
___
Miki Tebeka miki.teb...@gmail.com added the comment:
I think that
self.__daemonic = daemon or self._set_daemon()
is wrong, need to thing about it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
Changes by Amaury Forgeot d'Arc amaur...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
___
Python-bugs-list
Miki Tebeka miki.teb...@gmail.com added the comment:
Attaching a patch against trunk (at revision 72805).
--
keywords: +patch
Added file: http://bugs.python.org/file14029/threading.diff
___
Python tracker rep...@bugs.python.org
New submission from Miki Tebeka miki.teb...@gmail.com:
It would be nice if threading.Thread constructor will have a daemon
argument as well.
This way we'll be able to write
Thread(target=some_function, daemon=1).start()
Instead of currently writing
t = Thread(target=some_function)
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
+1
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
Changes by Raymond Hettinger rhettin...@users.sourceforge.net:
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6064
___
___
25 matches
Mail list logo
