[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: Fixed in r73389. I am wondering if the monkeypatching of linecache that doctest does could be done away with, but I'm not sure whether it might get used somehow in debug mode (since the comment refers to that). On the other hand, if it does get used, the same

[issue6195] Serious regression in doctest in Py3.1rc1

Changes by R. David Murray : Removed file: http://bugs.python.org/file14204/issue6195.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6195] Serious regression in doctest in Py3.1rc1

Changes by R. David Murray : Removed file: http://bugs.python.org/file14188/doctest-test.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: The problem turned out to be a cut and paste error in my patch. I'm uploading the corrected patch, which passes all tests. -- Added file: http://bugs.python.org/file14272/issue6195.patch ___ Python tracker

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: Unfortunately we're not out of the woods yet. test_zipimport_support has a failure with the patch applied. I will investigate when I get a chance, but I'm beginning to wonder if the doctest getsouce code needs some refactoring. -- __

[issue6195] Serious regression in doctest in Py3.1rc1

Lisandro Dalcin added the comment: I've tested latest David's patch against Cython test suite (doctests living in extension modules), and all is working as expected. -- ___ Python tracker __

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: OK, here is a revised patch that passes all tests, including the new one. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file14204/issue6195.patch ___ Python tracker

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: It turns out that doctest patches linecache.getlines (which is not, by the way, a public interface of linecache according to the docs and the __all__ string) to retrieve the doctest source code. The special filename it uses to trigger this is not returned by g

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: The fix is not in fact correct. Without the fix, source code is found that is skipped with the fix in place. This may mean that the fix for issue4050 is also in error. The object found by inspect.getfile when it isn't an a .so is of the form: So I thin

[issue6195] Serious regression in doctest in Py3.1rc1

Amaury Forgeot d'Arc added the comment: Patches (fix+test) are good. -- nosy: +amaury.forgeotdarc resolution: -> accepted ___ Python tracker ___

[issue6195] Serious regression in doctest in Py3.1rc1

R. David Murray added the comment: Here's a test case which fails with the existing code and passes with the patch applied. However, with the patch applied some of the other doctest tests fail with an off-by-one error in the source line number output. I'd like to understand that difference bef

[issue6195] Serious regression in doctest in Py3.1rc1

Changes by R. David Murray : -- assignee: -> r.david.murray nosy: +r.david.murray priority: -> high stage: -> test needed ___ Python tracker ___ ___

[issue6195] Serious regression in doctest in Py3.1rc1

New submission from Lisandro Dalcin : When doctests are written in docstrings from C extension modules, 'doctest' reads the binary extension module file. The attached one-line patch seems to fix the problem, it is in fact very similar to patch for issue4050 related to 'inspect'. -- comp