[issue6465] email.feedparser regular expression bug (NLCRE_crack)

R. David Murray added the comment: Looks good to me. I've added the #6510 as superseder, though I doubt we'll ever make use of that info :) -- superseder: -> email feedparser.py CRLFLF bug: $ vs \Z ___ Python tracker

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

Sandro Tosi added the comment: Lucky as I can be, I have 2.5.5 here and I can confirm that with this version the code above fails - so I think this issue can be closed as fixed by issue5610 (I hope I correctly set all the fields, if not please let me know :)). -- resolution: -> fixed

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

R. David Murray added the comment: My notes say that this bug is "similar to issue 5610", the fix for which made it in to 2.6. I meant to come back and see if that fix fixed this bug, but I forgot. The fix is different, so it is worth verifying that this test case fails in 2.5 but works sub

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

Sandro Tosi added the comment: I was looking at this bug and tried to reproduce it, but I can't :( I extracted this code: part1 = 'Content-Type: multipart/related; start=; boundary=--1JBOHhxKNnWgkmE17ZJ2Cy\r\nContent-Location: http://localhost/page1.html\r\nSubject: =?utf-8?Q?test?

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

Terry J. Reedy added the comment: I believe both 2.4 and 3.0 are no longer maintained. 2.5 only gets security fixes. On the otherhand, fix should go into 3.2 ;-). -- nosy: +tjreedy versions: +Python 3.2 -Python 2.4, Python 2.5, Python 3.0 ___ Python

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

Antoine Pitrou added the comment: Sorry for giving you a slightly wrong indication. The email tests are called from Lib/test/test_email.py, but it redirects to Lib/email/test/*. In any case, there's no point in creating a separate test script for such a detail, you should add your test to one of

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

jkg added the comment: Combined patch as requested by pitrou. (Sorry. This is my first submission.) -- Added file: http://bugs.python.org/file14486/nlcre_full.patch ___ Python tracker _

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

Antoine Pitrou added the comment: Can you include your unit test in your patch rather than as a separate script? Existing unit tests are in Lib/test. -- nosy: +pitrou ___ Python tracker

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

jkg added the comment: Patch. -- keywords: +patch Added file: http://bugs.python.org/file14485/nlcre.patch ___ Python tracker ___ ___

[issue6465] email.feedparser regular expression bug (NLCRE_crack)

New submission from jkg : If the parser is fed a chunk which ends with '\r' and the next chunk begins with '\n', it incorrectly parses this into a line ending with '\r' and an empty line ending with '\n' instead of a single line ending with '\r\n'. Test attached. Patch to follow. -- com