[issue6500] urllib2 maximum recursion depth exceeded

2016-01-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for the review Senthil. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset d34fdd1736f2 by Serhiy Storchaka in branch '2.7': Issue #6500: Fixed infinite recursion in urllib2.Request.__getattr__(). https://hg.python.org/cpython/rev/d34fdd1736f2 -- ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: @Serhiy, the patch looks good to me. This change is an excellent idea. Please commit it. -- assignee: berker.peksag -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: __getattr__() was purposed to handle two lazily created private attributes: __r_type and __r_host. They are set in corresponding get_-methods. Here is a patch that makes __getattr__() to handle only these attributes. -- nosy: +serhiy.storchaka stage:

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Senthil. I've just reverted fbea8ff8db5e. Sorry for the noise! -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open ___ Python tracker _

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset e2faa18802bb by Berker Peksag in branch '2.7': Issue #6500: Reverting fbea8ff8db5e since it broke tests https://hg.python.org/cpython/rev/e2faa18802bb -- ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi @Berker, This patch breaks the unit tests. Could you confirm (or reject) this? Thanks -- ___ Python tracker ___

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset fbea8ff8db5e by Berker Peksag in branch '2.7': Issue #6500: Fix "maximum recursion depth exceeded" error caused by Request.__getattr__() https://hg.python.org/cpython/rev/fbea8ff8db5e -- nosy: +python-dev __

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-02 Thread Berker Peksag
Berker Peksag added the comment: Thank you Ezio, I'll commit this tomorrow. -- assignee: jhylton -> berker.peksag ___ Python tracker ___ __

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-01 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6500] urllib2 maximum recursion depth exceeded

2015-08-02 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch for 2.7. I don't think backporting 9eceb618274a to 2.7 is worth the effort for this, so I just fixed the __getattr__ method and added a test. -- keywords: +patch nosy: +berker.peksag stage: needs patch -> patch review Added file: http:/

[issue6500] urllib2 maximum recursion depth exceeded

2012-11-18 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue6500] urllib2 maximum recursion depth exceeded

2010-03-01 Thread Jeremy Hylton
Jeremy Hylton added the comment: Ok. I'll take a look, too. Jeremy On Sat, Feb 27, 2010 at 4:30 AM, Ezio Melotti wrote: > > Changes by Ezio Melotti : > > > -- > nosy: +orsenthil > status: pending -> open > > ___ > Python tracker >

[issue6500] urllib2 maximum recursion depth exceeded

2009-07-17 Thread Ezio Melotti
Ezio Melotti added the comment: That __getattr__ was removed in r70815 and in Python 3.1 it's OK. The change wasn't backported to the trunk though. Assigning to Jeremy to see what he thinks about it. -- assignee: -> jhylton nosy: +ezio.melotti, jhylton priority: -> normal status: ope

[issue6500] urllib2 maximum recursion depth exceeded

2009-07-17 Thread simon
New submission from simon : def __getattr__(self, attr): # XXX this is a fallback mechanism to guard against these # methods getting called in a non-standard order. this may be # too complicated and/or unnecessary. # XXX should the __r_XXX attributes be public?