[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Changes by Milko Krachounov : Added file: http://bugs.python.org/file20012/subprocess-pass_fd_fix_example.patch ___ Python tracker ___ ___ Pyt

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Changes by Milko Krachounov : Added file: http://bugs.python.org/file20011/test_pass_fds.py ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Milko Krachounov added the comment: The patch doesn't seem to work. I added this before closerange in _close_all_but_a_sorted_few_fds: print("Closing", start_fd, "up to", fd, "exclusive") And used the attached script to run as a subprocess to check for open fds (taken from my tests patch for

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Gregory P. Smith added the comment: I've committed this feature just in time for 3.2beta1 (so it can't be said i'm adding a feature after the beta ;). r87026 It still needs tests and documentation. It doesn't break any existing tests. I'll take care of that after some sleep. -- ass

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Antoine Pitrou added the comment: The reason os.closerange() is used is that it can be slow to call os.close() on lots of fds (I suppose this depends on the OS). See http://code.python.org/hg/trunk/rev/43caff85ec85 Therefore, the patch should be smart enough to continue using os.closerange() on

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

Amaury Forgeot d'Arc added the comment: A couple of unit tests would be great, as well as a paragraph for the documentation. -- nosy: +amaury.forgeotdarc stage: -> test needed ___ Python tracker __

[issue6559] [PATCH]add pass_fds paramter to subprocess.Popen()

New submission from Zhigang Wang : The current subprocess.Popen() has a boolean close_fds parameter, which cannot satisfy all the requirements. Eg. want to pass specific fd to child process, but close others. This patch adds a extra parameter pass_fds to subprocess.Popen's __init__(). This param