Roundup Robot added the comment:
New changeset cd785c9d26c2 by Ezio Melotti in branch '3.3':
#6696: add documentation for the Profile objects, and improve profile/cProfile
docs. Patch by Tom Pinckney.
http://hg.python.org/cpython/rev/cd785c9d26c2
New changeset 81dabc1feb52 by Ezio Melotti in
Ezio Melotti added the comment:
Fixed, thanks for the patch!
--
assignee: eric.araujo - ezio.melotti
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
type: behavior - enhancement
___
Python tracker
Andrew Svetlov added the comment:
Cool! Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
___
Python-bugs-list mailing list
Tom Pinckney added the comment:
Thanks everyone for helping me through my first python patch submission.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Ezio Melotti added the comment:
Last patch LGTM (except a couple of minor whitespace issues).
Tom, can you sign the contributor agreement
(http://www.python.org/psf/contrib/contrib-form/)?
--
stage: patch review - commit review
versions: -Python 3.2
Tom Pinckney added the comment:
Great!
Just signed the contributor agreement.
On Apr 10, 2013, at 1:06 PM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti added the comment:
Last patch LGTM (except a couple of minor whitespace issues).
Tom, can you sign the contributor
Tom Pinckney added the comment:
Another update based on comments. Removed links to cProfile.py and _lsof.c.
--
Added file: http://bugs.python.org/file29756/patch4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
Tom Pinckney added the comment:
Updated based on Ezio's comments.
--
Added file: http://bugs.python.org/file29683/patch3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Éric Araujo added the comment:
Ezio, would you like to commit this?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Tom Pinckney added the comment:
Draft of new updates based on Eric's feedback. I haven't done a final
proof-reading over this patch as I wanted to upload it and see if I'm heading
in the right direction first.
--
Added file: http://bugs.python.org/file29036/patch2.diff
Tom Pinckney added the comment:
Thanks for the feedback!
I'll incorporate it this weekend and make a new patch, though also feel free to
just go ahead and make the changes yourself if you'd rather not wait for me.
--
___
Python tracker
Éric Araujo added the comment:
There is no rush, even if this doesn’t get into the docs distributed with the
releases that are due next week-end, people will see it in the online docs a
day after it’s committed.
--
assignee: docs@python - eric.araujo
Guido van Rossum added the comment:
Can someone review Thomas's patch? It's nearly a year old... I just
discovered this same issue.
--
nosy: +gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
Éric Araujo added the comment:
I learned a lot of that stuff recently thanks to a tutorial from Greg Ward.
Reviewing the patch now.
--
stage: needs patch - patch review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Éric Araujo added the comment:
Tom, I’m sory your contribution was ignored, and I hope you still get Python
bugs email. The patch is great. I made comments about contents and form on
the code review site; you can follow the “review” link in the list of files on
the top of this page if you
Guido van Rossum added the comment:
Eric, you could also check it in with your own changes added.
How far can we backport docs?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Éric Araujo added the comment:
2.7 and 3.2.
I’ll wait a few days to let Thomas get the email and reply if he wants.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
___
Python-bugs-list
Tom Pinckney thomaspinckn...@gmail.com added the comment:
I took a stab at updating the docs based on the current profiler source. See
attached patch for a first draft.
This is my first doc patch so would appreciate any feedback on style and
substance of my changes.
I tried to document more
Tom Pinckney thomaspinckn...@gmail.com added the comment:
Looking at the current docs for 3.3, it looks like there are a bunch of other
ways that the docs could be clarified:
1) Proper documentation of the complete profile.Profile() and
cProfile.Profile() interfaces.
2) Adding other
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
___
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: - needs patch
type: - behavior
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
Terry J. Reedy tjre...@udel.edu added the comment:
I am just responding so this will not show up on the 'unanswered issues' list.
It appears that GB has accepted this as something that needs to be done.
--
nosy: +terry.reedy
___
Python tracker
Changes by Georg Brandl ge...@python.org:
--
priority: normal - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
___
Python-bugs-list
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
assignee: georg.brandl - d...@python
nosy: +d...@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6696
___
New submission from Alexander Myodov amyo...@gmail.com:
Seems like a minor documentation issue in 2.x became more significant
one in 3.x.
In Python 2.6 (and lower), the documentation on Profile objects
discussed them as a part of hotshot module, while omitting the fact
that any profiler
27 matches
Mail list logo
