[issue6739] IDLE: refuse invalid key bindings

Terry J. Reedy added the comment: Guilherme, thank you for the patch. Sorry it took so long to be applied. Cheryl, thank you for making the PR. Writing invalid, exception-raising sequences to user config files was a definite bug. -- resolution: -> fixed stage: test needed -> resolv

[issue6739] IDLE: refuse invalid key bindings

Terry J. Reedy added the comment: New changeset 64a0c266e78c6b5363668012fa7fb614f6018930 by terryjreedy in branch '3.6': [3.6] bpo-6739: IDLE: Check for valid keybinding in config_keys (GH-2377) (#2397) https://github.com/python/cpython/commit/64a0c266e78c6b5363668012fa7fb614f6018930 ---

[issue6739] IDLE: refuse invalid key bindings

Changes by Terry J. Reedy : -- pull_requests: +2444 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue6739] IDLE: refuse invalid key bindings

Terry J. Reedy added the comment: New changeset 8c78aa70c888a370af18896a72cabd00e4120f09 by terryjreedy (csabella) in branch 'master': bpo-6739: IDLE: Check for valid keybinding in config_keys (#2377) https://github.com/python/cpython/commit/8c78aa70c888a370af18896a72cabd00e4120f09 --

[issue6739] IDLE: refuse invalid key bindings

Cheryl Sabella added the comment: I've made a PR for the patch. Even though other tests need to be added, I only added a test for the call to sequence_ok(). Testing this by itself will probably allow it to be mocked in other tests. I also added a call to the unittest in config_key.py. -

[issue6739] IDLE: refuse invalid key bindings

Changes by Cheryl Sabella : -- pull_requests: +2425 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue6739] IDLE: refuse invalid key bindings

Terry J. Reedy added the comment: Patch mostly looks good. To apply now, keybindingDialog.py must become config_key.py. I have no idea what other merge issues there might be. The name of the new function'KeySequenceCheck()' should be 'sequence_ok()'. A minimal new test should call sequence

[issue6739] IDLE: refuse invalid key bindings

Terry J. Reedy added the comment: I believe patch for #21519 affects area of file patched here. -- ___ Python tracker ___ ___ Python-bu

[issue6739] IDLE: refuse invalid key bindings

Changes by Terry J. Reedy : -- assignee: -> terry.reedy title: IDLE window won't start or show up after assgining new key in options v2.5.2 and 3.1.1 -> IDLE: refuse invalid key bindings versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5