Éric Araujo mer...@netwok.org added the comment:
I would have used with self.assertRaises to write the tests, thinking it would
be less verbose/cumbersome.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
In 3.1 I had to use try/except because cm.exception is new in 2.7/3.2.
I used assertRaises on the other branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
Roundup Robot devnull@devnull added the comment:
New changeset 3ceeccbc2c3b by Ezio Melotti in branch '2.7':
#6780: fix starts/endswith error message to mention that tuples are accepted
too.
http://hg.python.org/cpython/rev/3ceeccbc2c3b
New changeset bcbf8c3c4a88 by Ezio Melotti in branch
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
resolution: - fixed
stage: patch review -
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +needs review
stage: needs patch - patch review
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
___
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
___
___
Python-bugs-list
Ezio Melotti ezio.melo...@gmail.com added the comment:
Attached an updated patch for 2.7 with tests that check that UnicodeErrors are
still raised and that the error message mentions 'str', 'unicode' and 'tuple'.
--
Added file: http://bugs.python.org/file21762/issue6780-2.diff
R. David Murray rdmur...@bitdance.com added the comment:
The approach looks good to me. I think this issue is orthogonal to #10616,
since the message here needs to be modified anyway, regardless of what happens
to the underlying issue.
--
nosy: +r.david.murray
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
___
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
See also #10616.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6780
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Here is a proof of concept that solves the problem for unicode strings and
startswith/endswith.
If during the conversion to Unicode a TypeError is raised (e.g. TypeError:
Can't convert 'list' object to str implicitly), the error message is
Ezio Melotti ezio.melo...@gmail.com added the comment:
In the examples you used byte strings for Py2 and Unicode strings for
Py3. On Py3 the same example with byte strings gives an error similar to
the one raised by Py2:
bfoo.startswith([bfo])
Traceback (most recent call last):
File stdin,
New submission from Sridhar Ratnakumar sridh...@activestate.com:
The `startswith` method accepts both string and tuple (not list). Yet
the error message suggests that it expects (only) a character buffer
object.
In Python-2.6:
foo.startswith(['fo', 'df'])
Traceback (most recent call last):
13 matches
Mail list logo
