[issue6818] remove/delete method for zipfile/tarfile objects

Change by nergall2 : -- pull_requests: +18720 pull_request: https://github.com/python/cpython/pull/19358 ___ Python tracker ___ ___ P

[issue6818] remove/delete method for zipfile/tarfile objects

nergall2 added the comment: Sorry, typo, here's the new PR - https://github.com/python/cpython/pull/19358 -- ___ Python tracker ___

[issue6818] remove/delete method for zipfile/tarfile objects

nergall2 added the comment: Closed my initial PR and opened this one instead - https://github.com/python/cpython/pull/19336 -- ___ Python tracker ___ __

[issue6818] remove/delete method for zipfile/tarfile objects

Change by nergall2 : -- pull_requests: +18719 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19336 ___ Python tracker ___ _

[issue6818] remove/delete method for zipfile/tarfile objects

nergall2 added the comment: I wasn't aware of this issue and opened another one which I just closed as a duplicate - https://bugs.python.org/issue40175 I also submitted a PR for the other one - https://github.com/python/cpython/pull/19336 The implementation does involve shifting the bytes of

[issue6818] remove/delete method for zipfile/tarfile objects

Denis Akhiyarov added the comment: has this been merged? -- nosy: +Denis Akhiyarov ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6818] remove/delete method for zipfile/tarfile objects

Dave Sawyer added the comment: Maybe it takes a little longer than a week. I have a final signed agreement from Ewa (https://secure.echosign.com/public/viewAgreement?aid=X88L4EVP5IXC289&eid=X88M6DGQ93J5K38&;) signed on 04/17/2014 6:48 PM Wow, exactly one year ago! --

[issue6818] remove/delete method for zipfile/tarfile objects

Christian Heimes added the comment: Around PyCon it might take a little longer than a week. IIRC Ewa does the paper work. She is also on the organizing committee of PyCon. -- ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Dave Sawyer added the comment: I can add some more tests to bring up the coverage, but wanted to get reviewer opinion on the direction of this before doing more work. -- hgrepos: +305 Added file: http://bugs.python.org/file39063/zipfile_filter.patch

[issue6818] remove/delete method for zipfile/tarfile objects

Dave Sawyer added the comment: The zipfile way to delete or rename would be to just change the index. It really doesn't want to be re-written as it is designed to span disks. Many old versions of files can be scattered within the zip. In addition self-extracting zip files will have executable

[issue6818] remove/delete method for zipfile/tarfile objects

Terry J. Reedy added the comment: All of you who have or might submit patches -- Victorlee, Troy, Mathew, or anyone else, please sign a PSF contributor agreement. We should not even look at a patch from you before you do. Info: https://www.python.org/psf/contrib/ Form: https://www.python.org/

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Matthew Gamble : Added file: http://bugs.python.org/file38879/zip_hiddenfiles.zip ___ Python tracker ___ ___ Python-bugs-list mailin

[issue6818] remove/delete method for zipfile/tarfile objects

Matthew Gamble added the comment: Hi, I've recently been working on a Python module for the Adobe universal container format (UCF) which extends the zip specification - as part of this I wanted to be able to remove and rename files in an archive. I discovered this issue when writing the modul

[issue6818] remove/delete method for zipfile/tarfile objects

Dave Sawyer added the comment: I'd be interested in taking up the zip portion at Pycon 2015 this year. I recently had need to delete file(s) from a zipfile. To do it today with the existing API requires you to unpack the zip and repack it. The unpack is slow and you need enough free disk space

[issue6818] remove/delete method for zipfile/tarfile objects

Serhiy Storchaka added the comment: I agree with Martin and Lars, this issue is not so easy at looks at first glance. For ZIP files we should distinct two different operations. 1. Remove the entry from the central directory (and may be mark local file header as invalid if it is possible). Thi

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Antoine Pitrou : -- nosy: +serhiy.storchaka versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list ma

[issue6818] remove/delete method for zipfile/tarfile objects

Yuval Greenfield added the comment: Ping. Has this been postponed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue6818] remove/delete method for zipfile/tarfile objects

Christian Heimes added the comment: Yuval has submitted a CLA. I'm moving the proposal to 3.4 as 3.3 is in feature freeze mode. -- nosy: +christian.heimes stage: -> patch review versions: +Python 3.4 -Python 3.3 ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Arthur Darcet : -- nosy: +Arthur.Darcet ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue6818] remove/delete method for zipfile/tarfile objects

Martin v. Löwis added the comment: As for adding yourself to the CC list: notice the string "ubershmekel" appearing in the "CC" field of http://bugs.python.org/review/6818/show. It means that you are already on the CC list. -- ___ Python tracker <

[issue6818] remove/delete method for zipfile/tarfile objects

Martin v. Löwis added the comment: Yuval, can you please submit a contributor agreement? See http://www.python.org/psf/contrib/ -- ___ Python tracker ___ ___

[issue6818] remove/delete method for zipfile/tarfile objects

Yuval Greenfield added the comment: I'm not sure I understand how http://bugs.python.org/review/6818/show works. I've looked all over and only found remarks for "zipfile.remove.patch" and not for "zipfile.remove.2.patch" which addressed all the aforementioned issues. Also, I don't understand

[issue6818] remove/delete method for zipfile/tarfile objects

Éric Araujo added the comment: Martin did a review of the newer patch; maybe you didn’t get the mail (there’s a Rietveld bug when a user name without email is given to the Cc field). -- ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Yuval Greenfield added the comment: Fixed the bugs Martin pointed out and added the relevant tests. Sadly I had to move some stuff around, but I think the changes are all for the better. I wasn't sure about the right convention for the 2 constants I added btw. -- Added file: http://bu

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue6818] remove/delete method for zipfile/tarfile objects

Yuval Greenfield added the comment: I fixed the bugs I found, added tests and documentation. What do you guys think? -- keywords: +patch Added file: http://bugs.python.org/file21063/zipfile.remove.patch ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Terry J. Reedy added the comment: Please feel free to test, revise, and write. Though 'removed', the file is still accessible via the history list. (Click 'zipfile_remove.patch' and then 'download'.) -- nosy: +terry.reedy ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Yuv Gre added the comment: What's the status with this patch? If nobody's looking at it I can try to see if it works and write the test and documentation for it. -- nosy: +ubershmekel versions: +Python 3.3 -Python 3.1 ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Sandro Tosi : -- keywords: -patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Sandro Tosi : -- nosy: +sandro.tosi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue6818] remove/delete method for zipfile/tarfile objects

Troy Potts added the comment: My patch had some bugs, I'll need to do some more testing. Sorry about that. -- ___ Python tracker ___

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Troy Potts : Removed file: http://bugs.python.org/file17847/zipfile_remove.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6818] remove/delete method for zipfile/tarfile objects

Troy Potts added the comment: I have attempted to implement a ZipFile.remove function. It seems to work fine. I have submitted a patch. The method of implementation is: find the file's index in the file list, then sum the lengths of the file entries before it to find its location in the ar

[issue6818] remove/delete method for zipfile/tarfile objects

Martin v. Löwis added the comment: > I done it In a very *violent* way. > Is it ok for you thought? In the form in which you have done it, it is clearly unacceptable for inclusion in the library: we don't want to add two modules "delete" and "classtools". In addition, notice that code is for t

[issue6818] remove/delete method for zipfile/tarfile objects

victorlee129 added the comment: I done it In a very *violent* way. Is it ok for you thought? if so, would anybody please fix it into the lib? -- components: -IO nosy: +victorlee129 versions: +Python 3.1 -Python 3.2 Added file: http://bugs.python.org/file15199/delete.tar.gz ___

[issue6818] remove/delete method for zipfile/tarfile objects

Martin v. Löwis added the comment: > In light of Lars's comment on the matter, perhaps this functionality > could be added to zip files only. Surely it can be done, considering > that numerous utilities and even Windows Explorer provide such > functionality. Are you sure they are not creating

[issue6818] remove/delete method for zipfile/tarfile objects

Ross added the comment: In light of Lars's comment on the matter, perhaps this functionality could be added to zip files only. Surely it can be done, considering that numerous utilities and even Windows Explorer provide such functionality. I must confess that I am unfamiliar with the inner wor

[issue6818] remove/delete method for zipfile/tarfile objects

Lars Gustäbel added the comment: -1, although I can only speak for tarfile. Removing members from a tar archive sounds obvious and easy but it is *not*. A file in an archive is stored as a header block (that contains the metadata) followed by a number of data blocks (that contain the file's data

[issue6818] remove/delete method for zipfile/tarfile objects

Martin v. Löwis added the comment: -1. I don't think this can be implemented in a reasonable way, assuming that you want the file to become smaller as a consequence of removal. -- nosy: +loewis ___ Python tracker _

[issue6818] remove/delete method for zipfile/tarfile objects

Ross added the comment: Slight change to: "Such a method should probably only apply to archives that are in append mode as write mode would erase the original archive and read mode should render the archive immutable." The method should probably still apply to an archive in write mode. It is

[issue6818] remove/delete method for zipfile/tarfile objects

Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue6818] remove/delete method for zipfile/tarfile objects

Changes by Ross : -- components: +IO ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mail

[issue6818] remove/delete method for zipfile/tarfile objects

New submission from Ross : It would be most helpful if a method could be included in the TarFile class of the tarfile module and the ZipFile class of the zipfile module that would remove a particular file (either given by a name or a TarInfo/ZipInfo object) from the archive. Usage to remove a si