[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Ned Deily : -- resolution: accepted -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by STINNER Victor : Removed file: http://bugs.python.org/file16169/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by STINNER Victor : -- nosy: +benjamin.peterson, georg.brandl Removed file: http://bugs.python.org/file16209/unnamed ___ Python tracker ___ ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ned Deily added the comment: Also note that this feature has not been backported to 3.1 which means it will not be in the upcoming 3.1.2 release. (It will not be an issue for the python.org 3.1.2 installer which will be built with GNU readline as usual to support older systems.) --

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Meador Inge added the comment: On Thu, Feb 11, 2010 at 7:16 AM, Ronald Oussoren wrote: > > I've added the tests to the 2.6 branch and have ported the #ifdef guard > around the prototype for completion_matches to the trunk and 3.2. > Verified in trunk. Thanks Ronald! -- Added file: ht

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: I've added the tests to the 2.6 branch and have ported the #ifdef guard around the prototype for completion_matches to the trunk and 3.2. I'm therefore closing the issue. -- status: open -> closed ___ Python track

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Alexander Belopolsky : -- nosy: +Alexander.Belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Ronald, > That bit is not in the trunk, should it be forward ported to the trunk? Yes, that should be applied to trunk and 3.x to make it work on Mac OS X 10.5 (Leopard). I indicated that in msg98979. The explanation why that part is needed is given in ms

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Meador Inge added the comment: > That bit is not in the trunk, should it be forward ported to the trunk? FWIW, I would really like to have it. > The actual prototype on 10.5 and 10.6 is: > > char **completion_matches(const char *, CPFunction *); > > Wouldn't it be better to change th

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: I have a question about this bit of the patch: @@ -38,10 +38,31 @@ #if defined(_RL_FUNCTION_TYPEDEF) extern char **completion_matches(char *, rl_compentry_func_t *); #else +#if !defined(__APPLE__) extern char **completion_matches(char *, CPFunction *); #e

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: Zvezdan, your "fix1" patch works perfectly for me in Python 2.6 on both OS X 10.5 and 10.6. Great work! I approve applying this patch for Python 2.6.5. Ronald, would you like to do the honors? -- assignee: -> ronaldoussoren resolution: fixed -> a

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: re: msg98913 The addition of an #include of stdlib.h is unnecessary because Python.h already does that. re: msg98908 Building against with a 10.3 deployment target should be harmless. A universal build targets 10.3 on purpose because that results in bina

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Zvezdan Petkovic : Added file: http://bugs.python.org/file16163/readline-libedit-trunk.patch ___ Python tracker ___ ___ Python-bugs-

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Zvezdan Petkovic : Added file: http://bugs.python.org/file16162/readline-libedit-2.6.5-fix1.patch ___ Python tracker ___ ___ Python-

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Zvezdan Petkovic : Removed file: http://bugs.python.org/file16161/readline-libedit-trunk.patch ___ Python tracker ___ ___ Python-bug

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Zvezdan Petkovic : Removed file: http://bugs.python.org/file16160/readline-libedit-2.6.5-1.patch ___ Python tracker ___ ___ Python-b

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Meador, I just looked at your patch (it seems we were posting patches at about the same time). That's a good fix too. Barry it's your call. -- ___ Python tracker _

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: The patch with the same correction against trunk is attached so that Meador can test it. -- Added file: http://bugs.python.org/file16161/readline-libedit-trunk.patch ___ Python tracker

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: OK, so issue4204 patch is causing problems. As I mentioned before we could choose to #ifdef __FreeBSD__ or check whether __APPLE__ is not defined. I'm attaching a new patch for 2.6.5 (2.6 branch) that uses the __APPLE__ check. -- Added file: http://

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Meador Inge added the comment: > If not, then we need to make a choice of #ifdef __FreeBSD__ as I > suggested in issue4204, or #ifndef __APPLE__ as I used in my first > personal version of the patch. In the off chance that this same problem were to occur on another platform, wouldn't be bett

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: @Meador: confirmed. This does not fix the 10.5 build. -- ___ Python tracker ___ ___ Python-bugs-li

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Meador Inge added the comment: > Can you please try inserting that include and see if 10.5 > builds readline? This does not work out of trunk for me: euclid:trunk minge$ sw_vers ProductName:Mac OS X ProductVersion: 10.5.7 BuildVersion: 9J61 euclid:trunk minge$ svn diff Index: Modules/r

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Barry, I'm sorry, I only now noticed this line in your compilation on 10.5: /Users/barry/projects/python/python26/Modules/readline.c:41: error: conflicting types for 'completion_matches' This problem was introduced by a patch in issue4204. See my comments

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ned Deily added the comment: It's not a configuration bug. All current python.org python installers are built with MACOSX_DEPLOYMENT_TARGET=10.3 and with the 10.4u SDK to allow one installer to work on systems from 10.3.9 through 10.6. -- nosy: +ned.deily ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: This is a configuration bug: /Users/barry/projects/python/python26/Modules/readline.c -o build/temp.macosx-10.3-ppc-2.6 ... Why is it trying to build using macosx-10.3 target? I bet if you specify MACOSX_DEPLOYMENT_TARGET=10.5 on the ./configure line it wi

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: This worked fine on OS X 10.6, but failed on OS X 10.5: gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/Users/barry/projects/python/python26/./Include -I/Users/barry/projects/python/python26/./Mac/Include -I. -IInclude -I./I

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: I forgot to add that the patch for 2.6.5 is based on: http://svn.python.org/view?rev=74970&view=rev -- ___ Python tracker ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: The readline-libedit-2.6.5.patch is attached. The patch was applied and python built in several configurations on Mac OS X 10.6 (Snow Leopard). There is no regression (details below). Can somebody else test on Mac OS X 10.5 (Leopard)? 32-bit == Config

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Barry A. Warsaw : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: release blocker for 2.6.5 -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-l

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Barry A. Warsaw added the comment: The readline-libedit-2.patch no longer applies against the 2.6 branch because of changes in setup.py since then. If this is fixed and the subsequent patch is reviewed and approved, then this can be landed for Python 2.6.5. -- __

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Sridhar Ratnakumar : -- nosy: +srid ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Brett, IMO, your backtrace only implies that readline module was built believing it has libedit (i.e., include files were system ones from /usr/include). However, the following scenario is possible. Some packaging tools choose to divide library packages

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Brett Cannon added the comment: I'm on OS X 10.6 and I *thought* I was using GNU Readline 6. But if my backtrace implies otherwise something must have gotten messed up somewhere on my end. When I deleted Readline and rebuilt everything worked fine. I'm going to go ahead and close this as you

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: Zvezdan: I did not have to pass additional arguments to get readline, the default machinery automaticly picks up libraries in /usr/local. I'd love to have a way to restrict the default compiler and linker search paths to system locations (e.g. exclude /usr/l

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: I assume you had to pass extra -I and -L flags when compiling with GNU readline. Right? -- ___ Python tracker ___ __

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: I've tested with readline 6 on OSX 10.6 as well. Both that and the system readline (libedit emulation) work just fine for me. The current behaviour for me: * When GNU readline is present in /usr/local it gets used * Otherwise libedit gets used -- __

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: Better yet: otool -vL $(python -c 'import readline; print readline.__file__') (Replace "python" by the interpreter that your actually using). I'm still interested to know the OS release as well. -- ___ Python

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Make that python2.6 in the command above. :-) -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Brett, what does this command return for you? otool -L /path/to/lib/python2.4/lib-dynload/readline.so -- ___ Python tracker ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: This should have been closed, although readline shouldn't crash either. Brett: What version of OSX do you use? Readline works fine for me on OSX 10.6 without GNU readline. BTW. The crashlog indicates you are no longer using GNU readline, but use system read

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Brett Cannon added the comment: Is this open or closed? Wondering as I just updated my checkout and I am now segfaulting at the command-line whenever I import something under readline 6.0 which was working fine. >>> import tokenize Program received signal EXC_BAD_ACCESS, Could not access me

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Changes by Ronald Oussoren : -- resolution: -> fixed stage: -> committed/rejected type: crash -> compile error ___ Python tracker ___ ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: Committed my latest version of the patch as r74970 (trunk) and r74971 (3.2) Barry: what's your opinion on a backport of this to 2.6? -- nosy: +barry ___ Python tracker

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: Mark: it turns out that GNU readline has a rather odd interface, only the index of get_history_item is 1-based, all others are 0-based. This is not mentioned in the documentation (neither that of the readline module or the GNU documentation). I've attached

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: Mark: yes those functions need to be changed as well. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Mark Dickinson added the comment: Do the remove_history_item and replace_history_item functions also need the off-by-one adjustment? -- nosy: +marketdickinson ___ Python tracker ___

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: The patch `readline-libedit.patch` has the following problems: - a typo causing an undefined variable error; - a missing "#endif"; - it doesn't refer to the new __APPLE__ specific doc string anywhere. It fails to compile `readline.c`. :: Modules/readlin

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: The attached patch is a slightly cleaner version of your patch. What I don't like is that I'm also using runtime detection of libedit, I'd prefer compile-time detection but that doesn't seem possible without doing that dtection in setup.py. My changes w.r.t

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: > It would also be nice if one could programmaticly detect if readline > is linked to libedit There's this rl_library_version constant defined in editline/readline C libraries that the attached patch uses. Perhaps, if we can expose its value from the Python

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Ronald Oussoren added the comment: I'm +1 on merging this functionality. See also: issue6872 As I mentioned there we should ensure that readline linked to libedit has the same semantics as readline linked to GNU readline, and because the configuration file of libedit has a different format a

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: When testing the patch make sure that your readline module has been actually linked against editline library rather then some copy of GNU readline from MacPorts or Fink. Assuming --prefix=${HOME}/opt, the output of otool -L ~/opt/lib/python2.4/lib-dynl

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

Zvezdan Petkovic added the comment: Changed type to "crash" because compilation of readline module without this patch was causing Python to crash with BusError. -- type: compile error -> crash ___ Python tracker _

[issue6877] enable compilation of readline module on Mac OS X 10.5 and 10.6

New submission from Zvezdan Petkovic : The attached patch enables compilation and use of the readline module on Mac OS X 10.5 (Leopard) and 10.6 (Snow Leopard). It utilizes the native editline library (used for emulation of the readline library on Mac). I used the patch for almost two years al