Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: needs patch - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
___
Roundup Robot added the comment:
New changeset 486c1a81ee32 by Berker Peksag in branch 'default':
Issue #6916: Use assertWarns in test_asynchat.
http://hg.python.org/cpython/rev/486c1a81ee32
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
asynchat.fifo is now explicitly marked as deprecated and scheduled for removal
in Python 3.6. I consider that the issue is done and so I'm closing it. Reopen
a more specific issue if you consider that there is still something to do.
@Berker: You may apply
Roundup Robot added the comment:
New changeset aeeb385e61e4 by Giampaolo Rodola' in branch 'default':
#6916: attempt to fix BB failure
http://hg.python.org/cpython/rev/aeeb385e61e4
--
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
Would using assertWarns be more suitable here? Attached a patch.
--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file35722/use-assertwarns.diff
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
IMHO until the code is there, the documentation also should be there -- even if
it just to acknowledge the existence of the code and signal its deprecation.
Whether the code is eventually removed or not it's a separate issue.
--
Roundup Robot added the comment:
New changeset 233168a2a656 by Giampaolo Rodola' in branch 'default':
#6916: raise a deprecation warning if using asynchat.fifo
http://hg.python.org/cpython/rev/233168a2a656
--
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
Signaling the deprecation or just the existence of asynchat.fifo really isn't
worth the effort because the code is no longer used since fifo was replaced
with a deque in python 2.6.
Basically it's dead code and the only reason it remained there is because
Raymond Hettinger added the comment:
The tests are failing:
==
ERROR: test_basic (test.test_asynchat.TestFifo)
--
Traceback (most recent call last):
File
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
priority: normal - high
resolution: fixed -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
Ezio Melotti added the comment:
I don't think removing the documentation for a deprecated item is a good
solution. If people find it somewhere (old code, googling, via dir()) and find
no related documentation, they might keep using it.
If it's clearly documented that the item exists but it's
Raymond Hettinger added the comment:
I don't think removing the documentation for a deprecated item is a good
solution.
Dedocumenting is a reasonable thing to do and I believe we've done it several
times before, leaving code only so as to not break anything. I expect this
code to get zero
Roundup Robot added the comment:
New changeset 42a645d74e9d by Giampaolo Rodola' in branch 'default':
fix issue #6916: undocument deprecated asynchat.fifo class.q
http://hg.python.org/cpython/rev/42a645d74e9d
--
nosy: +python-dev
___
Python tracker
Giampaolo Rodola' added the comment:
I simply removed asynchat.fifo documentation. Closing this out.
--
resolution: - fixed
status: open - closed
versions: +Python 3.5 -Python 3.2
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Is it worth the effort of committing changes like this when according to
https://docs.python.org/3/library/asynchat.html#module-asynchat This module
exists for backwards compatibility only. For new code we recommend using
asyncio.? See also issue6911.
Ezio Melotti added the comment:
What's the status of this?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: josiahcarlson - giampaolo.rodola
stage: - patch review
versions: -Python 3.0, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +d...@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
___
Python-bugs-list
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I seem to remember that those classes were initially removed and then re-added
by Josiah for backward compatibility (see discussions in issue 1641 and issue
1736190).
Despite practically useless after the changes applied to asynchat in
Changes by Giampaolo Rodola' billiej...@users.sourceforge.net:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
Changes by Georg Brandl ge...@python.org:
--
assignee: georg.brandl - josiahcarlson
nosy: +josiahcarlson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6916
___
New submission from Robert Lehmann lehman...@gmail.com:
The patches in issue1736190 deprecated fifo and simple_producers. These
are safe for removal in Python 3.0.
I attached a patch purging fifo and simple_producers from py3k code and
tests. The docs are mostly trivial as well but also touched
22 matches
Mail list logo
