Berker Peksag added the comment:
All changes (except PyUnicode_EncodeDecimal() which was deprecated in Python
3.3) have already been implemented in the following commits:
*
https://github.com/python/cpython/commit/c679227e31245b0e8dec74a1f7cc77710541d985
*
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6952
___
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Drop 2.7 as it's gone. See also #1699259.
--
nosy: +BreamoreBoy
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6952
Barry Alan Scott barry-sc...@users.sourceforge.net added the comment:
Updated patch with comment explaining cast.
--
Added file: http://bugs.python.org/file15184/const_api_r75619.patch
___
Python tracker rep...@bugs.python.org
Barry Alan Scott barry-sc...@users.sourceforge.net added the comment:
I was trying to avoid changing the const ness of output parameters.
Given the advice not to go mad on putting const everywhere.
1) I can comment the casts to maintain this goal.
2) Or change the output paramter const ness.
Martin v. Löwis mar...@v.loewis.de added the comment:
1) I can comment the casts to maintain this goal.
2) Or change the output paramter const ness.
Given your feedback I'm guessing you want me to go further with
the use of const and do (2).
Ah, ok - as I said, I didn't look into detail
Barry Alan Scott barry-sc...@users.sourceforge.net added the comment:
Here is my 1st patch to allow const char * and const Py_UNICODE *
It is agsinst http://svn.python.org/projects/python/trunk.
What I have attempted to do is stop the public API of python needing
char * or Py_UNICODE * where
Martin v. Löwis mar...@v.loewis.de added the comment:
Without looking into the details: the places where you cast-away
constness look wrong. Either the parameter shouldn't have been declared
const, or the target of the assignment needs to be converted to const,
too. If the cast is really
Trundle andy-pyt...@hammerhartes.de added the comment:
See also issue #1699259.
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6952
___
Changes by Sebastian Ramacher sebasti...@users.sourceforge.net:
--
nosy: +sebastinas
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6952
___
___
Barry Alan Scott barry-sc...@users.sourceforge.net added the comment:
I'd guess that this change can first be made against 2.7 and 3.2
so that API's do not change.
Where do I find the source code to generate the patch against
for 2.7 and 3.2?
--
___
R. David Murray rdmur...@bitdance.com added the comment:
Take a look at http://www.python.org/dev, specifically the 'How to Get
Started' article (which points you to the developer's FAQ, which
explains how to do an anonymous checkout of the source).
--
nosy: +r.david.murray
R. David Murray rdmur...@bitdance.com added the comment:
I'm setting the targets to 2.7/3.2 per the discussion in issue #1699259.
Perhaps the question of whether or not it is really an API change
could be revisited, but if so that would probably have to go through
python-dev.
--
New submission from Barry Alan Scott barry-sc...@users.sourceforge.net:
Many Python API functions are causing GCC to rightly complain
that const char * strings are being passed to python functions
that take char * but do not need to modify the args.
g++ reports example.cxx:633: warning:
Martin v. Löwis mar...@v.loewis.de added the comment:
A patch would definitely help. Such a patch shouldn't whole-sale replace
char with const char, but selectively only change locations where it is
actually necessary and doesn't hurt.
--
nosy: +loewis
15 matches
Mail list logo
