Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Thanks, Jesse -- it looks good. If there are bugs remaining in the patch,
they're mine and not yours.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
Jesse Noller jnol...@gmail.com added the comment:
Committed to trunk in r77794
Merged to Py3k in r77795
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
Jesse Noller jnol...@gmail.com added the comment:
Attached is the ported patch for Python 2.7/trunk. Please review it to make
sure I didn't completely flub anything. I noticed you had forgotten the
maxtasksperchild argument in the unit test, so I added that. I also expanded
the docs a little
Jesse Noller jnol...@gmail.com added the comment:
I'm working on this now; I'm going to need to port the patch to trunk before
moving forward with it. Shouldn't take me long.
--
___
Python tracker rep...@bugs.python.org
Changes by Charles Cazabon charlesc-pyt...@pyropus.ca:
Removed file: http://bugs.python.org/file14987/worker-lifetime-python2.6.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
No problem, Jesse, I realize you're busy.
I've updated the patch very slightly to handle an issue I had where the worker
maintainer hung once.
--
Added file:
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Ping... two alphas into 2.7. Have you had a chance to review this
functionality?
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
Changes by Brian Curtin cur...@acm.org:
--
keywords: +needs review
priority: - normal
stage: - patch review
versions: +Python 3.2 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
Jesse Noller jnol...@gmail.com added the comment:
I'm fine with the functionality; I'm going to test it out and look at
committing it by mid-week next week. I apologize, I've been pretty maxed out.
--
___
Python tracker rep...@bugs.python.org
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Hi Jesse -- Any chance you'll be able to review this in time for it to
make it into trunk for the 2.7 alpha release?
Charles
--
___
Python tracker rep...@bugs.python.org
Jesse Noller jnol...@gmail.com added the comment:
On Sat, Nov 14, 2009 at 11:43 AM, Charles Cazabon
rep...@bugs.python.org wrote:
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Hi Jesse -- Any chance you'll be able to review this in time for it to
make it into trunk for the
Jesse Noller jnol...@gmail.com added the comment:
I plan on reviewing the patch once my work with PyCon is completed, which
should be within the next few weeks. The next release this would show up
in (2.7/3.2) is not for some time.
--
___
Python
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Okay, thanks, Jesse. Didn't realize the Con was on.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
Jesse Noller jnol...@gmail.com added the comment:
Well, it's in feb, but I'm involved in some intense planning right now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Can someone review this patch? I believe it's sufficient for inclusion
now, as it includes docs and unit tests, but if anything about it
requires further attention I'd be happy to listen to change requests.
We'd like get this into
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Jesse: this is ready for your review now. Thanks,
Charles
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
Jesse Noller jnol...@gmail.com added the comment:
Hi Charles; I don't see a doc update for this (see multiprocessing.rst) or
unit tests. I'm not against it, but before I can commit this, I'll need
those things
--
___
Python tracker
Charles Cazabon charlesc-pyt...@pyropus.ca added the comment:
Alright, I'll add those. Thanks for looking at it; first pass was
mostly to ensure it wouldn't be wasted work.
--
___
Python tracker rep...@bugs.python.org
Changes by Charles Cazabon charlesc-pyt...@pyropus.ca:
Removed file: http://bugs.python.org/file14946/worker-lifetime-python2.6.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
Changes by Charles Cazabon charlesc-pyt...@pyropus.ca:
Added file: http://bugs.python.org/file14947/worker-lifetime-python2.6.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6963
___
20 matches
Mail list logo
