Mark Dickinson dicki...@gmail.com added the comment:
I don't think it is safe to remove all *.pickle files in the source
directory; even if there aren't any other useful .pickle files right now,
there could be in the future (e.g. for pickle testing).
I'd prefer something more targeted.
Are
egreen egr...@operamail.com added the comment:
These .pickle files aren't created by the tests themselves, but they do
show up after running 'make test', or more specifically after running
'./python Lib/test/regrtest.py -v test_lib2to3'.
This is because a grammar generated from a .txt grammar
Mark Dickinson dicki...@gmail.com added the comment:
IMHO, though it may be preferable to remove just the pickle files in
Lib/lib2to3,
Sounds reasonable.
it should never be required for tests to have pickle files
already available in the source tree.
Well, I don't know about 'should', but
egreen egr...@operamail.com added the comment:
You are right. Guess I was being a little too dogmatic. :-)
I hadn't found those .pck files, because I was only looking for binary
files.
Here's a new patch proposal.
--
Added file:
Mark Dickinson dicki...@gmail.com added the comment:
Thanks! I'll apply this later today, unless Benjamin gets there first. :)
--
resolution: - accepted
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6982
Mark Dickinson dicki...@gmail.com added the comment:
Committed in r75047 (trunk). Merged in r75048 (release26-maint), r75049
(py3k) and r75050 (release31-maint).
--
assignee: - mark.dickinson
stage: patch review - committed/rejected
status: open - closed
New submission from egreen egr...@operamail.com:
make clean and make distclean don't remove the grammar pickles generated
by load_grammar in Lib/lib2to3/pgen2/driver.py
(Lib/lib2to3/Grammar3.2.0.alpha.0.pickle,
Lib/lib2to3/PatternGrammar3.2.0.alpha.0.pickle).
Proposed patch attached. It removes
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +benjamin.peterson
priority: - low
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6982
___
