[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-18 Thread Ned Deily
Ned Deily added the comment: Verified that test_urllib2 no longer fails with 2.6.4rc2. -- ___ Python tracker ___ ___ Python-bugs-list

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-18 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-18 Thread Ronald Oussoren
Ronald Oussoren added the comment: Fixed in r75483 (2.6), 75482 (trunk) -- resolution: accepted -> fixed stage: -> committed/rejected type: -> behavior ___ Python tracker ___ _

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-17 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Ronald, please apply asap. This is the last thing I'm waiting on before I tag 2.6.4rc2. -- resolution: -> accepted ___ Python tracker ___ ___

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread Ned Deily
Ned Deily added the comment: BTW, I did test manually changing the system proxy configuration via the Network preference panel and verified that urllib/urllib2 used the default proxy settings. I suppose it would be possible to set up some tests using the OS X scutil command but it would be t

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread Ned Deily
Ned Deily added the comment: The supplied patch looks good and applies cleanly to 2.6 as well. I built and tested it with both 2.6 and trunk and the tests now all pass as expected. -- versions: +Python 2.7 ___ Python tracker

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread jweber
Changes by jweber : -- nosy: +jweber ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mail

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Agreed this is a release blocker for 2.6.4rc2. I plan on tagging the release some time Saturday, probably around 1600 UTC. Do you think you can add a test and apply the patch by then? -- ___ Python tracker

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread Ned Deily
Ned Deily added the comment: I'll test it on 2.6 later today. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've attached a patch for the trunk that fixes the issue and passes test_urllib.py on the trunk. What I haven't done yet is write some unittests that actually test different proxy configurations, that would require changing the SystemConfigation proxy setti

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: In the Issue7044, the reporter has identified the root cause and possible fix too. " In Python 2.6.3 on Mac OS 10.6.1, there is a bug in lib/python2.6/urllib.py, line 1367. The variable hostIP is used before it's defined. You can fix it by adding "hostIP = No

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: Barry: this should be a release blocker, I introduced the problem around or after 2.6.3 :-( When do you cut rc2? I probably won't be able to provide a patch myself until Saturday afternoon (CEST). -- priority: -> release blocker __

[issue7149] 2.6.4rc1 regression: test_urllib2 fails on OS X with UnboundLocalError

2009-10-15 Thread Ned Deily
New submission from Ned Deily : Possible Release Blocker A number of proxy test cases in test_urllib2 are now failing with: ERROR: test_proxy (test.test_urllib2.HandlerTests) -- Traceback (most recent call last): File "/Libr