Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file15273/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
___
Éric Araujo mer...@netwok.org added the comment:
Not sure if this merits a new bug report: The conversion currently promotes the
open().read() anti-pattern, which is not guaranteed to release file handles as
soon as possible in all VMs. Using a with block would fix that.
--
nosy:
Benjamin Peterson benja...@python.org added the comment:
Closing since compile() will work properly now.
--
resolution: - works for me
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
Benjamin Peterson benja...@python.org added the comment:
I've fixed underlying compile() newline problem in the trunk and py3k.
However, I think that change is big enough that I don't want to to
backport it. I'm leaving this open to think about what to do with 2to3
in this situation.
--
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment:
This is a patch for the execfile fixer, so it converts
execfile(fn)
into this:
exec(compile(open(fn).read()+'\n', fn, 'exec'))
(Yes, it looks ugly. A better way would be to fix the compile() builtin
so it does not
New submission from flashk fla...@gmail.com:
I recently ran 2to3 on some of my scripts and noticed a change in behavior.
I had a script that used the built-in execfile function. After the conversion,
it was
changed to manually open the file and read the contents into the exec function.
Now I
Benjamin Peterson benja...@python.org added the comment:
Could you attach the files separately or paste them into the bug? zip
files are hard to work with.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
Changes by flashk fla...@gmail.com:
Added file: http://bugs.python.org/file15268/test.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
___
___
Changes by flashk fla...@gmail.com:
Added file: http://bugs.python.org/file15269/execfile_example.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
___
Changes by flashk fla...@gmail.com:
Added file: http://bugs.python.org/file15270/execfile_example_converted.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
___
flashk fla...@gmail.com added the comment:
I just attached the files individually.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
___
___
Benjamin Peterson benja...@python.org added the comment:
test.py is invalid Python 3 syntax.
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7268
flashk fla...@gmail.com added the comment:
I'm running this code under 2.6, so the print statement should not be the
issue. I've attached a new version of test.py that simply performs a
variable assignment and I still get the syntax error on both 2.6 and 3.1
with the exec function. Also, the
Benjamin Peterson benja...@python.org added the comment:
This is because you have DOS newlines which the Python compiler cannot
handle. In 2.x, open(test.py, r) does not translate newlines. In
3.x, it does.
--
___
Python tracker
flashk fla...@gmail.com added the comment:
Ok, I converted test.py to use Unix style newlines and still get the
syntax error on both 2.6 and 3.1. I'm confused as to why execfile works on
the file but reading the contents and passing it to exec behaves
differently under 2.6. Sorry if I'm just
Benjamin Peterson benja...@python.org added the comment:
2009/11/5 flashk rep...@bugs.python.org:
flashk fla...@gmail.com added the comment:
Ok, I converted test.py to use Unix style newlines and still get the
syntax error on both 2.6 and 3.1. I'm confused as to why execfile works on
the
flashk fla...@gmail.com added the comment:
Ok, but why am I still getting a syntax error in both 2.6 and 3.1 on the
file, even after converting the newlines?
If I remove the trailing indentation then everything works properly on 2.6
and 3.1, even with DOS newlines.
It just seems that exec
Benjamin Peterson benja...@python.org added the comment:
2009/11/5 flashk rep...@bugs.python.org:
flashk fla...@gmail.com added the comment:
Ok, but why am I still getting a syntax error in both 2.6 and 3.1 on the
file, even after converting the newlines?
If I remove the trailing
flashk fla...@gmail.com added the comment:
On Thu, Nov 5, 2009 at 5:48 PM, Benjamin Peterson rep...@bugs.python.orgwrote:
Well, it works for me with the empty newline. Can you isolate the exact
problem?
For me, the exact problem seems to be that exec raises a SyntaxError if the
code
flashk fla...@gmail.com added the comment:
I noticed that calling exec('\t') raises a SyntaxError, so maybe this is
the root of the problem. I manually added a newline character to the end
of the file contents and it fixes the issue for me:
exec(compile(open('test.py').read()+'\n', 'test.py',
20 matches
Mail list logo