Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c4d884d5d86c by R David Murray in branch '2.7':
#7484: no more around addresses in VRFY or EXPN
http://hg.python.org/cpython/rev/c4d884d5d86c
New changeset f8c4ac9aa9e2 by R David Murray in branch '3.2':
#7484: no
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 50b6c3053c30 by R David Murray in branch 'default':
#7484: simplify quoteaddr: if parseaddr throws an error it is a bug.
http://hg.python.org/cpython/rev/50b6c3053c30
--
R. David Murray rdmur...@bitdance.com added the comment:
Thank you both for your work on this. The patch I committed is a combination
of my _addr_only, Filipe's tests, and Catalin's modifications to those tests.
quoteaddr, although in the __all__, is not documented and is really an
Felipe Cruz felipec...@loogica.net added the comment:
You're very kind David.
Hope I can contribute with something more relevant next time :)
best regards,
Felipe
2011/7/18 R. David Murray rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Thank you both for
R. David Murray rdmur...@bitdance.com added the comment:
Don't short change yourself. This bug would still be open if it hadn't been
for your work, regardless of how much of it wound up in the final patch :)
--
versions: +Python 3.3 -Python 2.6, Python 3.1
Catalin Iacob iacobcata...@gmail.com added the comment:
I looked at the Felipe's patch and hopefully made some improvements.
Unlike Felipe's patch I didn't change the reply of the SMTP server in the tests
but instead use what VRFY and EXPN actually send to index the users and lists
Changes by Catalin Iacob iacobcata...@gmail.com:
Added file: http://bugs.python.org/file22680/88b5c7ab7a03.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
Felipe Cruz felipec...@loogica.net added the comment:
Can anyone take a loot at those patches?
Do they need more tests?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
Felipe Cruz felipec...@loogica.net added the comment:
David..
I extracted quoteaddr code to _addrformat and now quoteaddr and _addronly call
_addrformat passing a format (%s or %s).
I've also created quoteaddr and _addronly test functions as well modified VRFY
and EXPN tests to make sure
Changes by Felipe Cruz felipec...@loogica.net:
Added file: http://bugs.python.org/file21652/issue7484-27_2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
Changes by Catalin Iacob iacobcata...@gmail.com:
--
nosy: +catalin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
___
Python-bugs-list
Felipe Cruz felipec...@loogica.net added the comment:
I've rewrote those patches to 'default' and 2.7
--
nosy: +felipecruz
Added file: http://bugs.python.org/file21641/issue7484-py3k.diff
___
Python tracker rep...@bugs.python.org
Changes by Felipe Cruz felipec...@loogica.net:
Added file: http://bugs.python.org/file21642/issue7484-27.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for working on this.
The tests seem to be missing, as is the line that adds 'clean' to the def, so
the patches won't work as is.
However, now that I've looked at the patch in more detail, adding a parameter
to a public method is
Pablo Mouzo pablomo...@gmail.com added the comment:
This patch solves the problem with the VRFY command, but I'm still
wondering if this happens with other commands too.
--
keywords: +patch
nosy: +pablomouzo
Added file: http://bugs.python.org/file15674/issue7484-trunk.diff
Changes by Pablo Mouzo pablomo...@gmail.com:
Added file: http://bugs.python.org/file15675/issue7484-py3k.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7484
___
R. David Murray rdmur...@bitdance.com added the comment:
I agree. My reading of the rfc is that the form without the brackets
*must* be supported by the MTA, while any other form is optional. So
smtplib should use the required form for its VRFY query. Any MTA that
doesn't recognize that form
New submission from Manuel Pégourié-Gonnard m...@elzevir.fr:
Hi,
The verify method of SMTP objects created with smtplib doesn't work
properly with servers running Postfix, due to quoting problems: the
address is enclosed in pointed brackets by the method, which changes the
way it is interpreted
18 matches
Mail list logo
