[issue7585] difflib should separate filename from timestamp with tab

anatoly techtonik added the comment: tag:difflib -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue7585] difflib should separate filename from timestamp with tab

R. David Murray added the comment: Yes, thanks for the typo correction. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue7585] difflib should separate filename from timestamp with tab

anatoly techtonik added the comment: r80004 and r80006 to be exact. Great! Thanks! =) -- ___ Python tracker ___ ___ Python-bugs-list

[issue7585] difflib should separate filename from timestamp with tab

R. David Murray added the comment: Applied to trunk in r8004 and py3k in r8006. -- resolution: accepted -> fixed stage: unit test needed -> committed/rejected status: open -> closed ___ Python tracker _

[issue7585] difflib should separate filename from timestamp with tab

R. David Murray added the comment: Great, thanks. I'll check this in when the branch is unfrozen. -- dependencies: -doctest should normalize tabs when comparing output ___ Python tracker _

[issue7585] difflib should separate filename from timestamp with tab

anatoly techtonik added the comment: Added unittest for tab with and without set filedate. Removed #7583 dependency with NORMALIZE_WHITESPACE. -- Added file: http://bugs.python.org/file16797/issue7585.difflib-tab-unittest.diff ___ Python tracker

[issue7585] difflib should separate filename from timestamp with tab

R. David Murray added the comment: We could avoid the 7583 problem by making the doctests use NORMALIZE_WHITESPACE and moving the real *tests* into the unittests for the module. I think that would be a good thing to do anyway. -- ___ Python tracke

[issue7585] difflib should separate filename from timestamp with tab

R. David Murray added the comment: Your last patch looks the best to me. I agree both that a tab should not be emitted if there is no date (which is what git, for example, does), and that ISO 8601 timestamps should be promoted as the preferred format. As you pointed out, issue 7583 needs to

[issue7585] difflib should separate filename from timestamp with tab

Changes by anatoly techtonik : Added file: http://bugs.python.org/file16734/issue7585.difflib-tab-updoc-iso8601.diff ___ Python tracker ___ __

[issue7585] difflib should separate filename from timestamp with tab

anatoly techtonik added the comment: These patches are incrementally add features. Feel free to apply one that suits most. Codereview provides more convenient way to review differences between these. attaching optional patch that removes recommendation to use ctime format for timestamps ---

[issue7585] difflib should separate filename from timestamp with tab

Changes by anatoly techtonik : Removed file: http://bugs.python.org/file16732/issue7585.difflib-tab-update-docs.diff ___ Python tracker ___ __

[issue7585] difflib should separate filename from timestamp with tab

Changes by anatoly techtonik : Added file: http://bugs.python.org/file16732/issue7585.difflib-tab-update-docs.diff ___ Python tracker ___ ___

[issue7585] difflib should separate filename from timestamp with tab

anatoly techtonik added the comment: Refreshed patches - feel free to apply in any order you want. Convenience link for reviews: http://codereview.appspot.com/809043/show -- ___ Python tracker

[issue7585] difflib should separate filename from timestamp with tab

Changes by anatoly techtonik : Added file: http://bugs.python.org/file16731/issue7585.difflib-tab-separator-no-trail.diff ___ Python tracker ___ _

[issue7585] difflib should separate filename from timestamp with tab

Changes by anatoly techtonik : Added file: http://bugs.python.org/file16730/issue7585.difflib-tab-separator.diff ___ Python tracker ___ ___ Py

[issue7585] difflib should separate filename from timestamp with tab

Changes by R. David Murray : -- dependencies: +doctest should normalize tabs when comparing output title: [patch] difflib should separate filename from timestamp with tab -> difflib should separate filename from timestamp with tab ___ Python tracker