Antoine Pitrou pit...@free.fr added the comment:
+def __eq__(self, other):
+r = (type(self) == type(other))
+if r:
+return r
I think this should be if not r.
--
___
Python tracker rep...@bugs.python.org
Craig Citro craigci...@gmail.com added the comment:
Antoine -- why do you want to switch if r for if not r?
If we did, the test would just confirm that the unpicked object was of the same
type as the original; if we were going to do that, we might as well just
replace the whole `__cmp__`
Antoine Pitrou pit...@free.fr added the comment:
Craig: I'm talking about the __eq__ version (durban's patch). The __cmp__
version is probably fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
Craig Citro craigci...@gmail.com added the comment:
Antoine -- ah, that makes sense. Is that the only blocker? I've let this patch
rot on the vine a long time; if so, I'll happily switch `__eq__` back to
`__cmp__` and re-post if it'll get submitted.
--
Antoine Pitrou pit...@free.fr added the comment:
No need, I'll do it myself.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 760ac320fa3d by Antoine Pitrou in branch '3.2':
Issue #7689: Allow pickling of dynamically created classes when their
http://hg.python.org/cpython/rev/760ac320fa3d
New changeset 46c026a5ccb9 by Antoine Pitrou in
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 64053bd79590 by Antoine Pitrou in branch '2.7':
Issue #7689: Allow pickling of dynamically created classes when their
http://hg.python.org/cpython/rev/64053bd79590
--
___
Antoine Pitrou pit...@free.fr added the comment:
This is fixed now, thank you!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
Brent Payne brent.pa...@gmail.com added the comment:
will the 2.7 patch also be incorporated into a 2.7 release?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
Antoine Pitrou pit...@free.fr added the comment:
Yes, it will.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
Specifically, 2.7.3. A date for that has not yet been set, but somewhere in the
December/January time frame is likely.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
Changes by Brent Payne brent.pa...@gmail.com:
--
nosy: +Brent.Payne
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list
Lance Hepler nlhep...@gmail.com added the comment:
Hello all, sorry to be a bother, but what's the progress on this issue? I have
a codebase that requires resolution of this issue to enable multiprocessing.
What are the remaining outstanding problems herein preventing the attached
patches
Changes by Lance Hepler nlhep...@gmail.com:
--
nosy: +nlhepler
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list mailing
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list mailing
Daniel Urban urban.dani...@gmail.com added the comment:
Attaching an updated patch for py3k.
Not an expert, but the Python parts of your patch look good to me.
Me neither, but the C parts also look good to me. The tests fail without the
patch, succeed with it.
Note, that it is possible, that
Changes by François Bissey francois.bis...@canterbury.ac.nz:
--
nosy: +fbissey
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Changes by Daniel Urban urban.dani...@gmail.com:
--
nosy: +durban
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
I was mistaken: bug fixes go in stable releases too.
--
versions: +Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
Éric Araujo mer...@netwok.org added the comment:
Not an expert, but the Python parts of your patch look good to me.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
Gerald Dalley dall...@deshaw.com added the comment:
Another use case: for distributed processing, it's handy to be able to pickle
interactive functions and functions that are part of a script. The user can
then remotely execute a broader set of functions than can be pickled by
default. This
Éric Araujo mer...@netwok.org added the comment:
Thanks for your report and patch. I’m editing the versions field: New features
and bug fixes go to the active branch, py3k (future 3.2), while only security
and documentation fixes are allowed to go in stable branches (2.6 and 3.1).
Current
Changes by Bryan Silverthorn bc...@cornell.edu:
--
nosy: +bsilverthorn
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
Python-bugs-list
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +alexandre.vassalotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7689
___
___
New submission from Craig Citro craigci...@gmail.com:
Currently, it's impossible to use the usual pickle mechanisms to pickle a
dynamically created class, even if the user requests a different pickling
mechanism via copy_reg. The attached patch makes this customization possible by
simply
25 matches
Mail list logo
