Florent Xicluna florent.xicl...@gmail.com added the comment:
Fixed with r79049 and r79050.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
Florent Xicluna florent.xicl...@gmail.com added the comment:
here come the patch.
--
components: +Tests
keywords: +easy, patch
stage: test needed - patch review
versions: +Python 2.7
Added file: http://bugs.python.org/file16572/issue8155_check_warnings_quiet.diff
Nick Coghlan ncogh...@gmail.com added the comment:
On a quick read through, the patch looks fine to me.
I actually agree it would be nice if we could keep the quiet=True default
(since it is a better match for the feature set we want in our own tests), but
I see the compatibility issue as a
Florent Xicluna florent.xicl...@gmail.com added the comment:
I hesitate to do it differently:
with check_warnings(('', RuntimeWarning)):
== translate to check_warnings(('', RuntimeWarning), quiet=False)
with check_warnings():
== translate to check_warnings(quiet=True)
If the developer
Nick Coghlan ncogh...@gmail.com added the comment:
On a second look, there are a couple of things missing:
- the default value didn't actually get changed!
- we should add an explicit test that the no argument behaviour doesn't raise a
warning by default
Since we don't really have an existing
Changes by Florent Xicluna florent.xicl...@gmail.com:
Removed file:
http://bugs.python.org/file16572/issue8155_check_warnings_quiet.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8155
___
Florent Xicluna florent.xicl...@gmail.com added the comment:
Patch updated.
--
Added file:
http://bugs.python.org/file16573/issue8155_check_warnings_quiet_v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8155
Nick Coghlan ncogh...@gmail.com added the comment:
Ah, I didn't notice that there were already tests for this in test_warnings
(that's what I get for commenting late at night).
Updated patch looks good.
--
___
Python tracker rep...@bugs.python.org
Changes by Nick Coghlan ncogh...@gmail.com:
--
title: Incompoatible change to test.test_support.check_warnings behaviour -
Incompatible change to test.test_support.check_warnings behaviour
___
Python tracker rep...@bugs.python.org
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8155
___
___
Python-bugs-list mailing
10 matches
Mail list logo
