[issue8405] Improve test_os._kill (failing on slow machines)

2010-05-28 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Committed to trunk in r81584 and py3k in r81585. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue8405] Improve test_os._kill (failing on slow machines)

2010-05-28 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: Committed to trunk in r81584 and py3k in r81585 sparc solaris10 gcc trunk buildbot slave doesn't compile anymore. I'm not sure that it's related, so I prefer to not reopen the issue :-)

[issue8405] Improve test_os._kill (failing on slow machines)

2010-05-27 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: I just noticed the other day that a buildbot failed because of this issue. Attached is a patch which removes the unconditional 0.5 sleep, and increases the loop to run 100 times. It should cover the worst case of a super slow buildbot, but is

[issue8405] Improve test_os._kill (failing on slow machines)

2010-04-16 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: With the patch, the test have 1.0 second to succeed. I would prefer 5.0 or 10.0 seconds: it should not waste the 10 seconds because it should succeed if a new milliseconds. But if the machine is slow (which is the topic of the

[issue8405] Improve test_os._kill (failing on slow machines)

2010-04-15 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: I like this version of the patch better. Is there any reason not to drop the initial sleep(0.5) and loop 10 times instead? Any place we can cut down the sleeps so the test suite runs faster on fast machines is good. As someone else

[issue8405] Improve test_os._kill (failing on slow machines)

2010-04-14 Thread Brian Curtin
New submission from Brian Curtin cur...@acm.org: test_os._kill is used by test_kill_sigterm and test_kill_int and is failing on a slow Windows buildbot due to timing issues between the process starting and the signal being sent. I've checked in a few small time.sleep hacks in the meantime to