[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-23 Thread R. David Murray
R. David Murray added the comment: Oh, and you forgot about your note to yourself to update the argument syntax for the 3.2 commit. -- ___ Python tracker ___ ___

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-23 Thread R. David Murray
R. David Murray added the comment: Assuming that it is OK for this to be in 2.7 beta2 (it smells almost like a feature, but I'm certainly willing to let it pass as a bugfix myself), the 2.7 doc change in the commit contains a typo (it says versionchanged 3.2 instead of versionchanged 2.7). -

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-23 Thread Sean Reifschneider
Sean Reifschneider added the comment: Ported to python3 and committed as 80401. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-23 Thread Sean Reifschneider
Sean Reifschneider added the comment: Committed as 80396. Included a change to let openlog(3) pick the ident instead of using the static string "python". -- resolution: -> accepted status: open -> closed ___ Python tracker

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-21 Thread Eric Smith
Eric Smith added the comment: I have the same reasoning as David, although I was thinking about python vs. pythonw. But it's not a big deal. I think you should check it in as-is, and we can worry about modifying it later, if need be. -- ___ Python

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-21 Thread R. David Murray
R. David Murray added the comment: One argument in favor of letting openlog pick it (assuming it uses argv[0]) is that for a while at least we will have many systems running both python2 and python3, and it might be useful to have that distinction show up in the log if the fallback is used.

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-20 Thread Sean Reifschneider
Sean Reifschneider added the comment: Ok, so I left the argument style in the docs as it was. *** NOTE ***: Sean: Change this for the 3 trunk commit. Setting the "python" string is outside of the argv function because we want to use "python" on any of the many places where the return is done.

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-20 Thread R. David Murray
R. David Murray added the comment: The argument documentation style change was made for py3k. The old convention is still used in the 2.x docs. -- nosy: +r.david.murray ___ Python tracker

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-20 Thread Eric Smith
Eric Smith added the comment: A couple of points: Didn't we decide that instead of using: openlog(ident[, logopt[, facility]]) we'd use: openlog(ident, logopt=None, facility=None) (or whatever the defaults are)? I can't find a reference, but the argument was that it's how Python signatures

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-19 Thread Sean Reifschneider
Sean Reifschneider added the comment: Antoine: I believe I have everything you mentioned addressed with the new patch. That was an awesome review, thank you so much. The only things I didn't do were parts of the last two items you bring up: If PyTuple_New(0) fails, bail out. If syslog_openlo

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Some notes about the patch: - NEWS blurbs generally appear antichronologically, that is newest first :-) - you don't have to mention that "The 3.2 changes mentioned above are included in 2.7" - the part of the PyArg_ParseTupleAndKeywords string after the semi-

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-19 Thread Sean Reifschneider
Changes by Sean Reifschneider : Added file: http://bugs.python.org/file16983/syslog-kwargs2.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-18 Thread Sean Reifschneider
Changes by Sean Reifschneider : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-18 Thread Sean Reifschneider
Changes by Sean Reifschneider : Added file: http://bugs.python.org/file16982/syslog-kwargs.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue8451] syslog.syslog('msg') logs message with ident "python".

2010-04-18 Thread Sean Reifschneider
New submission from Sean Reifschneider : As discussed in this thread: http://mail.python.org/pipermail/python-dev/2010-March/098500.html The syslog module is using the C argv[0] as the program name, not the python sys.argv[0]. So, in most cases this means that unless you explicitly set a ide