[issue8573] Buggy _strerror in asyncore

Changes by Giampaolo Rodola' : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8573] Buggy _strerror in asyncore

Giampaolo Rodola' added the comment: It slipped under my radar as well. Thanks. Fixed in r81294 (trunk), r81298 (2.6), r81299 (3.2) and r81300 (3.1) which also add tests and include NameError in the list of possible exceptions in case os.strerror() is not supported on the current platform (e.g

[issue8573] Buggy _strerror in asyncore

Longpoke added the comment: Yes, it should definately be os.sterror. Dunno how I ended up omitting that, sorry. -- ___ Python tracker ___ ___

[issue8573] Buggy _strerror in asyncore

Changes by Éric Araujo : -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/optio

[issue8573] Buggy _strerror in asyncore

Éric Araujo added the comment: Hopefully fixing yet another lovely browser or roundup forms friggin bug. Sorry. -- assignee: -> giampaolo.rodola nosy: +giampaolo.rodola, josiahcarlson type: crash -> behavior versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___

[issue8573] Buggy _strerror in asyncore

Éric Araujo added the comment: I’ve just checked the diff and the current trunk version of the file, and the change from “os.strerror(err)” to “strerror(err)” seems buggy to me. -- assignee: giampaolo.rodola -> nosy: -giampaolo.rodola, josiahcarlson resolution: fixed -> stage: commi

[issue8573] Buggy _strerror in asyncore

Giampaolo Rodola' added the comment: Yes, I think it's better to remain consistent with the rest of the module which uses %s all around the place, also for backward compatibility in case someone wants to copy asyncore.py shipped with recent python versions and use it in their code using older

[issue8573] Buggy _strerror in asyncore

Éric Araujo added the comment: Don’t want to bikeshed here, but why didn’t you keep the newer “{}” string formatting? Module consistency? -- nosy: +merwok ___ Python tracker ___

[issue8573] Buggy _strerror in asyncore

Giampaolo Rodola' added the comment: Good catch. I modified your patch a little bit including a catch for OverflowError exception and a last attempt to look up into errno.errorcode: def _strerror(err): try: return strerror(err) except (ValueError, OverflowError): if err

[issue8573] Buggy _strerror in asyncore

Changes by R. David Murray : -- nosy: +giampaolo.rodola, josiahcarlson type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-l

[issue8573] Buggy _strerror in asyncore

New submission from Longpoke : This function in asyncore is buggy: def _strerror(err): res = os.strerror(err) if res == 'Unknown error': res = errorcode[err] return res - os.strerror may throw ValueError depending on the os, or return a string saying something like: "Unknow