[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Committed a fix in r82276 (2.7), r82277 (2.6), r82278 (3.2) and r82279 (3.1). Please reopen the issue if you notice that the problem does not go away on the buildbots. -- status: open -> closed ___ Python tracker

[issue8621] uuid.uuid4() generates non-unique values on OSX

Bill Janssen added the comment: Stefan, I tried your suggestion of starting threading. Test still succeeds on my 10.5.8 system when test_uuid is run separately. Ronald, your fix works on my 10.5.8 system. Why not check it in, and let's see if the buildbots turn green again? -- ___

[issue8621] uuid.uuid4() generates non-unique values on OSX

Stefan Krah added the comment: Ronald Oussoren wrote: > Stefan: we already new that, see msg105018. > > This issue was closed as fixed because the uuid module contains a workaround > for this issue (by not using the broken C API on OSX 10.6). Ok, my comment was partly meant to give an explan

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Bill, please test the patch below on a 10.5 system: Index: Lib/uuid.py === --- Lib/uuid.py (revision 82148) +++ Lib/uuid.py (working copy) @@ -416,7 +416,7 @@ import sys if sys.platform

[issue8621] uuid.uuid4() generates non-unique values on OSX

Stefan Krah added the comment: Bill, could you try to add this to the tests and see if they also fail when you run them standalone? Index: Lib/test/test_uuid.py === --- Lib/test/test_uuid.py (revision 82109) +++ Lib/test/tes

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Stefan: we already new that, see msg105018. This issue was closed as fixed because the uuid module contains a workaround for this issue (by not using the broken C API on OSX 10.6). It seems that OSX 10.5.8 and 10.4 is also affected by this issue. I'll test o

[issue8621] uuid.uuid4() generates non-unique values on OSX

Stefan Krah added the comment: It is disputed on http://openradar.appspot.com/radar?id=334401 that this is an OS bug. If I understand correctly, the test program is not guaranteed to work if threads are involved. See also: http://webcache.googleusercontent.com/search?q=cache:hJo0u_Lc8wkJ:www.op

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Odd, unless someone already checked in a fix on the trunk. I currently have a clean test run on the trunk on OSX 10.6.4 (intel). I haven't checked this on my 10.5 VM yet. -- ___ Python tracker

[issue8621] uuid.uuid4() generates non-unique values on OSX

Bill Janssen added the comment: This is on an Intel machine running OS X 10.5.8. I downloaded and built 2.7rc2 from source with "./configure ; make". I then ran the tests with "make test". test_uuid fails with this output: test test_uuid failed -- Traceback (most recent call last): File

[issue8621] uuid.uuid4() generates non-unique values on OSX

Stefan Krah added the comment: Reopening since test failures are reported on python-dev: [...] test_uuid test test_uuid failed -- Traceback (most recent call last): File "/private/tmp/Python-2.7rc2/Lib/test/test_uuid.py", line 472, in testIssue8621 self.assertNotEqual(parent_value, child

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: There are way more interesting regressions in OSX, issue8621 is one example: basicly getgroups(2) does not reflect the results of setgroups(2) with the compiler settings we use. Committed in r80784 (trunk), r80785 (2.6), r80786 (3.2) and r80788 (3.1) --

[issue8621] uuid.uuid4() generates non-unique values on OSX

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8621] uuid.uuid4() generates non-unique values on OSX

yig added the comment: Great work! Very thorough patches. Strange that it's a regression versus 10.5. -- ___ Python tracker ___ ___

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Also added a testcase that should warn if other unix-y platforms start to suffer from the same issue. BTW. issue8621.patch uses a runtime test in the uuid module instead of a configure-check because a binary might be created on 10.5 (without the issue) and

[issue8621] uuid.uuid4() generates non-unique values on OSX

Changes by Ronald Oussoren : Removed file: http://bugs.python.org/file17217/issue8621-doc.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: Because I didn't look closely enough at the source :-( The attached patch disabled the C implementation on OSX 10.6 or later. I've tested that 10.5 is not affected by the issue. -- Added file: http://bugs.python.org/file17218/issue8621.patch ___

[issue8621] uuid.uuid4() generates non-unique values on OSX

yig added the comment: Ahem. Why not use the Python implementation on darwin until its uuid_generate_random() is deemed to be safe? -- ___ Python tracker ___ __

[issue8621] uuid.uuid4() generates non-unique values on OSX

yig added the comment: Why not default to not use the Python implementation on darwin instead of the underlying platform's uuid_generate_random(), until it's proven safe? -- ___ Python tracker

[issue8621] uuid.uuid4() generates non-unique values on OSX

Ronald Oussoren added the comment: As the bug is in the underlying platform the best we can do is to warn about this in the documentation, as in the attached patch. BTW. I've updated the title to be slightly more informative. -- keywords: +patch title: Mac OS X -> uuid.uuid4() genera