[issue8739] Update to smtpd.py to RFC 5321

Roundup Robot added the comment: New changeset 079c1942eedf by R David Murray in branch 'default': #8739: fix omission of DEBUGSTREAM reset in new test in test_smtpd. http://hg.python.org/cpython/rev/079c1942eedf -- ___ Python tracker

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Thanks very much to everyone who contributed to this patch. It was a real team effort :) -- assignee: r.david.murray -> resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Py

[issue8739] Update to smtpd.py to RFC 5321

Roundup Robot added the comment: New changeset ec7456b3f4fe by R David Murray in branch 'default': #8739: upgrade smtpd to RFC 5321 and 1870. http://hg.python.org/cpython/rev/ec7456b3f4fe -- nosy: +python-dev ___ Python tracker

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Removing dependency on issue 11959. Instead I'm going to fix the logging test by adding the necessary updates to its __init__ methods on the smtpd subclasses. Then 11959 can be dealt with independently. -- dependencies: -smtpd cannot be used witho

[issue8739] Update to smtpd.py to RFC 5321

Michele Orrù added the comment: David, can you tag this issue as dependency for issue14261 ? -- ___ Python tracker ___ ___ Python-bugs

[issue8739] Update to smtpd.py to RFC 5321

Michele Orrù added the comment: David: yes, I did. About two weeks ago. Probably I'll take a look to those issues :) -- ___ Python tracker ___ ___

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Note that this patch causes test_logging to fail/hang. I've opened issue 14314 that mentions the hang (the issue is really about the lack of a timeout in logging's smtp handler) and updated issue 11959 about the issues involved in test_logging using smtpd t

[issue8739] Update to smtpd.py to RFC 5321

Changes by R. David Murray : Added file: http://bugs.python.org/file24855/issue8739.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: OK, I've gone through Dan's update (thanks very much for the tests!). I'm uploading a revised patch. The major differences are: I've refactored the parsing. Now it is a three step process: peel off the extra keyword (FROM:, TO:) if there is one, then pull

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: By the way, Alberto, if you haven't already submitted a contributor agreement, could you do so please? We have one from Dan from the sprints. Michele, you aren't marked in the tracker as having submitted an agreement but you've been active long enough I wo

[issue8739] Update to smtpd.py to RFC 5321

Changes by Dan Boswell : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bu

[issue8739] Update to smtpd.py to RFC 5321

Dan Boswell added the comment: I built on Michele's patch during the pycon sprint, addressing some of the concerns rightly raised in previous comment: 1. Turn off the SIZE extension if client uses HELO (though limits are still used internally to limit message size for DoS protection), and rep

[issue8739] Update to smtpd.py to RFC 5321

Michele Orrù added the comment: Patch attached. A few considerations: in case of syntax error, the server responds with " MAIL FROM: [SP ] " according to http://tools.ietf.org/html/rfc5321#section-3.3 (instead of "MAIL FROM:"). Note that this could break something, as far as backwards compa

[issue8739] Update to smtpd.py to RFC 5321

Juhana Jauhiainen added the comment: Since Michele has been already working on this I could help with the cleanup once it's separated as a new issue. David: Thanks for your comments. I wasn't sure if I should make a general solution or not and ended up making this one. -- __

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Juhana: thanks for the patch. I see an issue with it, though. What if the email address is something like john.si...@example.com? My thought is that there are two ways to handle this. Either we do a full RFC address parse in __getaddr and have it return t

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Yes, cleanups would be better as a separate issue. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue8739] Update to smtpd.py to RFC 5321

Michele Orrù added the comment: I'm currently working on this issue. A little cleanup would be appreciated, or it would be better to split that on another issue? For what I saw, tests are in the form FooTest instead of TestFoo, smtpd imports modules used only in __main__, warnings can be hand

[issue8739] Update to smtpd.py to RFC 5321

Juhana Jauhiainen added the comment: The patch I've attached adds minimal support for the SIZE parameter of MAIL command. If the given message size exceeds the servers maximum size the server responds with error 552. -- nosy: +Juhana.Jauhiainen Added file: http://bugs.python.org/file

[issue8739] Update to smtpd.py to RFC 5321

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8739] Update to smtpd.py to RFC 5321

Changes by Geoffrey Spear : -- nosy: +wooble ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue8739] Update to smtpd.py to RFC 5321

Changes by Hynek Schlawack : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue8739] Update to smtpd.py to RFC 5321

Changes by Anthony Kong : -- nosy: +Anthony.Kong ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: OK. Maybe someone else will want to work on it, too. I'll see if I can get it taken care of one way or another during the PyCon sprints. I'm going to mark this as easy, because really other than expanding test coverage I think the only thing that needs don

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: David, I'd be happy to help, but I'm pretty busy for the next month. I read the description of your patch, and it sounds good to me. Anything that moves the project forward is always welcomed. Thanks for your work on this. -- ___

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Gah, that's what I get for trying to do something quick. By changing the name of that variable I introduced a backward incompatibility, since that change was released in 3.2. -- ___ Python tracker

[issue8739] Update to smtpd.py to RFC 5321

Changes by Catalin Iacob : -- nosy: +catalin.iacob ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Alberto, might you still interested in working on this? I thought I'd do a quick update to current trunk and check it in, but in the process of doing that I found some issues. I suspect it has been frustrating for you that nothing happened with this for 3.

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: On Monday, August 16, 2010 12:58:07 pm Barry A. Warsaw wrote: > The one thing that looks weird to me is VRFY. Since it never actually > does verify the user, should we even claim to support the command? Why > not let subclasses claim support if they want to a

[issue8739] Update to smtpd.py to RFC 5321

Barry A. Warsaw added the comment: The one thing that looks weird to me is VRFY. Since it never actually does verify the user, should we even claim to support the command? Why not let subclasses claim support if they want to add it? -- ___ Python

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: On Monday, August 16, 2010 11:42:51 am you wrote: > Re-adapted patch including size_limit change as described in my previous > message is in attachment. Barry and Alberto, could you take a final look > at it before committing? Looks good to me. If the tests p

[issue8739] Update to smtpd.py to RFC 5321

Giampaolo Rodola' added the comment: Re-adapted patch including size_limit change as described in my previous message is in attachment. Barry and Alberto, could you take a final look at it before committing? -- Added file: http://bugs.python.org/file18546/smtpd.patch _

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: On Sunday, August 15, 2010 09:19:27 am Giampaolo Rodola' wrote: > Patch no longer applies cleanly because smtpd.py changed in the meantime. Is someone going to fix that or I am expected to play daily catch-up until this gets merged? > A further comment: > >

[issue8739] Update to smtpd.py to RFC 5321

Giampaolo Rodola' added the comment: Patch no longer applies cleanly because smtpd.py changed in the meantime. A further comment: -def __init__(self, server, conn, addr): +def __init__(self, server, conn, addr, size = 0): -def __init__(self, localaddr, remoteaddr): +def __init_

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: Any more work I need to do on this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: Sorry. This is my first submission to Python, so I'm learning the process as I go. This latest patch is done against today's SVN snapshot. Just to summarize, it does the following: * Updates the main smtpd.py module to make it RFC 5321 compliant: -

[issue8739] Update to smtpd.py to RFC 5321

Richard Jones added the comment: The smtpd module now has a test suite. Please add your unit tests to test_smtpd.py -- nosy: +richard ___ Python tracker ___

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: On Monday, July 05, 2010 10:41:28 am you wrote: > Yes, the fact that there are no unit tests for the new functionality. Sorry to take so long to reply. I have attached the latest version of the patch which does everything in rev. 2 of the patch, patches the

[issue8739] Update to smtpd.py to RFC 5321

R. David Murray added the comment: Yes, the fact that there are no unit tests for the new functionality. As far as I can see the existing smtpd tests (which don't appear to be too extensive...but this module probably dates from before we had a firm unit test policy), are in test_smtplib. --

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: What is the status of this patch? Is there anything else I need to do? Any remaining concerns that would stop this patch from being merged? -- ___ Python tracker

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: On Thursday 20 May 2010 07:46:43 am you wrote: > If you don't specify the size, the response of EHLP won't list > SIZE as one of the extensions. But, if a size is specified, then it > will show it on EHLP. Sorry, the EHLP above should be EHLO. Fat fingers, l

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: I have attached a version 2 of the patch. This patch includes everything in the first version, and adds the following: - Support for help arguments (HELP MAIL, for example) - Support for setting the maximum message size from the command line This last fea

[issue8739] Update to smtpd.py to RFC 5321

Giampaolo Rodola' added the comment: > It is not, but just seemed like good practice to advertise the limit in > EHLO and enforce it. My patch doesn't do a good job of enforcing it > since it enforces it before doing process_message. The problems with > 2518 and 1745035 are still there. Th

[issue8739] Update to smtpd.py to RFC 5321

Alberto Trevino added the comment: > Giampaolo Rodola' added the comment: > > Some comments: > > Is RFC 5321 completely implemented? Otherwise I would turn this in "as > defined in RFC 821 and part of RFC 5321". RFC 5321 obsoletes RFCs 821, 974, 1869 and 2821. I don't think we should make

[issue8739] Update to smtpd.py to RFC 5321

Giampaolo Rodola' added the comment: Some comments: -# This file implements the minimal SMTP protocol as defined in RFC 821. It +# This file implements the minimal SMTP protocol as defined in RFC 5321. It Is RFC 5321 completely implemented? Otherwise I would turn this in "as defined in RFC

[issue8739] Update to smtpd.py to RFC 5321

Changes by Barry A. Warsaw : -- versions: -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue8739] Update to smtpd.py to RFC 5321

Changes by R. David Murray : -- nosy: +r.david.murray stage: -> unit test needed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue8739] Update to smtpd.py to RFC 5321

New submission from Alberto Trevino : This patch updates smtpd.py to be more RFC 5321 compliant. It contains: - EHLO support - Implement DATA size limit (32 MiB by default) - 8-bit mime extension plumbing (doesn't do anything, but accepts and records command) - Basic VRFY support - Basi