Nick Coghlan added the comment:
I agree it makes sense to merge this and #9305, and since the latter has seen
more recent activity, I'll do the merge in that direction.
--
resolution: -> duplicate
stage: patch review ->
status: open -> closed
superseder: -> Don't use east/west of
Alexander Belopolsky added the comment:
Isn't this a duplicate of #9305?
--
assignee: belopolsky -
versions: +Python 3.5 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
___
Ben Finney added the comment:
Attached is a patch which is more comprehensive (covering the additional
locations pointed out to me by ncoghlan), and also consolidating the details
into the library documentation so they're not verbosely repeated in so many
places.
I agree with Nick's position
Ben Finney added the comment:
Here is an updated patch. I examined the implementation in the code for UTC
offset and DST handling, and updated the code comments, the docstrings, and the
library documentation.
--
keywords: +patch
nosy: +bignose, ncoghlan
Added file:
Nick Coghlan added the comment:
It turns out these particular docstrings are duplicated all over the place, as
time and datetime both wrap the tzinfo method, and there is both the tzinfo ABC
as well as the concrete fixed offset subclasses, and this happens in both C and
Python.
Ben's patch
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Benjamin,
Is it too late to do anything about this. Apparently Sean committed wrong
patch and as a result 2.7 is about to be released with an error in
tzinfo.fromutc docstring. This method is confusing enough without
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Reverted r81681 and r81682 in r82466 and r82467.
It looks like docstring changes intended for utcoffset() landed in a docstring
for fromutc(). Given that we are very close to 2.7 release, I am not
attempting to improve
Sean Reifschneider j...@tummy.com added the comment:
Committed to 2.7 in 81681 and 3.x in 81682.
--
keywords: +needs review -patch
resolution: - accepted
stage: - committed/rejected
status: open - closed
type: - feature request
___
Python tracker
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
In this case, the docs.python.org link you point to seems
to be correct, saying that it returns a timedelta.
This issue is specifically about ReST documentation, not the docstring. I
explained in the opening comment
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
stage: committed/rejected - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
resolution: accepted -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Sean,
It looks like you committed your first patch rather than your second. Is that
what you intended?
Also in msg106734, you agree to change West to west, but committed West.
Note that west is correct. In English,
Sean Reifschneider j...@tummy.com added the comment:
In this case, the docs.python.org link you point to seems to be correct, saying
that it returns a timedelta. It is the docstring that says it's minutes east
of UTC.
I've attached a patch which changes this wording to:
timedelta() showing
Éric Araujo mer...@netwok.org added the comment:
I’m not sure about the “with negative” wording.
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
___
Sean Reifschneider j...@tummy.com added the comment:
Alternately, here is a patch that just takes the docs.python.org description.
--
Added file: http://bugs.python.org/file17496/python-utcoffsetdoc2.patch
___
Python tracker rep...@bugs.python.org
Sean Reifschneider j...@tummy.com added the comment:
Then how about:
timedelta() showing offset from UTC, negative values indicating West of UTC
?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
Éric Araujo mer...@netwok.org added the comment:
timedelta() showing offset from UTC, negative values indicating West of UTC
+1 for the last one.
Micro nit: I would not put parentheses when referring to the type (we
talk about “a list”, not “a list()”).
Micro nit: Some languages use case to
Sean Reifschneider j...@tummy.com added the comment:
I'm fine without ().
I thought the direction was generally initial-capped, but I may be wrong there.
Let's go with west.
--
___
Python tracker rep...@bugs.python.org
New submission from Alexander Belopolsky belopol...@users.sourceforge.net:
From
http://docs.python.org/dev/py3k/library/datetime.html#datetime.tzinfo.utcoffset:
tzinfo.utcoffset(self, dt)
Return offset of local time from UTC, in minutes east of UTC.
This suggests that the return value
19 matches
Mail list logo
