Adrian von Bidder avbid...@fortytwo.ch added the comment:
On Thursday 02 December 2010 22.51:51 you wrote:
Committed to py3k in r86936 with minor fixups.
thanks, great! (Wheee! my first patch to Python ;-)
cheers
-- vbi
--
___
Python tracker
R. David Murray rdmur...@bitdance.com added the comment:
Committed to py3k in r86936 with minor fixups.
--
resolution: - accepted
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Thanks for the patch, which looks good to me, except for the test: “eq” will
raise a NameError, since this does not exist. Other test methods bind eq to
self.assertEqual to save typing, which is not really needed in your case: Just
use
Adrian von Bidder avbid...@fortytwo.ch added the comment:
Thanks for the positive feedback. I'll try to do the diff against top of tree
and the unit test soon-ish.
Use case:
* In my specific case, I'm writing a sort of cross between mailing list and
blog system and I'd like to use a static
Adrian von Bidder avbid...@fortytwo.ch added the comment:
I'm sure several of you have worked with the Python source code before and know
by heart how to run the testsuite. In other words: I admit that I've only
written the code and have not tried it.
Given how trivial the patch is, I have
New submission from Adrian von Bidder avbid...@fortytwo.ch:
Using the hostname for the domain part of a Message-Id is probably the right
thing usually but users may want to override this.
Please consider this rather trivial patch:
=
--- utils.py.orig 2010-06-13 16:59:30.533861099
Éric Araujo mer...@netwok.org added the comment:
Seems straightforward. Any reason not to allow it David?
Adrian, I edited the versions: new features go into 3.2 only. Please make sure
your patch applies to this version (branch named py3k). Can you also write unit
tests for this new
Shashwat Anand anand.shash...@gmail.com added the comment:
Adrian, Could you generate the diffs from the
top level of the checkout and attach it here?
--
nosy: +l0nwlf
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8989
R. David Murray rdmur...@bitdance.com added the comment:
This does seem like a reasonable (and backward compatible) addition to the API.
I'm only +0 on adding it, though, without at least one specific use case. I'd
want to mention that use case in the docs as an example, and stress that
Changes by R. David Murray rdmur...@bitdance.com:
--
assignee: - r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8989
___
___
10 matches
Mail list logo
