[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-06-30 Thread Serhiy Storchaka
Serhiy Storchaka storch...@gmail.com added the comment: Then the tests may still be added to test_zipfile? Yes, they may. Here is a patch with adapted for 3.3 tests only. -- Added file: http://bugs.python.org/file26216/zipfile_appendmode_comment_tests.patch

[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-06-30 Thread Roundup Robot
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset e13c9f99fbae by Antoine Pitrou in branch '3.2': Issue #9239: add tests for modifying zipfile comments in append mode. http://hg.python.org/cpython/rev/e13c9f99fbae New changeset b299b4279e13 by Antoine Pitrou in

[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-06-30 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Thanks, committed! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9239

[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-06-29 Thread Serhiy Storchaka
Serhiy Storchaka storch...@gmail.com added the comment: Anyone may close the issue as out of date? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9239 ___

[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-06-29 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: The bug is no longer there. Probably it is fixed in issue14399. Then the tests may still be added to test_zipfile? -- assignee: alanmcintyre - nosy: +pitrou priority: high - normal ___ Python

[issue9239] zipfile: truncating comment can corrupt the zipfile

2012-04-28 Thread Serhiy Storchaka
Serhiy Storchaka storch...@gmail.com added the comment: The bug is no longer there. Probably it is fixed in issue14399. -- nosy: +storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9239

[issue9239] zipfile: truncating comment can corrupt the zipfile

2011-10-23 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- stage: - patch review type: performance - behavior versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9239 ___

[issue9239] zipfile: truncating comment can corrupt the zipfile

2010-12-25 Thread Georg Brandl
Changes by Georg Brandl ge...@python.org: -- assignee: aimacintyre - alanmcintyre nosy: +alanmcintyre -aimacintyre ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9239 ___

[issue9239] zipfile: truncating comment can corrupt the zipfile

2010-08-02 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: Patch looks good to me. Alan, can you comment? -- assignee: - aimacintyre nosy: +aimacintyre, georg.brandl priority: normal - high ___ Python tracker rep...@bugs.python.org

[issue9239] zipfile: truncating comment can corrupt the zipfile

2010-07-12 Thread Ryan Kelly
New submission from Ryan Kelly r...@rfk.id.au: If you open a ZipFile in append mode and modify the comment to be shorter than what was originally there, the file will become corrupted. Truncated data from the original comment is left dangling at the end of the zipfile. A much more trivial