Doug Hellmann doug.hellm...@gmail.com added the comment:
Committed to py3k as r83016, release31-maint as r83017, and release27-maint as
r83018.
Thanks for your help, everyone.
--
resolution: - fixed
status: open - closed
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
A quick look suggests that the patches are ok, thank you.
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9296
Doug Hellmann doug.hellm...@gmail.com added the comment:
Ray, thanks for the patches. Antoine, I appreciate the review. I'll try to
get these checked in to svn in the next day or two.
I see that this ticket is tagged as related to versions 2.7, 3.1, and 3.2.
Should the changes be applied
Antoine Pitrou pit...@free.fr added the comment:
Should the changes be applied to any branches other than trunk and py3k?
release31-maint.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9296
Éric Araujo mer...@netwok.org added the comment:
I believe there are no commits on trunk. Affected branches are py3k and
release{27,31}-maint IIUC.
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9296
R. David Murray rdmur...@bitdance.com added the comment:
Adding some people to nosy: Bob, who wrote the code, and Antoine and Benjamin
who were involved in the update and probably have an opinion on the correct fix.
(c.f.: Issue4136)
--
nosy: +benjamin.peterson, bob.ippolito, pitrou,
Antoine Pitrou pit...@free.fr added the comment:
TypeError sounds right indeed. Patches welcome (even better with tests).
--
stage: unit test needed - needs patch
versions: +Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
Doug Hellmann doug.hellm...@gmail.com added the comment:
Bob fixed this in simplejson under ticket 82
(http://code.google.com/p/simplejson/issues/detail?id=82).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9296
Ray.Allen ysj@gmail.com added the comment:
I worked out two patches, one for trunk and one for py3k, both with tests, hope
someone could do a reviewing.
--
keywords: +patch
nosy: +ysj.ray
Added file: http://bugs.python.org/file18078/json_trunk.diff
Changes by Ray.Allen ysj@gmail.com:
Added file: http://bugs.python.org/file18079/json_py3k.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9296
___
New submission from Doug Hellmann doug.hellm...@gmail.com:
Under Python 2.6 the json encoder raised a TypeError when it encountered
dictionary keys that were not strings. Under 2.7, that exception has changed
to a ValueError, but the documentation still says it raises TypeError. I'm not
Doug Hellmann doug.hellm...@gmail.com added the comment:
The attached file json_skipkeys.py illustrates the problem.
--
Added file: http://bugs.python.org/file18053/json_skipkeys.py
___
Python tracker rep...@bugs.python.org
Doug Hellmann doug.hellm...@gmail.com added the comment:
Looking into the code, I see in _json.c that a ValueError is raised by
encoder_listencode_dict() on line 2150, but in the pure-Python implementation
in json/encoder.py a TypeError is raised by _make_iterencode() on line 376.
--
13 matches
Mail list logo
