[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: On Sat, Oct 16, 2010 at 1:34 PM, R. David Murray wrote: .. > I yhink you need to add an svnignore property to that directory for > __pycache__. r85576 (I hope I got it right.) -- ___ Python tracker

[issue9308] Remove redundant coding cookies from 3.x stdlib

R. David Murray added the comment: I yhink you need to add an svnignore property to that directory for __pycache__. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: Committed in r85537. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mai

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: I am attaching an updated patch, issue9308b.diff. Compared to the "a" patch, I added test/encoded_modules to the makefile so that it gets installed and removed cookies from some more test and Tools files. -- Added file: http://bugs.python.org/f

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: Is anyone interested in reviewing this patch before it is committed? Since there are no user-visible changes and the only non-trivial change simply adds new tests, I think this can go in. Any refinements can be done later. -- components: +Test

[issue9308] Remove redundant coding cookies from 3.x stdlib

Éric Araujo added the comment: I think this new test is a good idea. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue9308] Remove redundant coding cookies from 3.x stdlib

Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file18077/issue9308a.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: > Could you add comments in encoded_modules/__init__.py? Please see updated issue9308a.diff. -- Added file: http://bugs.python.org/file18093/issue9308a.diff ___ Python tracker

[issue9308] Remove redundant coding cookies from 3.x stdlib

Éric Araujo added the comment: Could you add comments in encoded_modules/__init__.py? I don’t understand it, so I can’t make a useful comment. -- ___ Python tracker ___

[issue9308] Remove redundant coding cookies from 3.x stdlib

Changes by Alexander Belopolsky : -- keywords: +needs review stage: commit review -> patch review ___ Python tracker ___ ___ Python-bug

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: I am attaching a new patch, issue9308a.diff which fixes test_imp by introducing a new package, test.encoded_modules which currently contains a module encoded with iso-8859-1 and another with a somewhat more interesting encoding, koi8-r. I think it woul

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: I wonder whether 3.x shlex working with unicode files is just incidental to 3.x string model and is not really correct. I think issue1170 is a better place to have this discussion. I'll add a comment there. -- nosy: -Alexander.Belopolsky ___

[issue9308] Remove redundant coding cookies from 3.x stdlib

Éric Araujo added the comment: I shouldn’t edit bugs when tired, sorry for the noise. hg log tells me that those extra characters have been added in r32284 (2003) following bug #722686 by Gustavo Niemeyer following a discussion on “the mailing list”. Adjusting nosy. -- nosy: +niemeye

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: > > Changes by Éric Araujo : > -- > nosy: +esr I don't think posix mode was added by ESR, but I cannot check ATM. -- nosy: +Alexander.Belopolsky ___ Python tracker _

[issue9308] Remove redundant coding cookies from 3.x stdlib

Changes by Éric Araujo : -- nosy: +esr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/ma

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: Tracker eating python prompt prefixed lines is truly annoying. Here are the missing lines: >>> len(shlex(posix=True).wordchars) - len(shlex().wordchars) 62 >>> len([chr(i) for i in range(128, 256) if chr(i).isalnum()]) 71 -- __

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: On Mon, Jul 19, 2010 at 4:33 PM, Éric Araujo wrote: .. > The shlex fix was reverted IIRC because Mark was unsure of the fix, since our > diff tools > try to be too clever and decode files, not showing us the bytes differences. Well, it is not clear what

[issue9308] Remove redundant coding cookies from 3.x stdlib

Éric Araujo added the comment: This is not easy after all, kudos for taking care of that. The shlex fix was reverted IIRC because Mark was unsure of the fix, since our diff tools try to be too clever and decode files, not showing us the bytes differences. I don’t trust my editor either, nor t

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: It turns out that test_imp tests that pydoc.py is in iso-8859-1. This is not right. The test should use a dedicated file under Lib/test for that. -- ___ Python tracker ___

[issue9308] Remove redundant coding cookies from 3.x stdlib

Alexander Belopolsky added the comment: In the attached patch, I've removed encoding cookies in all files listed in the message above except >> Lib/test/bad_coding.py:# -*- coding: uft-8 -*- >> Lib/test/badsyntax_3131.py:# -*- coding: utf-8 -*- >> Lib/shlex.py:# -*- coding: iso-8859-1 -*- The

[issue9308] Remove redundant coding cookies from 3.x stdlib

Changes by Éric Araujo : -- keywords: +easy nosy: +merwok resolution: -> accepted stage: -> needs patch versions: +Python 3.2 ___ Python tracker ___

[issue9308] Remove redundant coding cookies from 3.x stdlib

New submission from Alexander Belopolsky : On Mon, Jul 19, 2010 at 2:45 AM, Guido van Rossum wrote: > Sounds like a good idea to try to remove redundant cookies *and* to > remove most occasional use of non-ASCII characters outside comments > (except for unittests specifically trying to test Unic