[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Serhiy Storchaka : -- resolution: accepted -> fixed stage: commit review -> committed/rejected ___ Python tracker ___ ___ Py

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Roundup Robot added the comment: New changeset 0a45896a7cde by Serhiy Storchaka in branch 'default': Issue #9369: The types of `char*` arguments of PyObject_CallFunction() and http://hg.python.org/cpython/rev/0a45896a7cde -- nosy: +python-dev ___ Pyth

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Serhiy Storchaka added the comment: Jörg, Lars, can you please submit a contributor form? http://python.org/psf/contrib/contrib-form/ http://python.org/psf/contrib/ -- ___ Python tracker ___

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Antoine Pitrou added the comment: Looks good to me. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Lars Buitinck added the comment: I'm sorry, I really don't understand this refcounts.dat file and I'm not going to hack it further. Does the patch as it currently stands solve the issue with CallMethod and CallFunction, or not? (It has the changes to the docs.) --

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Serhiy Storchaka added the comment: > PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for > reference counting to work? Then refcounts.dat wrong. > PyDict_GetItemString already has const, just not in refcounts.dat. Fixed. There are a lot of char* arguments in refcounts

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Lars Buitinck added the comment: Oops, forgot to save changes to Doc/c-api/object.rst. PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for reference counting to work? PyDict_GetItemString already has const, just not in refcounts.dat. Fixed. -- Added file: http:

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Serhiy Storchaka added the comment: Docs update needed. Perhaps some other functions which accepts char* (i.e. PyObject_CallMethodObjArgs or PyDict_GetItemString) should be fixed. -- nosy: +serhiy.storchaka ___ Python tracker

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Lars Buitinck added the comment: Redid the patch. -- Added file: http://bugs.python.org/file28653/constness.patch ___ Python tracker ___ __

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Christian Heimes added the comment: Let's try this again for 3.4 -- nosy: +christian.heimes versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ __

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Lars Buitinck added the comment: Any reason why this issue is still open? I just got a lot of compiler warnings when building Numpy, so this isn't just relevant to C++ programmers. (Btw., I did RTFM: the issue's Resolution is "accepted" but that option is not documented.) -- nosy: +la

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Andreas Stührk : -- nosy: +Trundle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Amaury Forgeot d'Arc added the comment: Thanks for the confirmation! -- resolution: -> accepted ___ Python tracker ___ ___ Python-bug

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Martin v. Löwis added the comment: AFAICT, they are compatible, so +1. The typical proposition of an incompatible change either proposes to use const char* as the return type, or has multi-level pointers that are proposed to be constified. -- ___

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Amaury Forgeot d'Arc added the comment: Martin, what do you think about this kind of changes? Are there possible regressions or incompatibilities? -- nosy: +amaury.forgeotdarc, loewis ___ Python tracker __

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Éric Araujo : -- nosy: +aronacher stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Changes by Jörg Müller : Removed file: http://bugs.python.org/file18175/patch.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

Jörg Müller added the comment: I've merged the patch with the changes from Armin in issue9368. -- type: feature request -> behavior Added file: http://bugs.python.org/file18176/patch.diff ___ Python tracker ___

[issue9369] const char* for PyObject_CallMethod and PyObject_CallFunction

New submission from Jörg Müller : Patch attached -- components: Interpreter Core files: patch.diff keywords: patch messages: 111437 nosy: neXyon priority: normal severity: normal status: open title: const char* for PyObject_CallMethod and PyObject_CallFunction type: feature request versi