[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-22 Thread Ezio Melotti
Ezio Melotti added the comment: Committed in r86690 on py3k, blocked in r86691 and r88692 on 3.1/2.7. -- ___ Python tracker ___ ___ Py

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-21 Thread Ezio Melotti
Ezio Melotti added the comment: The attached patch (issue9424-2.diff) addresses the point 2) of msg113147. -- Added file: http://bugs.python.org/file19755/issue9424-2.diff ___ Python tracker ___

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-21 Thread Ezio Melotti
Ezio Melotti added the comment: I merged the patch on 3.1 in r86629 and on 2.7 in r86637. I would like to propose the following deprecation schedules for the deprecated fail* and assert* methods: * for the fail* methods: add a DeprecationWarning in 3.1 (done in r74096); remove them in 3.3

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-20 Thread Ezio Melotti
Ezio Melotti added the comment: Committed in r86596. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-20 Thread Ezio Melotti
Ezio Melotti added the comment: I uploaded the patch on http://codereview.appspot.com/3232042 too. -- ___ Python tracker ___ ___ Pytho

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-11-20 Thread Ezio Melotti
Ezio Melotti added the comment: The attached patch addresses the point 1) of msg113147. -- keywords: +patch Added file: http://bugs.python.org/file19677/issue9424.diff ___ Python tracker ___

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-09-07 Thread Éric Araujo
Éric Araujo added the comment: See also #5846 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-21 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-12 Thread Michael Foord
Michael Foord added the comment: Well, there is *some* value in stylistic consistency. If it didn't matter at all then Guido wouldn't have instigated the deprecation of assertEquals and assert_ and standardised on assertEqual (which he did during the sprints at PyCon 2009). Either we stick wi

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: Please don't pursue this further. It does not matter at all whether developers use assertEqual or assertEquals. That is no more than a stylistic preference. I do not want a commit hook, or for developer patches to be edited, or for there to be as assert

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-11 Thread Ezio Melotti
Ezio Melotti added the comment: It's not really a waste of time, since it's just a find and replace and I already have a patch ready. I also believe that there are valid reasons to do it. When I started learning about unittest, I clearly remember asking myself if I should have used "assertEq

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: What a tremendous waste of time and inane exercise. AFAICT, this is a zero value add. Also, we try to avoid these sort of search-and-replace exercises because 1) they are not part of holistic refactoring (Guido's term for making changes while you're worki

[issue9424] Disable unittest.TestCase.assertEquals and assert_ during a regrtest run

2010-08-11 Thread Michael Foord
Changes by Michael Foord : -- title: deprecate unittest.TestCase.assertEquals -> Disable unittest.TestCase.assertEquals and assert_ during a regrtest run ___ Python tracker ___ _