[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: It turns out that build steps have an alwaysRun flag, which I have now enabled for the 'make clean' step. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: > I guess, you missed what we are trying to convey. No, I fully understand what happened. STILL, a) I don't think this is a bug in the buildbot configuration, and b) even if it was, I don't really have the time to investigate that in the coming weeks. Howev

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Florent Xicluna
Florent Xicluna added the comment: I agree we should run the "clean" step as a finally step, even if "compile error" occurs. It is not required in case of "svn exception", I guess. Btw, the exact command is "make distclean" ("make clean" target does not remove "Modules/Setup"). -- _

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Mon, Aug 09, 2010 at 08:57:31PM +, Martin v. Löwis wrote: > I still fail to see the bug - it's by design that later build steps are > not executed if earlier build steps failed. It would be possible to let > the slaves start over with an entirely new che

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: Am 09.08.2010 22:43, schrieb Antoine Pitrou: > > Antoine Pitrou added the comment: > >> I think "cannot be copied" is an exaggeration > > It seems that the purpose is to allow local modifications to > Modules/Setup. Otherwise, I don't know why the Makefile

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I think "cannot be copied" is an exaggeration It seems that the purpose is to allow local modifications to Modules/Setup. Otherwise, I don't know why the Makefile would print an elaborate message when the file exists. If this possibility is never used then,

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: I think "cannot be copied" is an exaggeration. Of course it can be copied - it's just that the Makefile skips doing so. What's the specific problem that this causes? Not sure why this had high priority - if anybody wants to fix it, please go ahead. ---

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +loewis priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Florent Xicluna
New submission from Florent Xicluna : When the buildbot fails to compile, the "clean" step is not run. http://www.python.org/dev/buildbot/builders/i386%20Ubuntu%203.x/builds/1838/ This is a problem for issue #9545 where the Modules/Setup.dist cannot be copied to Modules/Setup on next run (file