[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Steven Bethard added the comment: Fixed with a variant of Denver's last patch in r86080 for 3.X and r86083 for 2.7. -- assignee: -> bethard resolution: -> fixed status: open -> closed ___ Python tracker

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Antoine Pitrou added the comment: As noted in issue10235, this is responsible for buildbot failures: http://www.python.org/dev/buildbot/all/builders/PPC%20Leopard%203.x/builds/685/steps/test/logs/stdio -- nosy: +janssen, pitrou ___ Python tracker

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

R. David Murray added the comment: I don't think it is worthwhile to jump through hoops to avoid calling the special methods. Your patch also creates an unnecessary dependency on the internal implementation of EnvironmentVarGuard (ie: the fact that currently __enter__ happens to return self.

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Denver Coneybeare added the comment: Thanks for the input, r.david.murray. I've updated my patch and attached it to take into consideration your comments: test_argparse.py.COLUMNS.update2.patch. The updated patch uses EnviormentVarGuard as suggested, except that it slightly tweaks Enviormen

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

R. David Murray added the comment: Your code is fine (though to my tastes a bit verbose...if it were me I'd just put the code in the setUp and tearDown methods and hardcode 'COLUMNS' (it isn't like the name COLUMNS is going to change)...but that's just personal style). The EnviormentVarGuard

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Denver Coneybeare added the comment: That is a very good point, bethard, that setting os.environ["COLUMNS"] in my suggested patch (test_argparse.py.COLUMNS.patch) is global and should be test-local. I've attached an updated patch (test_argparse.py.COLUMNS.update1.patch) which uses setUp() an

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Eric Smith added the comment: I agree with Steven: for the current tests we should specify (and restore) 80 columns. We might want to add additional tests at different column widths. -- ___ Python tracker

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Éric Araujo : -- nosy: +merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

R. David Murray added the comment: There's a handy utility for this in test.support: EnvironmentVarGuard. -- nosy: +r.david.murray ___ Python tracker ___

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Steven Bethard added the comment: The best solution would be to make sure that a few different column widths are tested. However, in the meantime, the tests do assume 80 columns, so I think it's correct to specify that using os.environ as suggested. One problem with the proposed patch is that

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Brian Curtin added the comment: Shouldn't the tests calculate line wrapping based on what is set, rather than brute forcing it to be 80? -- nosy: +brian.curtin stage: -> unit test needed versions: +Python 3.2 -Python 3.3 ___ Python tracker

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : Added file: http://bugs.python.org/file18465/test_argparse.py.COLUMNS.patch ___ Python tracker ___ ___ Python-bu

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : Removed file: http://bugs.python.org/file18462/test_argparse.py.COLUMNS.patch ___ Python tracker ___ ___ Python-

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

New submission from Denver Coneybeare : If the COLUMNS environment variable is set to a value other than 80 then test_argparse.py yields 80 failures. The value of the COLUMNS environment variable affects line wrapping of the help output and the test cases assume line wraps at 80 columns. So