[issue9784] _msi.c warnings under 64-bit Windows

Change by Steve Dower : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue9784] _msi.c warnings under 64-bit Windows

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue9784] _msi.c warnings under 64-bit Windows

Steve Dower added the comment: We'd need a contributor agreement from Jon anyway, so unless he rejoins this thread and is willing to sign that, there's little point looking at the patch. -- ___ Python tracker _

[issue9784] _msi.c warnings under 64-bit Windows

Changes by Mark Lawrence : -- components: +Windows nosy: +steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___ Python-bugs-lis

[issue9784] _msi.c warnings under 64-bit Windows

Mark Lawrence added the comment: Could somebody review the patch please as it's well over my head. -- nosy: +BreamoreBoy ___ Python tracker ___ ___

[issue9784] _msi.c warnings under 64-bit Windows

Jon Anglin added the comment: I have uploaded another patch that replaces CRT API calls with Win32 API calls. It compiles cleanly under 32 and 64 bit Windows. Is there a unit test for msilib? I was not able to find one, thus the patch is not fully tested. -- Added file: http://bugs.p

[issue9784] _msi.c warnings under 64-bit Windows

Jon Anglin added the comment: > I have the long-term plan to eliminate all CRT usage from Python > on Windows. In this case, there is a straight-forward opportunity > to do so. Oh, OK. If that is the plan then I am on board. I will re-code the patch using the Win32 API directly. >> It may int

[issue9784] _msi.c warnings under 64-bit Windows

Martin v. Löwis added the comment: > Martin Lowis do you mean API when you type SDK? When I said "SDK examples", then I really meant "examples as published in the SDK", not "examples as published in the API" (and the SDK documentation, in turn, is published on msdn). But yes, the SDK examples u

[issue9784] _msi.c warnings under 64-bit Windows

Jon Anglin added the comment: Martin Lowis do you mean API when you type SDK? If I understand what you are saying, you would rather use the Win32 API instead of the CRT API? It may interest you to know that _open calls CreateFile internally, _read calls ReadFile, _write calls WriteFile, _l

[issue9784] _msi.c warnings under 64-bit Windows

Martin v. Löwis added the comment: See, for example, the link you gave in msg115750. It has this sample code in it (listed in the "Examples" section): FNFCIREAD(fnFileRead) { DWORD dwBytesRead = 0; UNREFERENCED_PARAMETER(pv); if( ReadFile((HANDLE)hf, memory, cb, &dwBytesRead, NUL

[issue9784] _msi.c warnings under 64-bit Windows

Amaury Forgeot d'Arc added the comment: Which "SDK Example" are you referring to? I could not find any example. -- ___ Python tracker ___

[issue9784] _msi.c warnings under 64-bit Windows

Martin v. Löwis added the comment: -1 for the patch. I still maintain that it is better to follow the current SDK. -- ___ Python tracker ___ _

[issue9784] _msi.c warnings under 64-bit Windows

Changes by Ned Deily : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue9784] _msi.c warnings under 64-bit Windows

Jon Anglin added the comment: issue9784.diff contains a patch that compiles clean on 32 and 64 bit Windows. This patch is exactly what Amaury Forgeot d'Arc recommended in msg115750. -- keywords: +patch Added file: http://bugs.python.org/file18989/issue9784.diff ___

[issue9784] _msi.c warnings under 64-bit Windows

Changes by Jon Anglin : -- nosy: +janglin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue9784] _msi.c warnings under 64-bit Windows

Martin v. Löwis added the comment: It's probably best to rewrite these functions in the way the SDK Example section works (i.e. CreateFile/ReadFile) instead of _open/_read (*). As Amaury says, the warnings are harmless: the file numbers will always be in range, as _open created them that way

[issue9784] _msi.c warnings under 64-bit Windows

Amaury Forgeot d'Arc added the comment: FNFCIREAD &co are macros to help the definition of callback functions: http://msdn.microsoft.com/en-us/library/ff797940.aspx "hf" is defined as INT_PTR, but the value it receives is the result of FNFCIOPEN(), which fits in int. It is safe to cast "hf" to

[issue9784] _msi.c warnings under 64-bit Windows

New submission from Antoine Pitrou : I'm posting this in case it is a sign of a problem. Apparently some variable named "hf" is an INT_PTR used as an int (according to Visual Studio), but "hf" doesn't seem to be defined or declared in _msi.c at all. 12>..\PC\_msi.c(66) : warning C4244: 'functi