[issue9808] Implement os.getlogin on Windows

Changes by Jon Anglin : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue9808] Implement os.getlogin on Windows

Brian Curtin added the comment: Committed in r84983. Thanks! -- components: +Extension Modules -Library (Lib) resolution: accepted -> fixed stage: patch review -> committed/rejected ___ Python tracker _

[issue9808] Implement os.getlogin on Windows

Amaury Forgeot d'Arc added the comment: The patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9808] Implement os.getlogin on Windows

Jon Anglin added the comment: The _countof(_x_) macro expands to something like this: sizeof(_x_)/sizeof(_x_[0]) This was an attempt by Microsoft to mitigate some buffer overrun issues. I have gotten in the habit of using it as it is less verbose. I have uploaded a new issue9808.diff f

[issue9808] Implement os.getlogin on Windows

Amaury Forgeot d'Arc added the comment: It's the first time I see the _countof() macro. There is no other usage of it in python codebase. Could you change it for something more easy for non-Windows readers? -- nosy: +amaury.forgeotdarc ___ Python t

[issue9808] Implement os.getlogin on Windows

Changes by Brian Curtin : -- resolution: -> accepted ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue9808] Implement os.getlogin on Windows

Jon Anglin added the comment: I went ahead and moved the test skip decorator to the class level as suggested by Brian Curtin, see issue9808-new.diff. -- Added file: http://bugs.python.org/file18886/issue9808-new.diff ___ Python tracker

[issue9808] Implement os.getlogin on Windows

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue9808] Implement os.getlogin on Windows

Tim Golden added the comment: +1 on the idea in general; I'm away at the moment and not in a position to review the patch. Hopefully Brian can review/commit -- ___ Python tracker ___

[issue9808] Implement os.getlogin on Windows

Jon Anglin added the comment: Here is an updated patch with the updated test. This test does not use either the LOGNAME or USERNAME environment variables. -- Added file: http://bugs.python.org/file18814/issue9808.diff ___ Python tracker

[issue9808] Implement os.getlogin on Windows

Jon Anglin added the comment: I can't answer that for the 'LOGNAME' environment variable on non-Windows systems, I was just keying off of what the docs claimed. As for Windows, I just came across this article http://support.microsoft.com/kb/273633 that shows we can not rely on this in the tes

[issue9808] Implement os.getlogin on Windows

Brian Curtin added the comment: After a quick glance the patch looks alright, just cleaned a few things up in issue9808.diff (moved the #include up with others, removed 'is not None' from tests). The test skip decorator could also be moved to the LoginTests class level. Is there any reason t

[issue9808] Implement os.getlogin on Windows

Changes by R. David Murray : -- nosy: +brian.curtin, tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9808] Implement os.getlogin on Windows

New submission from Jon Anglin : This is a feature request to implement the os.getlogin function on Windows systems. This may not be a widely used function, but implementing on Windows will bring Python on Windows one step closer to Python on Unix (like) systems. The os_getlogin.diff file co