[issue9824] SimpleCookie should escape commas and semi-colons

2010-12-28 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: Looks good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9824 ___ ___ Python-bugs-list

[issue9824] SimpleCookie should escape commas and semi-colons

2010-12-28 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Committed to py3k in r87550. Since the only application that would trip up would be one not using SimpleCookie to read SimpleCookie generated cookies *and* that doesn't implement unescaping (in which case it wasn't really handling

[issue9824] SimpleCookie should escape commas and semi-colons

2010-12-16 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Here's a patch against py3k with test. If I'm understanding the issue correctly, this looks like a pretty safe change. -- nosy: +r.david.murray stage: - patch review Added file:

[issue9824] SimpleCookie should escape commas and semi-colons

2010-09-11 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: I will have a look at this, it looks like it could at least use a few tests. -- assignee: - georg.brandl nosy: +georg.brandl priority: normal - critical ___ Python tracker rep...@bugs.python.org

[issue9824] SimpleCookie should escape commas and semi-colons

2010-09-11 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Thanks for forwarding this upstream. A tip about Python versions: Bugs are fixed on the active branch, py3k (which will become 3.2), then backported to 3.1 and 2.7. Security fixes go into 2.5 and 2.6 too. 3.3 means that something won’t make

[issue9824] SimpleCookie should escape commas and semi-colons

2010-09-10 Thread Luke Plant
New submission from Luke Plant l.plant...@cantab.net: In developing Django, we found that some browsers don't treat commas and semi-colons in cookie values (i.e. the Set-Cookie header) the way that RFC 2109 says they should. (Safari splits the header on a comma followed by space, Internet

[issue9824] SimpleCookie should escape commas and semi-colons

2010-09-10 Thread Luke Plant
Luke Plant l.plant...@cantab.net added the comment: I forgot to mention backwards compatibility: In the context of Cookie being used in a web application, if developers were relying on literal commas and semi-colons being present in the client side cookie value (e.g. in javascript), the patch