[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-11-01 Thread Michael Foord
Michael Foord added the comment: Committed to release27-maint in revision 86104. -- resolution: -> accepted stage: -> committed/rejected status: open -> closed ___ Python tracker _

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-11-01 Thread Michael Foord
Michael Foord added the comment: Committed to py3k in revision 86101. Needs porting to Python 2.7 (and unittest2). -- ___ Python tracker ___

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-25 Thread Michael Foord
Michael Foord added the comment: The attached patch fixes the issue (I think...) by tagging the result object. It removes the need for _wrapped_result altogether. The test fails without the change to TestSuite and passes with the change. This could be applied to 2.7-maint and py3k. Uhm... th

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-24 Thread Michael Foord
Michael Foord added the comment: On 24/09/2010 19:23, Martin v. Löwis wrote: > Martin v. Löwis added the comment: >> Perhaps slightly ironically (for this particular bug report) is that >> the change was introduced to support class and module level setUp and >> tearDown (similar to the use-case

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-24 Thread Martin v . Löwis
Martin v. Löwis added the comment: > Perhaps slightly ironically (for this particular bug report) is that > the change was introduced to support class and module level setUp and > tearDown (similar to the use-case it now blocks). FWIW, this issue arrived from pygresql, see TestSuite2 in http://

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-24 Thread Michael Foord
Michael Foord added the comment: Ok, so here is an idea that could remove the need for TestSuite._wrapped_run. TestSuite.run could "tag" the result object (set an attribute). Nested TestSuites would see an already tagged suite and do nothing (beyond running tests of course). The suite that d

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-23 Thread Michael Foord
Michael Foord added the comment: Hmmm... 2.7 has already been released and has the same issue, so 'drastic' changes (like renaming BaseTestSuite back to TestSuite) are probably out. -- components: +Library (Lib) versions: +Python 2.7 ___ Python trac

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-23 Thread Michael Foord
Michael Foord added the comment: Right, _wrapped_run is private and not intended to be overridden. Perhaps slightly ironically (for this particular bug report) is that the change was introduced to support class and module level setUp and tearDown (similar to the use-case it now blocks). Ano

[issue9926] Wrapped TestSuite subclass does not get __call__ executed

2010-09-23 Thread Martin v . Löwis
New submission from Martin v. Löwis : In Python 3.2, when inheriting from TestSuite, it is no longer possible to override __call__ (e.g. to introduce a TestSuite setUp and tearDown). The __call__ method will not be called anymore. Instead, if the object has a _wrapped_run defined (which it will