[issue9948] findCaller is slow and loses case information on Windows

Georg Brandl added the comment: Closing due to lack of response. -- nosy: +georg.brandl resolution: -> fixed status: pending -> closed ___ Python tracker ___

[issue9948] findCaller is slow and loses case information on Windows

Vinay Sajip added the comment: Partial fix checked into py3k and release27-maint branches (for losing filename case information) - r85361. Regarding performance changes - awaiting feedback from Armin re. my performance measurements showing only marginal differences. -- status: open -

[issue9948] findCaller is slow and loses case information on Windows

Vinay Sajip added the comment: I made a temporary change to logging to time the two different approaches: see this gist: http://gist.github.com/601162 According to these findings, the use of module globals seems to make only a marginal difference: vi...@eta-jaunty:~/projects/scratch$ python

[issue9948] findCaller is slow and loses case information on Windows

Vinay Sajip added the comment: > That is very undocumented behaviour and relying on that sounds like a > terrible idea. Agreed, I'm just fretting about it ... > First of all that should not be a global setting, secondly this is currently > not possible in logging either. True, but you have

[issue9948] findCaller is slow and loses case information on Windows

Armin Ronacher added the comment: > 1. Users can use _srcFile = None to avoid calling findCaller() > altogether, so I can't do away with the _srcFile altogether as it may > cause some issues with existing code. That is very undocumented behaviour and relying on that sounds like a terrible ide

[issue9948] findCaller is slow and loses case information on Windows

Vinay Sajip added the comment: Your basic fix looks fine, but there's a couple of other issues to consider: 1. Users can use _srcFile = None to avoid calling findCaller() altogether, so I can't do away with the _srcFile altogether as it may cause some issues with existing code. 2. If using e

[issue9948] findCaller is slow and loses case information on Windows

Changes by Armin Ronacher : Removed file: http://bugs.python.org/file19008/find-caller.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue9948] findCaller is slow and loses case information on Windows

Changes by Armin Ronacher : Added file: http://bugs.python.org/file19009/find-caller.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9948] findCaller is slow and loses case information on Windows

New submission from Armin Ronacher : findCaller() on loses case information on the files on Windows and has in general a really bad performance. The attached patch does not depend on filename comparisions and instead compares the object identity of the caller's global namespace against the on