[issue38427] Issue URL on translated Python docs site is always pointed to English version

2019-10-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: There are occasional reports of typo in translations that are opened in bugs.python.org and it would make sense to redirect to respective GitHub repos for the translations. -- nosy: +mdk, xtreak ___ Pyth

[issue38427] Issue URL on translated Python docs site is always pointed to English version

2019-10-10 Thread Shengjing Zhu
Shengjing Zhu added the comment: On https://docs.python.org/zh-cn/3/bugs.html we emphasis that translation bugs should be reported at GitHub. So that's why I want the footer link same as previous (link to translated bugs.html). -- ___ Python track

[issue38426] declare visit_validate in Py_DEBUG macro

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset a5447735c334a041ee2ffdeb5c7e13d7d4502ea2 by Victor Stinner in branch 'master': bpo-38392: Only declare visit_validate() if Py_DEBUG is defined (GH-16689) https://github.com/python/cpython/commit/a5447735c334a041ee2ffdeb5c7e13d7d4502ea2 ---

[issue38392] Ensure that objects entering the GC are valid

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset a5447735c334a041ee2ffdeb5c7e13d7d4502ea2 by Victor Stinner in branch 'master': bpo-38392: Only declare visit_validate() if Py_DEBUG is defined (GH-16689) https://github.com/python/cpython/commit/a5447735c334a041ee2ffdeb5c7e13d7d4502ea2 ---

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16278 pull_request: https://github.com/python/cpython/pull/16691 ___ Python tracker ___ __

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16277 pull_request: https://github.com/python/cpython/pull/16690 ___ Python tracker ___ __

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset 7bb14316b8ceddb813f31040a299af94a57ab339 by Victor Stinner (Ronan Lamy) in branch 'master': bpo-38109: Add missing constants to Lib/stat.py (GH-16665) https://github.com/python/cpython/commit/7bb14316b8ceddb813f31040a299af94a57ab339 --

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Ronan Lamy: Hum, do you really need this change to land in Python 3.7 and 3.8? If not, I will close PR 16690 and PR 16691 backports. I don't think that it's worth it, since _stat should be always present in CPython. -- _

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread Christian Heimes
Change by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset a05fcd3c7adf6e3a0944da8cf80a3346882e9b3b by Victor Stinner (Dong-hee Na) in branch 'master': bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688) https://github.com/python/cpython/commit/a05fcd3c7adf6e3a0944da8cf80a3346882e9b3b ---

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16279 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16693 ___ Python tracker ___ __

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16280 pull_request: https://github.com/python/cpython/pull/16694 ___ Python tracker ___ __

[issue36339] test_ttk_guionly: test_traversal() fails randomly on AMD64 Windows8.1 Refleaks 2.7

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Recent failure: The Buildbot has detected a failed build on builder AMD64 Windows8.1 Refleaks 2.7 while building Python. Full details are available at: https://buildbot.python.org/all/#builders/33/builds/726 -- __

[issue38426] declare visit_validate in Py_DEBUG macro

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the report. It's now fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37677] Seg Fault on OSX when multiprocessing

2019-10-10 Thread Ronald Oussoren
Ronald Oussoren added the comment: Looking at the stack trace this is a similar issue as the "no_proxy" one, but in some sense worse because it happens when just calling a regular unix API (not an Apple framework API). The first few lines of the stack trace are for code in the "Network" fram

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Another use of the deprecated unsafe preexec_fn was to call os.umask in the > child prior to exec. What do you mean by "deprecated"? The parameter doesn't seem to be deprecated in the documentation: https://docs.python.org/dev/library/subprocess.html#subpr

[issue38416] test_largefile.TestSocketSendfile.test_it() failed with 15 min timeout on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-10-10 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Another approach is to change the timeout of 15 min for this super slow > buildbot. For example, set it to 20 min or 30 min. I think this makes more sense (set timeout to 25 min). -- ___ Python tracker

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: pylint emits a warning on subprocess.Popen(preexec_fn=func): W1509: Using preexec_fn keyword which may be unsafe in the presence of threads (subprocess-popen-preexec-fn) But not when using subprocess.run(preexec_fn=func). Maybe a check is missing in py

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread miss-islington
miss-islington added the comment: New changeset 6b6935e563562c427d5bb1b2864d6a2fed0e74fa by Miss Islington (bot) in branch '3.8': bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688) https://github.com/python/cpython/commit/6b6935e563562c427d5bb1b2864d6a2fed0e74fa -- nos

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > We should not provide such an "run arbitrary python code before execing the > ultimate child" feature in the standard library. Do you want to modify _posixsubprocess to call umask() between fork() and exec()? As it has been done for uid, gid and groups: ca

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread miss-islington
miss-islington added the comment: New changeset d27a9b1695a1b46c81b3a83a7a35034791265d89 by Miss Islington (bot) in branch '3.7': bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688) https://github.com/python/cpython/commit/d27a9b1695a1b46c81b3a83a7a35034791265d89 -- __

[issue38425] Remove warning: ‘res’ may be used uninitialized in this function

2019-10-10 Thread Dong-hee Na
Change by Dong-hee Na : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue38416] test_largefile.TestSocketSendfile.test_it() failed with 15 min timeout on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I changed AMD64 FreeBSD 10-STABLE timeout from 15 to 30 minutes. https://github.com/python/buildmaster-config/commit/c3fe0b1b65d94c1150521dda4daba02775dc -- resolution: -> fixed stage: -> resolved status: open -> closed

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread Christian Heimes
Christian Heimes added the comment: preexec_fn does not work in subinterpreters, which (amongst others) affects mod_wsgi and similar WSGI implementations. Therefore portable software must not use preexec_fn at all. -- ___ Python tracker

[issue38417] Add support for settting umask in subprocess children

2019-10-10 Thread Christian Heimes
Christian Heimes added the comment: Changed in version 3.8: The preexec_fn parameter is no longer supported in subinterpreters. The use of the parameter in a subinterpreter raises RuntimeError. The new restriction may affect applications that are deployed in mod_wsgi, uWSGI, and other embedd

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou: "... I'm against this change ..." Martin Panter: "... But this seems unreasonable to me. ..." I close the issue. You can use asyncio for non-blocking networking code. Or have a look at Twisted, Tornado, eventlet, etc. If you really want to

[issue35762] subprocess.Popen with universal_newlines and nonblocking streams fails with "can't concat NoneType to bytes"

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I close this issue as a duplicate of bpo-13322 which is older and has a longer history. -- nosy: +vstinner resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> buffered read() and write() does not raise BlockingIOError

[issue13322] buffered read() and write() does not raise BlockingIOError

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I closed bpo-35762 as a duplicate of this issue: subprocess.Popen with universal_newlines and nonblocking streams fails with "can't concat NoneType to bytes". -- nosy: +vstinner ___ Python tracker

[issue26292] Raw I/O writelines() broken for non-blocking I/O

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I close this issue as duplicate of bpo-13322 which is older and has a longer history. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> buffered read() and write() does not raise BlockingIOError _

[issue13322] buffered read() and write() does not raise BlockingIOError

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I closed bpo-26292 as a duplicate of this issue: Raw I/O writelines() broken for non-blocking I/O. -- ___ Python tracker ___ ___

[issue24560] codecs.StreamReader doesn't work with nonblocking streams: TypeError: can't concat bytes to NoneType

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I close this issue as a duplicate of bpo-13322. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> buffered read() and write() does not raise BlockingIOError ___ Python tracker

[issue13322] buffered read() and write() does not raise BlockingIOError

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I closed bpo-24560 as a duplicate of this issue: codecs.StreamReader doesn't work with nonblocking streams: TypeError: can't concat bytes to NoneType. -- ___ Python tracker ___

[issue13322] buffered read() and write() does not raise BlockingIOError

2019-10-10 Thread Jakub Stasiak
Change by Jakub Stasiak : -- nosy: +jstasiak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue13322] buffered read() and write() does not raise BlockingIOError

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-32561: Add API to io objects for non-blocking reads/writes. -- ___ Python tracker ___ __

[issue13322] The io module doesn't support non-blocking files

2019-10-10 Thread STINNER Victor
Change by STINNER Victor : -- components: -Documentation, IO title: buffered read() and write() does not raise BlockingIOError -> The io module doesn't support non-blocking files versions: +Python 3.9 -Python 2.7, Python 3.6, Python 3.7 ___ Python

[issue32561] Add API to io objects for non-blocking reads/writes

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Background: Doing I/O to files on disk has a hugely bimodal latency. If the > I/O happens to be in or going to cache (either user-space cache, like in > io.BufferedIOBase, or the OS's page cache), then the operation returns > instantly (~1 µs) without block

[issue38428] Can't gracefully ctrl+C multiprocessing pool on Python3 & Windows

2019-10-10 Thread Rebecca Fair
New submission from Rebecca Fair : I want to be able to Ctrl+C to exit a multiprocessing Pool.map gracefully, and have made a solution based on this Stack Overflow answer: https://stackoverflow.com/questions/11312525/catch-ctrlc-sigint-and-exit-multiprocesses-gracefully-in-python However, thi

[issue13322] The io module doesn't support non-blocking files

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: TextIOWrapper, and maybe also BufferedRead, may raise an exception if the underlying file descriptor is configured in non-blocking mode. It may require an additional syscall() to query the FD properties, which may slowdown the creation of file objects in Pyt

[issue38428] Can't gracefully ctrl+C multiprocessing pool on Python3 & Windows

2019-10-10 Thread Rebecca Fair
Rebecca Fair added the comment: Sorry, I didn't realise it wouldn't link to a commit automatically, the commit is here: https://github.com/python/cpython/commit/7c3e5773954009d65520eb063621cf7724da88e3 -- ___ Python tracker

[issue32561] Add API to io objects for non-blocking reads/writes

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: The Linux kernel 5.1 also got a new "io_uring" for asynchronous I/O: "Ringing in a new asynchronous I/O API" https://lwn.net/Articles/776703/ Linux 5.2: "The io_uring mechanism has a new operation, IORING_OP_SYNC_FILE_RANGE, which performs the equivalent of

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Haruka Ma
New submission from Haruka Ma : Since commit https://github.com/python/cpython/commit/c02b41b1fb115c87693530ea6a480b2e15460424 , some syntax errors are preventing cpython from compiling with --enable-framework on. Specifically, the errors are in Modules/getpath.c on line 1134 and 1165. I'v

[issue32561] Add API to io objects for non-blocking reads/writes

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I suggest to close the issue and move the discussion to a place to discuss asynchronous ideas. I'm sorry, but I don't understand what it is proposed here. I understand that Nathaniel wants to add something like a new "asynchronous" mode in the io module wh

[issue38416] test_largefile.TestSocketSendfile.test_it() failed with 15 min timeout on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-10-10 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Thanks. -- resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker ___ ___

[issue38416] test_largefile.TestSocketSendfile.test_it() failed with 15 min timeout on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-10-10 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Ned Deily
Change by Ned Deily : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Evgeny Nizhibitsky
New submission from Evgeny Nizhibitsky : I have run into a memory leak caused by using run_in_executor + ThreadPoolExecutor while running some stability tests with custom web services. It was 1 MB leaked for 1k requests made for my case and I've extracted the root cause and converted it into

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Well, that's a common issue when using asyncio: you forgot await. async def main(_loop): while True: with futures.ThreadPoolExecutor() as pool: _loop.run_in_executor(pool, nop) sys.stdout.write(f'\r{get_mem():0.3f}MB') It shoul

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Andrew Svetlov
Andrew Svetlov added the comment: You MUST await a future returned from `loop.run_in_executor()` to avoid the leak. Yuri, what should we do with the issue? I see the second similar report in the last half of the year. Sure, we can add weakrefs somewhere in futures._chain_future() but I prett

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Yuri, what should we do with the issue? A Task emits a warning when it's not awaited. Can a Task be used instead of a Future in run_in_executor()? -- nosy: +vstinner ___ Python tracker

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Andrew Svetlov
Andrew Svetlov added the comment: Victor answered the first :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Andrew Svetlov
Andrew Svetlov added the comment: > Can a Task be used instead of a Future in run_in_executor()? I don't think that the task is required here. The problem is that run_in_executor is a function that returns asyncio future; that is in turn a wrapper around concurrent future object. If we conv

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Andrew Svetlov
Andrew Svetlov added the comment: The change is slightly not backward compatible but 1. It's pretty visible. In the worst-case instead of the memory leak people see a RuntimeWarning 2. We did it already for a part of API, e.g. loop.sock_read() and family -- __

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > If we convert run_in_executor() into async function we'll get a warning about > unawaited coroutine even without asyncio debug mode. That sounds like a good solution :-) -- ___ Python tracker

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-10 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16281 pull_request: https://github.com/python/cpython/pull/16695 ___ Python tracker ___ __

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16282 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16695 ___ Python tracker ___ _

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Oh, I expected that we had macOS buildbots building Python with --enable-framework. Thanks for the reporting the issue. I wrote PR 16695 which should fix the issue, but I cannot test my fix right now. -- ___ Pytho

[issue38430] Memory leak in ThreadPoolExecutor + run_in_executor

2019-10-10 Thread Evgeny Nizhibitsky
Evgeny Nizhibitsky added the comment: Oh, I see that in the initial code with leakage (it was heavy ThreadPoolExecutor + xgboost thing) there was an await but I must have lost it somewhere while reducing it to the minimal example and finished in the wrong direction. Glad too see that it rai

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Haruka Ma
Haruka Ma added the comment: I'm now getting double free on the same function: https://pastebin.com/zHWCtTuV (with debug on) -- ___ Python tracker ___ ___

[issue32561] Add API to io objects for non-blocking reads/writes

2019-10-10 Thread Nathaniel Smith
Nathaniel Smith added the comment: The proposal is to be able to run io module operations in two modes: the regular one, and one where performing actual I/O is forbidden – so if they go down the stack and can fulfill the operation from some in-memory buffer, great, they do that, and if not, t

[issue32996] Improve What's New in 3.7

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16283 pull_request: https://github.com/python/cpython/pull/16696 ___ Python tracker ___ __

[issue32996] Improve What's New in 3.7

2019-10-10 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: New changeset d47f0dd2e85ce032aebfedbde18cdb2e728fa79f by Ivan Levkivskyi (M. Eric Irrgang) in branch 'master': bpo-32996: Documentation fix-up. (GH-16646) https://github.com/python/cpython/commit/d47f0dd2e85ce032aebfedbde18cdb2e728fa79f -- nosy: +

[issue32996] Improve What's New in 3.7

2019-10-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +16284 pull_request: https://github.com/python/cpython/pull/16697 ___ Python tracker ___ __

[issue32996] Improve What's New in 3.7

2019-10-10 Thread miss-islington
miss-islington added the comment: New changeset ca012360b103f2ab1acfa506aed032b0ed9b105c by Miss Islington (bot) in branch '3.7': bpo-32996: Documentation fix-up. (GH-16646) https://github.com/python/cpython/commit/ca012360b103f2ab1acfa506aed032b0ed9b105c -- ___

[issue32996] Improve What's New in 3.7

2019-10-10 Thread miss-islington
miss-islington added the comment: New changeset baf8a9b03a56ce1ee2284763b267ff56ab4507fe by Miss Islington (bot) in branch '3.8': bpo-32996: Documentation fix-up. (GH-16646) https://github.com/python/cpython/commit/baf8a9b03a56ce1ee2284763b267ff56ab4507fe -- ___

[issue17894] Edits to descriptor howto

2019-10-10 Thread Ned Batchelder
Ned Batchelder added the comment: I think it's a bad precedent to have pages in the official docs that belong to a single author. If you want to maintain that kind of control, it should go on your blog. Part of the agreement for having material added to the official docs should be the unde

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Hum, getpath.c seems to use deprecated APIs: ./Modules/getpath.c:1098:20: warning: 'NSModuleForSymbol' is deprecated: first deprecated in macOS 10.5 - dladdr() [-Wdeprecated-declarations] pythonModule = NSModuleForSymbol(NSLookupAndBindSymbol("_Py_Initial

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Nice necro :) Socketserver is already subclassable and overridable for so many things. Hard to understand the reluctancy to _allow_ for a different way to handle accept timeouts. But this is also why I stopped contributing to core, because it turned

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset b6e0fc74265db96fdd0e0b8151c768c583ad80f0 by Victor Stinner in branch 'master': bpo-38353: Fix typos in calculate_argv0_path_framework() (GH-16695) https://github.com/python/cpython/commit/b6e0fc74265db96fdd0e0b8151c768c583ad80f0 -- __

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset b6e0fc74265db96fdd0e0b8151c768c583ad80f0 by Victor Stinner in branch 'master': bpo-38353: Fix typos in calculate_argv0_path_framework() (GH-16695) https://github.com/python/cpython/commit/b6e0fc74265db96fdd0e0b8151c768c583ad80f0 -- __

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the bug report Haruka Ma, it should now be fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread Ronan Lamy
Ronan Lamy added the comment: Well, my interest in this is to reduce the divergence between PyPy and CPython, and, potentially, to help other implementations. So I actually care more about 3.7 than about 3.9, which I probably won't look at before 2021. That said, I don't *need* anything: the

[issue14307] Make subclassing SocketServer simpler for non-blocking frameworks

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Hard to understand the reluctancy to _allow_ for a different way to handle > accept timeouts. But this is also why I stopped contributing to core, > because it turned out to be more about lobbying than anything else. To get a change merged into Python, yo

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8ab11c433a81b6c7ef84a66e36fbe199915e2ff6 by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16690) https://github.com/python/cpython/commit/8ab11c433a81b6c7ef84a66e36fbe199915

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset f5ed41c1ae9a575e965d55c6a5e86fb59181eee8 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16691) https://github.com/python/cpython/commit/f5ed41c1ae9a575e965d55c6a5e86fb5918

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I understand that backporting the change up to 3.7 makes your life easier, so I merged it. The change is safe and should not affect the regular use case (when the C extension _stat is used). Thanks Ronan for this nice enhancement. It's good to see the stat m

[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Ronald Oussoren
Ronald Oussoren added the comment: W.r.t. the deprecated APIs in getpath.c: Issue15498 That issue contains an ancient patch to switch to non-deprecated APIs, but we haven't had time yet to fully test these. The issue also mentions that Apple's install of Python already switched away from the

[issue15498] Eliminate the use of deprecated OS X APIs in getpath.c

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: The deprecation warnings are not fixed yet. They were quickly mentioned at: https://bugs.python.org/issue38429#msg354367 -- nosy: +vstinner ___ Python tracker __

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I created this issue to attempt to modify _PyPathConfig to use PyWideStringList for module_search_paths, to support ":" character in a path. It would fix bpo-31210. See also bpo-12989. -- ___ Python tracker

[issue38109] Missing constants in Lib/stat.py

2019-10-10 Thread Ronan Lamy
Ronan Lamy added the comment: Thanks Victor! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue38367] test_regrtest hanged on AMD64 Windows10 3.x

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: I hope that this bug has been fixed by my latest fix for bpo-37531. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker __

[issue38339] [3.5] The doc job of Travis CI fails on Python 3.5: needs at least Sphinx v1.8

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Larry merged my fix: commit edd9bc9cc99c919bdc87e5955ec8ad93c295fbe2 Author: Victor Stinner Date: Tue Oct 8 19:12:21 2019 +0200 [3.7] Doc: Bump sphinx. (GH-10676) (GH-10803) (#16522) (cherry picked from commit 2db96ae7444880d66d4ef65abab8a5e6f

[issue38282] socketmodule.c: _FORTIFY_SOURCE=2 warning in AF_ALG case of getsockaddrarg()

2019-10-10 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16285 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16698 ___ Python tracker ___ _

[issue37972] unittest.mock.call does not chain __getitem__ to another _Call object

2019-10-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Closing as fixed since PRs were merged. Thanks Ben. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38230] A Path Traversal vulnerability in test/ssl_servers.py

2019-10-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I would propose closing since it's meant for tests and not for end users. I am also not sure if one of the tests depend on this behavior. Adding Victor as friendly ping since it's tagged as security. -- nosy: +vstinner

[issue36553] inspect.is_decorator_call(frame)

2019-10-10 Thread Sylvain Marie
Sylvain Marie added the comment: Quick update on this feature: for the following example to work: from inspect import is_decorator_call def set_hello_tag(tag='world'): if is_decorator_call(): # called without parenthesis! # the decorated object is `tag` return set_

[issue38230] A Path Traversal vulnerability in test/ssl_servers.py

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: Lib/test/ssl_servers.py is an internal test helper and not designed to be used by any end-user. Don't use it ;-) -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue37931] crash reimporting posix after Py_Finalize on mac

2019-10-10 Thread Benoit Hudson
Benoit Hudson added the comment: Ping! The patch has been ready for review for over a month. If the patch can be backported to 2.7.x before that gets end-of-lifed it would be ideal. -- versions: +Python 2.7 ___ Python tracker

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Samuel Colvin
New submission from Samuel Colvin : The following code works fine with python 3.7 but breaks with 3.8: ``` import dataclasses from typing import Optional @dataclasses.dataclass class TestingDataclass: base_path: dataclasses.InitVar[Optional[str]] = None ``` Exception traceback: ``` Trace

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Samuel Colvin
Samuel Colvin added the comment: This is a bug with the `__repr__` method on `InitVar`. I'm working on a PR now. -- ___ Python tracker ___ ___

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: git blame points to https://github.com/python/cpython/commit/01ee12ba35a333e8a6a25c4153c4a21838e9585c . I am tagging this as a 3.8 regression since the commit was not backported and 3.7 works fine. Feel free to remove it if it's a mistake. ---

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Samuel Colvin
Change by Samuel Colvin : -- keywords: +patch pull_requests: +16286 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16700 ___ Python tracker ___ __

[issue38432] ZeroDivisionError when inf is expected

2019-10-10 Thread Behzad Seyfi
New submission from Behzad Seyfi : >>> 1/1e-323 inf >>> 1/1e-324 Traceback (most recent call last): File "", line 1, in ZeroDivisionError: float division by zero in a 1/x fraction, up to x = 1e-324 it is inf but when x = 1e-325 or little it throws ZeroDivisionError. It is not acceptable an

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +16287 pull_request: https://github.com/python/cpython/pull/16701 ___ Python tracker ___

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, Samuel already made a PR. Then I withdraw PR 16701. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue38431] dataclasses.InitVar breaks with typing.Optional

2019-10-10 Thread Samuel Colvin
Change by Samuel Colvin : -- pull_requests: +16288 pull_request: https://github.com/python/cpython/pull/16702 ___ Python tracker ___ ___

[issue38428] Can't gracefully ctrl+C multiprocessing pool on Python3 & Windows

2019-10-10 Thread Steve Dower
Steve Dower added the comment: I think you're right about that change touching the right code, but I'm pretty sure it wasn't working before either. (Python 2.7 had totally different code, IIRC.) But the good news is that we should be able to use code similar to what's in Modules/timemodule.

[issue38433] 2.7.17rc1 tcl/tk version regression on Windows

2019-10-10 Thread Terry J. Reedy
New submission from Terry J. Reedy : In my current 2.7.16+ Windows 10-64 repository build, and on at least one 8.1-64 buildbot, the tcl/tk version is 8.5.19 >>> tk.Tk().tk.call('info', 'patchlevel') '8.5.19' In my installed 2.7.17rc1, it is the older 8.5.15. It would seem to me that we shoul

[issue38432] ZeroDivisionError when inf is expected

2019-10-10 Thread STINNER Victor
STINNER Victor added the comment: That's not a bug: 64-bit float of IEEE 754 rounds 1e-324 to 0.0. vstinner@apu$ python3 Python 3.7.4 (default, Jul 9 2019, 16:32:37) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> 1e-

[issue38434] sys.addaudithook event is not documented

2019-10-10 Thread Steve Dower
New submission from Steve Dower : The sys.addaudithook raises an audit event 'sys.addaudithook'. The docs for the function refer to the event, as it has slightly different semantics than most, but it is not named explicitly and does not appear in the table of events. -- assignee: doc

  1   2   >