[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Vinay Sajip added the comment: Thanks for the PR. I reviewed it and requested changes about 3 weeks ago - you should have received a notification from GitHub when that happened. -- ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Brett Hannigan added the comment: Just wanted to check-in to see if there were any updates on my proposed PR? -- ___ Python tracker ___

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Brett Hannigan added the comment: O.K. CLA is now signed and if I check on the "check-yourself" with my github user it is showing that I have signed it now. -- ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Brett Hannigan added the comment: Thanks. I don't know why it still says CLA not signed - I signed it a week ago, but I'll try to figure that out this week. -- ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Vinay Sajip added the comment: OK, seems like a reasonable use case. I haven't looked at the PR yet, as it still has a "CLA not signed" label, and I normally wait until the CLA is signed before looking more closely at PRs. -- ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Brett Hannigan added the comment: I encountered the need for the iterators when trying to create a subclass of the QueueHandler class that would manage both the QueueHandler and the QueueListener. The implementation is very similar to that described in this Medium post:

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Vinay Sajip added the comment: > If it is not goal I don't have a goal to make these part of a documented API. OP, can you share a use case where you need to iterate over these internal structures? -- ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Serhiy Storchaka added the comment: If you are going to make them public general purpose classes you need to implement also support of slices, __reversed__(), index(), remove(), count(), sort(), copy() in ConvertingList and more methods in ConvertingTuple, and ConvertingDict. If it is not

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Vinay Sajip added the comment: > I think the other issue here is that the ConvertingX classes aren't > documented apart from comments in the code where they are defined. That's deliberate - they're considered an internal implementation detail. --

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Michael DePalatis added the comment: I think the other issue here is that the ConvertingX classes aren't documented apart from comments in the code where they are defined. -- nosy: +mivade ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Change by Brett Hannigan : -- versions: -Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Vinay Sajip added the comment: This is a change in behaviour, so probably needs to be added to future versions only. -- nosy: +vinay.sajip versions: +Python 3.10 -Python 3.7 ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 1.0 -> 2.0 pull_requests: +20398 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21248 ___ Python tracker

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

New submission from Brett Hannigan : The logging.config module uses three internal data structures to hold items that may need to be converted to a handler or other object: ConvertingList, ConvertingTuple, and ConvertingDict. These three objects provide interfaces to get converted items