actually if your patch contains
"diff -r f4377699fd47 Lib/test/test_zipimport.py"
lines prior to the --- line as hg diff can emit, it'll do the right thing
and show the review against the version of the file listed (or at least
against it's branch head? that's an example taken from 3.3 for a patc
On Mon, Feb 3, 2014 at 12:03 PM, Yury Selivanov wrote:
> Hello,
>
> Another quick infrastructure question (is this the right list, btw?):
>
There is always the meta bug tracker at
http://psf.upfronthosting.co.za/roundup/meta/ for tracker issues.
___
pyt
OK, thank you.
Are you sure it's the right thing to do? I.e. a user can create a
patch, ensure that it applies cleanly, and while he uploads it,
someone pushes to the repo. No 'review' link, no notification.
Wouldn't it make sense to always show the review link, and let
the user to resolve the c
On Mon, Feb 3, 2014 at 11:03 AM, Yury Selivanov wrote:
> Hello,
>
> Another quick infrastructure question (is this the right list, btw?):
Core-mentorship is another good candidate.
> I don't see 'review' links for some patches. Like in issue #14911,
> Kristján uploaded two patches, same day, alm
On lun., 2014-02-03 at 09:16 -0800, Guido van Rossum wrote:
> IIRC the review link only appears if the patch applies cleanly.
And only if it applies cleanly on the default branch, IIRC :-)
Regards
Antoine.
___
python-committers mailing list
python-c
IIRC the review link only appears if the patch applies cleanly.
On Mon, Feb 3, 2014 at 9:03 AM, Yury Selivanov wrote:
> Hello,
>
> Another quick infrastructure question (is this the right list, btw?):
> I don't see 'review' links for some patches. Like in issue #14911,
> Kristján uploaded two pa
Hello,
Another quick infrastructure question (is this the right list, btw?):
I don't see 'review' links for some patches. Like in issue #14911,
Kristján uploaded two patches, same day, almost same time, and I
see a review link only for one of them.
Screenshot: http://goo.gl/HK2oer
Thanks,
Yury
