Re: [python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Mariatta Wijaya
So there is already a PR in the devguide advising contributors to keep their commit history intact, see https://github.com/python/devguide/pull/162 Assuming people do read the devguide, then let's hope that we won't lose the commit history going forward. There is also already a section in the

Re: [python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Terry Reedy
On 4/11/2017 1:21 PM, Donald Stufft wrote: On Apr 11, 2017, at 12:25 PM, Terry Reedy > wrote: I was under the impression that the green [commit] button would do the squashing. Or at least that it could. Yes it can, and IIRC for CPython we have

Re: [python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Donald Stufft
> On Apr 11, 2017, at 12:25 PM, Terry Reedy wrote: > > On 4/10/2017 11:55 PM, Martin Panter wrote: >> On 11 April 2017 at 13:13, Mariatta Wijaya wrote: >>> "View Changes" doesn't work when commits in PR were squashed, which seems to >>> be the case

Re: [python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Terry Reedy
On 4/10/2017 11:55 PM, Martin Panter wrote: On 11 April 2017 at 13:13, Mariatta Wijaya wrote: "View Changes" doesn't work when commits in PR were squashed, which seems to be the case in https://github.com/python/cpython/pull/851 I wonder if there is a way to

Re: [python-committers] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Guido van Rossum
On Tue, Apr 11, 2017 at 7:42 AM, Nick Coghlan wrote: > Since we do the squash & merge to get an atomic commit at the end, it > doesn't make sense to do any force pushes along the way. > I was going to argue with this, but then I realized you're right. We shouldn't need

Re: [python-committers] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Nick Coghlan
On 12 April 2017 at 00:21, R. David Murray wrote: > On Mon, 10 Apr 2017 21:53:44 -0700, Guido van Rossum wrote: >> - When the contributor makes multiple local commits without pushing to the >> PR, I recommend using --amend unless they have several commits

Re: [python-committers] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread R. David Murray
On Mon, 10 Apr 2017 21:53:44 -0700, Guido van Rossum wrote: > - When the contributor makes multiple local commits without pushing to the > PR, I recommend using --amend unless they have several commits that > actually are logically distinct and relevant to the reviewer. (--amend

Re: [python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

2017-04-11 Thread Chris Jerdonek
On Mon, Apr 10, 2017 at 8:55 PM, Martin Panter wrote: > In this particular pull request, I think the submitter has rebased > their commit, and force-pushed it. These days, I notice Git Hub seems > to forget old commits pretty soon after you force-push the branch they > are