[python-committers] UPDATE: Python 3.6.2rc1 cutoff now scheduled for 2017-06-16 12:00 UTC

2017-06-14 Thread Ned Deily
The security-related release blocker (bpo-29591) has been resolved; my thanks to Victor for leading the effort. As of now, I'm not aware of any other release blocker issues for the 3.6.2 release candidate so I'm rescheduling the code cutoff for 2017-06-16 12:00 UTC, approximately 30 hours from

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Nick Coghlan
On 15 June 2017 at 00:40, Victor Stinner wrote: > Hi, > > The CPython workflow was enhanced to get pre-commit CI checks. That's > a huge win, thank you for that... But, sometimes, a change can still > break many buildbots, bugs which weren't catched by pre-commit checks > (Travis CI/Linux and AppV

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Barry Warsaw
On Jun 14, 2017, at 11:00 PM, Victor Stinner wrote: >Since I'm trying to always keep the highest number of green buildbots, >I prefer to try to fix the bug myself. > >My question is what to do if I'm unable to fix the issue and the >author is not available. Keep a broken CI for hours, sometimes fo

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Ethan Furman
On 06/14/2017 02:07 PM, Donald Stufft wrote: I’m +1 on reverting the change, I’d even go so far to say I’d be +1 on doing it as a first response. It’s always possible to revert the revert once the person who committed the patch has time to investigate the failure and recommit the patch with a

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Donald Stufft
I’m +1 on reverting the change, I’d even go so far to say I’d be +1 on doing it as a first response. It’s always possible to revert the revert once the person who committed the patch has time to investigate the failure and recommit the patch with a fix. > On Jun 14, 2017, at 5:00 PM, Victor Sti

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
2017-06-14 18:38 GMT+02:00 Serhiy Storchaka : > I think we first should make buildbots notifying the author of a > commit that broke tests or building, so his can either quickly fix the > failure or revert his commit. Hum, I think that I should elaborate my previous email. It's usually easy to id

Re: [python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-14 Thread Victor Stinner
2017-06-14 22:40 GMT+02:00 Brett Cannon : >> Oh, I didn't know. Is it possible to see who owns a GitHub Python project >> at https://github.com/python/? > > If you can see https://github.com/orgs/python/teams/python-core/repositories > then yes. :) About this list, there was a question on the buil

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Brett Cannon
On Wed, 14 Jun 2017 at 07:46 Victor Stinner wrote: > Hi, > > The CPython workflow was enhanced to get pre-commit CI checks. That's > a huge win, thank you for that... But, sometimes, a change can still > break many buildbots, bugs which weren't catched by pre-commit checks > (Travis CI/Linux and

Re: [python-committers] Promote Julien Palards as Committers on docsbuild-scripts

2017-06-14 Thread Brett Cannon
On Tue, 13 Jun 2017 at 15:37 Victor Stinner wrote: > Le 14 juin 2017 00:29, "Brett Cannon" a écrit : > > It is, but the infrastructure team owns that repo, not Python core. > > -Brett > > > Oh, I didn't know. Is it possible to see who owns a GitHub Python project > at https://github.com/python/?

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
2017-06-14 18:38 GMT+02:00 Serhiy Storchaka : >> What do you think? Would you be ok with such rule? > > I think we first should make buildbots notifying the author of a > commit that broke tests or building, so his can either quickly fix the > failure or revert his commit. One or two months ago, I

Re: [python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Serhiy Storchaka
2017-06-14 17:40 GMT+03:00 Victor Stinner : > So I would like to set a new rule: if I'm unable to fix buildbots > failures caused by a recent change quickly (say, in less than 2 > hours), I propose to revert the change. > > It doesn't mean that the commit is bad and must not be merged ever. > No. I

[python-committers] Revert changes which break too many buildbots

2017-06-14 Thread Victor Stinner
Hi, The CPython workflow was enhanced to get pre-commit CI checks. That's a huge win, thank you for that... But, sometimes, a change can still break many buildbots, bugs which weren't catched by pre-commit checks (Travis CI/Linux and AppVeyor/Windows). Buildbots cover much more different architect