Re: [python-committers] GitHub blog post on managing email notifications

2017-07-18 Thread Guido van Rossum
In a similar vein, I found the triangular workflow described here useful: https://github.com/blog/2042-git-2-5-including-multiple-worktrees-and-triangular-workflows (TBH I don't follow the recipe exactly, but I do use upstream to point to the master repo, origin to point to my own fork on GitHub,

[python-committers] GitHub blog post on managing email notifications

2017-07-18 Thread Brett Cannon
Thought people might be interested in this post (specifically the email header info) since I know some have said they have had issues in managing email notifications: https://github.com/blog/2399-managing-large-numbers-of-github-notifications ___

Re: [python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Nick Coghlan
On 19 July 2017 at 09:37, Victor Stinner wrote: > Oh. > > For backports, it's convenient to be able to merge without a review. I see > many cores doing it and I like it. > > For master, I don't know. Sometimes a PR is merged too fast, sometiles > nobody reviews a PR even

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Mariatta Wijaya
> > 2. Bot to backport PRs (which could also be automatically merged) > So, to me, this is the priority item on the list. I'm planning to work on the cherry-pick bot this during the core sprint in September. Unless someone beat me to it. Automatically close stale PRs (e.g. not signing CLA,

Re: [python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 13:10 Victor Stinner wrote: > 2017-07-18 21:21 GMT+02:00 R. David Murray : > > On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner < > victor.stin...@gmail.com> wrote: > >> I'm just not unconfortable with the fact that an

Re: [python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Victor Stinner
Oh. For backports, it's convenient to be able to merge without a review. I see many cores doing it and I like it. For master, I don't know. Sometimes a PR is merged too fast, sometiles nobody reviews a PR even if it's good. So for the master branch, the dev takes its own responsability to merge

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 13:33 Paul Moore wrote: > On 18 July 2017 at 20:59, Brett Cannon wrote: > > I went ahead and clicked buttons. :) I set Python core as users and > release > > managers as admins (on top of Zach and me already being admins). > > Cool -

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 16:06 Terry Reedy wrote: > On 7/18/2017 2:31 PM, Brett Cannon wrote: > > > Once again, glad the goals are panning out. :) Key thing has always been > > to increase our bandwidth and part of that was always to push more on to > > contributors so they can

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 12:54 Barry Warsaw wrote: > On Jul 18, 2017, at 15:21, R. David Murray wrote: > > > > I much prefer rietveld over github reviews, but I also much prefer the > > integration between the bug tracker and github over the minimal > >

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Terry Reedy
On 7/18/2017 2:31 PM, Brett Cannon wrote: Once again, glad the goals are panning out. :) Key thing has always been to increase our bandwidth and part of that was always to push more on to contributors so they can be more self-servicing. * most contributors create backports (using

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Paul Moore
On 18 July 2017 at 20:59, Brett Cannon wrote: > I went ahead and clicked buttons. :) I set Python core as users and release > managers as admins (on top of Zach and me already being admins). Cool - when I log in now I have "python" as an option. I can't restart a build, but

[python-committers] Dismiss review if a PR is modified

2017-07-18 Thread Victor Stinner
2017-07-18 21:21 GMT+02:00 R. David Murray : > On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner > wrote: >> I'm just not unconfortable with the fact that an approval is kept even >> if the PR is modified after the review :-/ I would expect a

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Brett Cannon
On Tue, 18 Jul 2017 at 11:08 Zachary Ware wrote: > On Tue, Jul 18, 2017 at 12:23 PM, Brett Cannon wrote: > > I set up the account and Zach has access. If you have instructions to > point > > me at, Paul, I can see if I can set it up. > > Looks

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Barry Warsaw
On Jul 18, 2017, at 15:21, R. David Murray wrote: > > I much prefer rietveld over github reviews, but I also much prefer the > integration between the bug tracker and github over the minimal > integration we had for rietveld. Thanks to all the people who made > that

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread R. David Murray
On Tue, 18 Jul 2017 12:24:13 +0200, Victor Stinner wrote: > I'm just not unconfortable with the fact that an approval is kept even > if the PR is modified after the review :-/ I would expect a list a > notice "changed modified after the review" or something like that.

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Paul Moore
BTW, the docs for all this are at https://www.appveyor.com/docs/team-setup/#github-integration although I found them a bit hard to follow, personally. Paul On 18 July 2017 at 19:15, Paul Moore wrote: > That's the one. If you select the github team you want (for PyPA I set >

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Paul Moore
That's the one. If you select the github team you want (for PyPA I set up an "Appveyor Admins" team) and choose the Administrator role. That may well be all you need to do - I don't recall if you need to do anything on the github side. Once you do that, people in the relevant github group, when

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Zachary Ware
On Tue, Jul 18, 2017 at 12:23 PM, Brett Cannon wrote: > I set up the account and Zach has access. If you have instructions to point > me at, Paul, I can see if I can set it up. Looks like https://ci.appveyor.com/gitHubTeams while logged in as 'python'. That looks like the

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Paul Moore
I'll get something for you, but it may not be for a couple of days. Paul On 18 July 2017 at 18:23, Brett Cannon wrote: > I set up the account and Zach has access. If you have instructions to point > me at, Paul, I can see if I can set it up. > > > On Tue, 18 Jul 2017 at 09:26

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Brett Cannon
I set up the account and Zach has access. If you have instructions to point me at, Paul, I can see if I can set it up. On Tue, 18 Jul 2017 at 09:26 Paul Moore wrote: > You need to log on as the Appveyor account in order to manage builds. > It's possible to link a Github

Re: [python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Paul Moore
You need to log on as the Appveyor account in order to manage builds. It's possible to link a Github team with an Appveyor admin role to allow the team to all have the ability to (effectively) log in as the appveyor account. It's a bit fiddly to set up (and use :-() but it does work. If whoever

[python-committers] How do I kill an AppVeyor build?

2017-07-18 Thread Antoine Pitrou
Hi, It seems only some select people have the ability to kill or re-launch AppVeyor builds? Regards Antoine. ___ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct:

[python-committers] "Invalid symmetric difference expression" on Travis-CI

2017-07-18 Thread Antoine Pitrou
Hi, I've just got this weird error on Travis-CI (the build itself is still marked green, which is great :-D): https://travis-ci.org/python/cpython/jobs/254906991 """ $ set -e if ! git diff --name-only $TRAVIS_COMMIT_RANGE | grep -qvE '(\.rst$)|(^Doc)|(^Misc)' then echo "Only docs were

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Serhiy Storchaka
18.07.17 14:40, Antoine Pitrou пише: Assuming you meant Martin von Löwis, I think Martin stopped contributing long before we migrated to git (unfortunately, I might add). I hope he's doing ok. I meant Martin Panter. His was the third of most active committers recent two years, but didn't

[python-committers] Unreliable contributor stats

2017-07-18 Thread Antoine Pitrou
Le 18/07/2017 à 12:24, Victor Stinner a écrit : > > == More contributors, more contributions, faster reviewed/merged == > > In term of contributions, I looked at statistics yesterday and it > became clear the number of different authors is significantely much > higher, around 25 contributors /

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Nick Coghlan
On 18 July 2017 at 21:36, Serhiy Storchaka wrote: > I rather like the new workflow (except few lost features), but I afraid than > many core developers are feeling uncomfortable with it. Aye, I think for folks already familiar with git and PR-style workflows through other

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Antoine Pitrou
Le 18/07/2017 à 13:36, Serhiy Storchaka a écrit : > > I have a different impression. Some core developers (like Raymond or > Martin) stopped committing even if they are active on the bug tracker or > mailing lists. Others make much less commits than they did before the > migration. Assuming

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Serhiy Storchaka
18.07.17 13:24, Victor Stinner пише: == More contributors, more contributions, faster reviewed/merged == In term of contributions, I looked at statistics yesterday and it became clear the number of different authors is significantely much higher, around 25 contributors / month before, now

[python-committers] My (positive) feedback on the new CPython workflow

2017-07-18 Thread Victor Stinner
Hi, 2017-07-18 11:36 GMT+02:00 Antoine Pitrou : > Can I take the opportunity to say thank you again (both you and Larry) > for the "blurb" tool? It really makes an important difference when > contributing. > > Regards > > Antoine. I concur with Antoine, I'm now *very* happy

Re: [python-committers] CLA bot bug for a particular contributor

2017-07-18 Thread Victor Stinner
I removed the "CLA not signed" and automatically, the label "CLA signed" appears in 2 seconds ;-) Have a nice day. Victor 2017-07-18 11:34 GMT+02:00 Antoine Pitrou : > > Hi, > > How can I get the CLA bot to fix its knowledge for a particular contributor? > > bugs.python.org

Re: [python-committers] "trivial" label replaced with "skip issue"

2017-07-18 Thread Antoine Pitrou
Le 17/07/2017 à 22:16, Brett Cannon a écrit : > > > On Sun, 16 Jul 2017 at 15:22 Victor Stinner > wrote: > > 2017-07-16 16:10 GMT+02:00 Victor Stinner >: > >

[python-committers] CLA bot bug for a particular contributor

2017-07-18 Thread Antoine Pitrou
Hi, How can I get the CLA bot to fix its knowledge for a particular contributor? bugs.python.org user Gareth Rees (https://bugs.python.org/user14554) has signed the CLA and filled in his GitHub username "gareth-rees". However, a PR filed by Gareth (https://github.com/python/cpython/pull/2741)