Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Brett Cannon
I just wanted to say I agree with everything Eric said, for +1 from me. On Thu, Jun 14, 2018, 14:34 Eric Snow, wrote: > On Wed, Jun 13, 2018 at 10:16 AM Victor Stinner > wrote: > > I propose to promote Pablo Salingo Salgado as a core developer and so > > open a vote during one week. If there is

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Nathaniel Smith
On Thu, Jun 14, 2018 at 4:40 AM, Berker Peksağ wrote: > This isn't about my or someone else's high standards. We keep saying > we need more triagers and reviewers, and we keep promoting people who > didn't do any issue triaging and code review. It's not fair to > contributors who have spent so muc

Re: [python-committers] Mentoring Office Hours - the idea, and a question

2018-06-14 Thread Mariatta Wijaya
Thanks for starting this, Brian. As such, it needs a person/persons/list to contact should something arise > in this context that needs to be handled. What/who should that be? * Suggestion 2: Create some new list with a few key people on it. > * Suggestion 3: List some direct names. Who? I pe

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Eric Snow
On Wed, Jun 13, 2018 at 10:16 AM Victor Stinner wrote: > I propose to promote Pablo Salingo Salgado as a core developer and so > open a vote during one week. If there is no strong opposition, I will > promote him but also continue to mentor him for a least one month. > > [snip] > > I am mentoring

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Brett Cannon
On Wed, 13 Jun 2018 at 16:11 Carol Willing wrote: > +1 With Victor's mentoring (1 or 2 months), I believe that it is > reasonable to promote Pablo to a core developer either now or after 3 > months of coaching. > > I would also like to see Cheryl Sabella who has been very active on the > bug trac

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Gregory P. Smith
Quick response: +0.5 My first reaction was "really?" given the amount of iteration required due to lack of CPython extension module API experience demonstrated in the os.posix_spawn PRs. (I am not surprised to see Serhiy's negative reaction) But Pablo shows drive and desire to do good things an

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Victor Stinner
Oh, I forgot to mention that Pablo is already helping me on triagging buildbot failures since 1 month.See my email to python-dev for the context: "[Python-Dev] How to watch buildbots?" https://mail.python.org/pipermail/python-dev/2018-May/153754.html You can see his emails on the buildbot-status

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Berker Peksağ
On Thu, Jun 14, 2018 at 11:46 AM, Victor Stinner wrote: > 2018-06-14 0:26 GMT+02:00 Berker Peksağ : >> I don't care about total number of commits to be honest. It's not so >> hard to get 50 PRs merged into master in a month or so. > > Wait, what? No developer got more than 50 commits merged into m

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Victor Stinner
2018-06-14 0:26 GMT+02:00 Berker Peksağ : > I don't care about total number of commits to be honest. It's not so > hard to get 50 PRs merged into master in a month or so. Wait, what? No developer got more than 50 commits merged into master in less than one month. Stats between May, 1st and today