Re: [python-committers] Untabifying the C codebase

2010-05-15 Thread Victor Stinner
Le lundi 10 mai 2010 03:01:11, A.M. Kuchling a écrit : > On Sun, May 09, 2010 at 06:56:27PM +0200, Antoine Pitrou wrote: > > There was one file that I didn't touch: Modules/_cursesmodule.c > > Indentation is so uncommon there that interested people should reformat > > it themselves, if desired. >

Re: [python-committers] Untabifying the C codebase

2010-05-12 Thread Nick Coghlan
Victor Stinner wrote: > Antoine patched the 4 most important branches. Do we you have other active > branches? Any other active feature branches (such as c-decimal and the branch for the signal work) should pick up the tab changes next time they do an svnmerge (or the moral equivalent for Tarek's

Re: [python-committers] Untabifying the C codebase

2010-05-12 Thread Martin v. Löwis
> Antoine patched the 4 most important branches. Do we you have other active > branches? Define "active". The 2.5 maintenance branch will have further releases made from it. Regards, Martin ___ python-committers mailing list python-committers@python.or

Re: [python-committers] Untabifying the C codebase

2010-05-12 Thread Victor Stinner
Le mardi 11 mai 2010 20:15:49, Guido van Rossum a écrit : > http://python-history.blogspot.com/2009/03/great-or-grand-renaming.html "Great or Grand Renamings are often traumatic events for software developer communities ... and complicate the integration of patches created before the renaming bu

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Nick Coghlan
Barry Warsaw wrote: >> And ever afterwards that time was known as the Epoch of the Great >> Untabification; and children heard stories of what programmers they had >> been. >> >> fanciful-ly y'rs - steve > > Who remembers the Great Renaming? :) Heh, I almost responded to Steve with "In before so

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Fred Drake
On Tue, May 11, 2010 at 3:20 PM, "Martin v. Löwis" wrote: > Wasn't it the /Grand/ Renaming? Rest assured, the Grand Renaming was a Great and Wondrous Event. -Fred -- Fred L. Drake, Jr. "Chaos is the score upon which reality is written." --Henry Miller ___

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Steve Holden
Martin v. Löwis wrote: > Barry Warsaw wrote: >> On May 11, 2010, at 09:20 PM, Martin v. Löwis wrote: >> >>> Barry Warsaw wrote: Who remembers the Great Renaming? :) >>> Wasn't it the /Grand/ Renaming? >> See Guido's link! (btw, what a great blog :). > > While studying this history, I ran int

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Martin v. Löwis
Barry Warsaw wrote: > On May 11, 2010, at 09:20 PM, Martin v. Löwis wrote: > >> Barry Warsaw wrote: > >>> Who remembers the Great Renaming? :) >> Wasn't it the /Grand/ Renaming? > > See Guido's link! (btw, what a great blog :). While studying this history, I ran into http://www.rmi.net/~lutz/

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Barry Warsaw
On May 11, 2010, at 09:20 PM, Martin v. Löwis wrote: >Barry Warsaw wrote: >> Who remembers the Great Renaming? :) > >Wasn't it the /Grand/ Renaming? See Guido's link! (btw, what a great blog :). -Barry signature.asc Description: PGP signature ___ p

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Martin v. Löwis
Barry Warsaw wrote: > On May 11, 2010, at 08:48 AM, Steve Holden wrote: > >> Nick Coghlan wrote: >>> Barry Warsaw wrote: On May 09, 2010, at 03:39 PM, Antoine Pitrou wrote: > Following discussion on python-dev, I plan to untabify the C codebase > this afternoon. It would probably

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Guido van Rossum
On Tue, May 11, 2010 at 10:13 AM, Fred Drake wrote: > On Tue, May 11, 2010 at 9:25 AM, Barry Warsaw wrote: >> Who remembers the Great Renaming? :) > > Oooh!   Oooh!  I know that one!   :-) > > >  -Fred http://python-history.blogspot.com/2009/03/great-or-grand-renaming.html -- --Guido van Rossu

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Fred Drake
On Tue, May 11, 2010 at 9:25 AM, Barry Warsaw wrote: > Who remembers the Great Renaming? :) Oooh! Oooh! I know that one! :-) -Fred -- Fred L. Drake, Jr. "Chaos is the score upon which reality is written." --Henry Miller ___ python-committ

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Barry Warsaw
On May 11, 2010, at 08:48 AM, Steve Holden wrote: >Nick Coghlan wrote: >> Barry Warsaw wrote: >>> On May 09, 2010, at 03:39 PM, Antoine Pitrou wrote: >>> Following discussion on python-dev, I plan to untabify the C codebase this afternoon. It would probably be better if nobody modified a

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Steve Holden
Nick Coghlan wrote: > Barry Warsaw wrote: >> On May 09, 2010, at 03:39 PM, Antoine Pitrou wrote: >> >>> Following discussion on python-dev, I plan to untabify the C codebase >>> this afternoon. It would probably be better if nobody modified any C files >>> in the meantime (except those that already

Re: [python-committers] Untabifying the C codebase

2010-05-11 Thread Nick Coghlan
Barry Warsaw wrote: > On May 09, 2010, at 03:39 PM, Antoine Pitrou wrote: > >> Following discussion on python-dev, I plan to untabify the C codebase >> this afternoon. It would probably be better if nobody modified any C files >> in the meantime (except those that already use 4 space indents). >

Re: [python-committers] Untabifying the C codebase

2010-05-10 Thread Brett Cannon
On Mon, May 10, 2010 at 07:02, Mark Dickinson wrote: > On Mon, May 10, 2010 at 2:25 PM, Barry Warsaw wrote: > > On May 09, 2010, at 09:01 PM, A.M. Kuchling wrote: > >>I'm happy to see the curses module re-indented. Does anyone have a > >>set of settings for Emacs or for GNU indent for Python's

Re: [python-committers] Untabifying the C codebase

2010-05-10 Thread A.M. Kuchling
On Mon, May 10, 2010 at 03:25:05PM +0200, Barry Warsaw wrote: > 'python' is a standard c-mode indentation style, however it's set up to use > tabs. It should be updated, maybe to a 'python3' style? Here's a quick and > dirty hack: Thanks! I've carried out a re-indentation and whitespace cleanup

Re: [python-committers] Untabifying the C codebase

2010-05-10 Thread Mark Dickinson
On Mon, May 10, 2010 at 2:25 PM, Barry Warsaw wrote: > On May 09, 2010, at 09:01 PM, A.M. Kuchling wrote: >>I'm happy to see the curses module re-indented.  Does anyone have a >>set of settings for Emacs or for GNU indent for Python's C indentation >>style? > > In Emacs, visit a C file and type: >

Re: [python-committers] Untabifying the C codebase

2010-05-10 Thread Barry Warsaw
On May 09, 2010, at 09:01 PM, A.M. Kuchling wrote: >On Sun, May 09, 2010 at 06:56:27PM +0200, Antoine Pitrou wrote: >> There was one file that I didn't touch: Modules/_cursesmodule.c >> Indentation is so uncommon there that interested people should reformat >> it themselves, if desired. > >I'm hap

Re: [python-committers] Untabifying the C codebase

2010-05-10 Thread Barry Warsaw
On May 09, 2010, at 03:39 PM, Antoine Pitrou wrote: >Following discussion on python-dev, I plan to untabify the C codebase >this afternoon. It would probably be better if nobody modified any C files >in the meantime (except those that already use 4 space indents). Thanks for doing something we've

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Guilherme Polo
2010/5/9 Alexandre Vassalotti : > On Sun, May 9, 2010 at 6:01 PM, A.M. Kuchling wrote: >> I'm happy to see the curses module re-indented.  Does anyone have a >> set of settings for Emacs or for GNU indent for Python's C indentation >> style? >> > > This invocation of GNU indent should work reasona

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Alexandre Vassalotti
On Sun, May 9, 2010 at 6:01 PM, A.M. Kuchling wrote: > I'm happy to see the curses module re-indented.  Does anyone have a > set of settings for Emacs or for GNU indent for Python's C indentation > style? > This invocation of GNU indent should work reasonably well: indent \ --no-tabs \ --ind

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread A.M. Kuchling
On Sun, May 09, 2010 at 06:56:27PM +0200, Antoine Pitrou wrote: > There was one file that I didn't touch: Modules/_cursesmodule.c > Indentation is so uncommon there that interested people should reformat > it themselves, if desired. I'm happy to see the curses module re-indented. Does anyone have

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Gregory P. Smith
On Sun, May 9, 2010 at 1:22 PM, Antoine Pitrou wrote: > Le dimanche 09 mai 2010 à 22:04 +0200, Victor Stinner a écrit : >> Le dimanche 09 mai 2010 18:56:27, Antoine Pitrou a écrit : >> > This was done in r81029 (trunk), r81031 (2.6), r81032 (3.x) and r81033 >> > (3.1). I'm mentioning the revision

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Antoine Pitrou
Le dimanche 09 mai 2010 à 22:04 +0200, Victor Stinner a écrit : > Le dimanche 09 mai 2010 18:56:27, Antoine Pitrou a écrit : > > This was done in r81029 (trunk), r81031 (2.6), r81032 (3.x) and r81033 > > (3.1). I'm mentioning the revision numbers because it seems > > python-checkins blocked the dif

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Victor Stinner
Le dimanche 09 mai 2010 18:56:27, Antoine Pitrou a écrit : > This was done in r81029 (trunk), r81031 (2.6), r81032 (3.x) and r81033 > (3.1). I'm mentioning the revision numbers because it seems > python-checkins blocked the diffs, sensibly enough. Does "make patchcheck" detect tab indentation and

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Antoine Pitrou
> Following discussion on python-dev, I plan to untabify the C codebase > this afternoon. It would probably be better if nobody modified any C files > in the meantime (except those that already use 4 space indents). > > I expect the whole operation to take a couple of hours. This was done in r810

Re: [python-committers] Untabifying the C codebase

2010-05-09 Thread Mark Dickinson
On Sun, May 9, 2010 at 2:39 PM, Antoine Pitrou wrote: > > Following discussion on python-dev, I plan to untabify the C codebase > this afternoon. It would probably be better if nobody modified any C files > in the meantime (except those that already use 4 space indents). Are you brave, or mad, or

[python-committers] Untabifying the C codebase

2010-05-09 Thread Antoine Pitrou
Hello, Following discussion on python-dev, I plan to untabify the C codebase this afternoon. It would probably be better if nobody modified any C files in the meantime (except those that already use 4 space indents). I expect the whole operation to take a couple of hours. Regards Antoine.