FieldStorage improvements as in MODPYTHON-93

2006-03-13 Thread Mike Looijmans
I'm currently using a 'private' patch, but I would really like to see this one incorporated in some release: http://issues.apache.org/jira/browse/MODPYTHON-93 The patch is there, all unit tests pass, and I've been torturing it myself for a while now. What else can (must?) I do to get it inte

get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Graham Dumpleton
That get_session() was being added at the C code level was also one of the things that worried me about this change. Thus in part why my suggestion for an alternate approach didn't touch the request object at all. While we are talking about this issue of additions to the request object, the doc

[jira] Created: (MODPYTHON-146) ap_internal_fast_redirect() and request object cache

2006-03-13 Thread Graham Dumpleton (JIRA)
ap_internal_fast_redirect() and request object cache Key: MODPYTHON-146 URL: http://issues.apache.org/jira/browse/MODPYTHON-146 Project: mod_python Type: Bug Components: core Versions: 3.2.8 Reporte

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Gregory (Grisha) Trubetskoy
On Mon, 13 Mar 2006, Graham Dumpleton wrote: Thus I want a documented convention that if a handler is going to use util.FieldStorage, that it should before doing so, first check whether an existing instance resides as req.form and use that instead. I'm not sure if this is a good example - req

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Graham Dumpleton
Grisha wrote .. > > On Mon, 13 Mar 2006, Graham Dumpleton wrote: > > > Thus I want a documented convention that if a handler is going to use > > util.FieldStorage, that it should before doing so, first check whether > > an existing instance resides as req.form and use that instead. > > I'm not s

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Jim Gallacher
Graham Dumpleton wrote: Grisha wrote .. On Mon, 13 Mar 2006, Graham Dumpleton wrote: Thus I want a documented convention that if a handler is going to use util.FieldStorage, that it should before doing so, first check whether an existing instance resides as req.form and use that instead. I

Re: FieldStorage improvements as in MODPYTHON-93

2006-03-13 Thread Jim Gallacher
Mike Looijmans wrote: I'm currently using a 'private' patch, but I would really like to see this one incorporated in some release: http://issues.apache.org/jira/browse/MODPYTHON-93 The patch is there, all unit tests pass, and I've been torturing it myself for a while now. What else can (mus

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Graham Dumpleton
Jim Gallacher wrote .. > The idea of something like req.get_session() is to give users an obvious > way to grab a session object without the deadlock concerns. How many > times have we seen this kind of problem-code on the mailing list? > > def index(req): > sess = Session.Session(req) >

mod_python roadmap

2006-03-13 Thread Jim Gallacher
I find I work more effectively when I have deadlines to worry about (being a procrastinator by nature), so I thought I'd propose the following roadmap. Mar 20: 3.3-dev - snapshot for testing Apr 1: 3.2.9 - bugfix release May 1: 3.3-dev - snapshot for testing Jun 15: 3.3-dev - snapsh

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Jim Gallacher
Graham Dumpleton wrote: Jim Gallacher wrote .. The idea of something like req.get_session() is to give users an obvious way to grab a session object without the deadlock concerns. How many times have we seen this kind of problem-code on the mailing list? def index(req): sess = Session.Se

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Graham Dumpleton
Jim Gallacher wrote .. > Which is all good, but you are assuming that people are only using > sessions for authentication purposes. Consider a shopping cart > implemented as session: the user may not be authenticated until *after* > they have filled their cart and are ready to checkout. Perhaps

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Gregory (Grisha) Trubetskoy
On Mon, 13 Mar 2006, Jim Gallacher wrote: The idea of something like req.get_session() is to give users an obvious way to grab a session object without the deadlock concerns. How many times have we seen this kind of problem-code on the mailing list? def index(req): sess = Session.Session(

Re: get_session(), req.session, req.form and MODPYTHON-38

2006-03-13 Thread Jim Gallacher
Gregory (Grisha) Trubetskoy wrote: On Mon, 13 Mar 2006, Jim Gallacher wrote: The idea of something like req.get_session() is to give users an obvious way to grab a session object without the deadlock concerns. How many times have we seen this kind of problem-code on the mailing list? def i

Re: FieldStorage improvements as in MODPYTHON-93

2006-03-13 Thread Mike Looijmans
Mike Looijmans Philips Natlab / Topic Automation Jim Gallacher wrote: Mike Looijmans wrote: I'm currently using a 'private' patch, but I would really like to see this one incorporated in some release: http://issues.apache.org/jira/browse/MODPYTHON-93 The patch is there, all unit tests pass,