[Python-Dev] Re: [Python-checkins] python/dist/src/Python marshal.c, 1.79, 1.80

2004-12-20 Thread Armin Rigo
Hi! A single-character diff... On Mon, Dec 20, 2004 at 04:25:59AM -0800, [EMAIL PROTECTED] wrote: > --- marshal.c 27 Jun 2004 16:51:46 - 1.79 > +++ marshal.c 20 Dec 2004 12:25:57 - 1.80 > @@ -893,7 +893,7 @@ > { > PyObject *x; > int version = Py_MARSHAL_VERSION; > -

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Python marshal.c, 1.79, 1.80

2004-12-20 Thread Aahz
On Mon, Dec 20, 2004, Armin Rigo wrote: > > Hi! > > A single-character diff... > > On Mon, Dec 20, 2004 at 04:25:59AM -0800, [EMAIL PROTECTED] wrote: >> --- marshal.c27 Jun 2004 16:51:46 - 1.79 >> +++ marshal.c20 Dec 2004 12:25:57 - 1.80 >> @@ -893,7 +893,7 @@ >>

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Raymond Hettinger
[Armin] > Crash.  Which means that there is no way in 2.4.0 to marshal an object in the > > old version format as a string -- you'd have to work around by writing a real > > file and reading it back :-( [Aahz] > Brown bag time? Perhaps a rather quick Py2.4.1 would be in order.   Ideally, it shoul

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Barry Warsaw
On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > Perhaps a rather quick Py2.4.1 would be in order. +1 -Barry signature.asc Description: This is a digitally signed message part ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.o

[Python-Dev] Re: Re: [Python-checkins]python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Fredrik Lundh
Raymond Hettinger wrote: > Perhaps a rather quick Py2.4.1 would be in order. sounds like a good idea. +1 from here. ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Jeremy Hylton
On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > > > Perhaps a rather quick Py2.4.1 would be in order. > > +1 Nothing wrong with an incremental release, but none of these sound like critical bugs to me. Jeremy

[Python-Dev] Latex problem when trying to build documentation

2004-12-20 Thread Irmen de Jong
I wanted to create a doc patch belonging to my patch #1062060, but got this error when trying to build the documentation from CVS: (/opt/PythonBugDay/python/dist/src/Doc/commontex/reportingbugs.tex Underfull \hbox (badness 1) in paragraph at lines 13--17 []\OT1/ptm/m/n/10 All bug re-ports

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Irmen de Jong
Raymond Hettinger wrote: Perhaps a rather quick Py2.4.1 would be in order. Ideally, it should include other important fixes: [...] * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar im

RE: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Raymond Hettinger
> Raymond Hettinger wrote: > > Perhaps a rather quick Py2.4.1 would be in order. > > > > Ideally, it should include other important fixes: > [...] > > * Fix for off-by-one bug in urllib.URLopener.retrieve > >http://www.python.org/sf/810023 > >(assigned to me) > > Is http://www.python.org/s

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Irmen de Jong
Raymond Hettinger wrote: * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar importance? (fix for urllib.urlretrieve silently truncating download) That seems reasonable to me. There is n

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Tim Delaney
Irmen de Jong wrote: Also, I'm not sure how a test-case should be constructed for this patch? Can the Python regression test download stuff as part of a test? Or is there some other way to make a testcase for this. Hmm - perhaps start a server on the local machine at the start of the test, and tea

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Aahz
On Mon, Dec 20, 2004, Jeremy Hylton wrote: > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: >>> >>> Perhaps a rather quick Py2.4.1 would be in order. >> >> +1 > > Nothing wrong with an incremental release, but

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Jeremy Hylton
On Mon, 20 Dec 2004 18:25:39 -0500, Aahz <[EMAIL PROTECTED]> wrote: > On Mon, Dec 20, 2004, Jeremy Hylton wrote: > > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > >>> > >>> Perhaps a rather quick Py2.4.1 woul

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Tim Peters
[Jeremy Hylton on a quick 2.4.1] >>> Nothing wrong with an incremental release, but none of these sound >>> like critical bugs to me. [Aahz] >> You don't think a blowup in marshal is critical? Mind expanding on >> that? [Jeremy] > An undocumented extension to marshal causes a segfault. It's > c