[Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Michael Mueller
Hi Guys, We've been analyzing CPython with our static analysis tool (Sentry) and a NULL pointer dereference popped up the other day, in Objects/descrobject.c: if (descr != NULL) { Py_XINCREF(type); descr-d_type = type; descr-d_name = PyUnicode_InternFromString(name);

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Matt Joiner
ಠ_ಠ On Sat, Dec 17, 2011 at 8:55 PM, Michael Mueller mmuel...@vigilantsw.com wrote: Hi Guys, We've been analyzing CPython with our static analysis tool (Sentry) and a NULL pointer dereference popped up the other day, in Objects/descrobject.c:    if (descr != NULL) {        

Re: [Python-Dev] A new dict for Xmas?

2011-12-17 Thread Maciej Fijalkowski
On Fri, Dec 16, 2011 at 11:32 PM, Terry Reedy tjre...@udel.edu wrote: On 12/16/2011 5:03 AM, Mark Shannon wrote: Of course using __slots__ saves more memory, but people don't use them much. Do you think the stdlib should be using __slots__ more? Note that unlike some other more advanced

Re: [Python-Dev] A new dict for Xmas?

2011-12-17 Thread Dirkjan Ochtman
On Sat, Dec 17, 2011 at 12:53, Maciej Fijalkowski fij...@gmail.com wrote: Note that unlike some other more advanced approaches, slots do change semantics. There are many cases out there where people would stuff arbitrary things on stdlib objects and this works fine without __slots__, but will

Re: [Python-Dev] A new dict for Xmas?

2011-12-17 Thread Maciej Fijalkowski
On Sat, Dec 17, 2011 at 2:31 PM, Dirkjan Ochtman dirk...@ochtman.nl wrote: On Sat, Dec 17, 2011 at 12:53, Maciej Fijalkowski fij...@gmail.com wrote: Note that unlike some other more advanced approaches, slots do change semantics. There are many cases out there where people would stuff

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Georg Brandl
On 12/17/2011 11:33 AM, Matt Joiner wrote: ಠ_ಠ Would you please stop this? It may have been funny the first time, but now it looks like pure trolling. Georg ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Benjamin Peterson
2011/12/17 Michael Mueller mmuel...@vigilantsw.com: Hopefully someone can take a look and determine the appropriate fix. Fixed. -- Regards, Benjamin ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
In that same code, right before PY_DECREF(descr), should there also be a PY_XDECREF(type)? it looks like it might leak a reference to type otherwise. the line in question - http://hg.python.org/cpython/file/8c355edc5b1d/Objects/descrobject.c#l628 - Eli Collins On Sat, Dec 17, 2011 at 8:02 AM,

[Python-Dev] IEEE/ISO draft on Python vulnerabilities

2011-12-17 Thread Kevin Coyne
Victor: Python.3 Type System [IHN] - The use of “extended precision” as a term to express Python’s ability to create and manipulate integers of any size (within the memory limitations of the computer) is poor since that term is used in reference to floating point numbers almost exclusively. I

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Benjamin Peterson
2011/12/17 Eli Collins e...@astllc.org In that same code, right before PY_DECREF(descr), should there also be a PY_XDECREF(type)? it looks like it might leak a reference to type otherwise. No. The descr will deallocate it. PS. Please don't send HTML mail. -- Regards, Benjamin

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
On Sat, Dec 17, 2011 at 11:20 AM, Benjamin Peterson benja...@python.org wrote: No. The descr will deallocate it. PS. Please don't send HTML mail. Thank you for the explanation. And my apologies to the entire list for the HTML; it's way too early for me, I forgot to turn that mess off.

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Michael Mueller
On Sat, Dec 17, 2011 at 5:02 AM, Benjamin Peterson benja...@python.org wrote: 2011/12/17 Michael Mueller mmuel...@vigilantsw.com: Hopefully someone can take a look and determine the appropriate fix. Fixed. -- Regards, Benjamin Excellent! -- Mike Mueller Phone: (401) 405-1525 Email:

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Greg Ewing
Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? -- Greg ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Antoine Pitrou
On Sun, 18 Dec 2011 13:09:16 +1300 Greg Ewing greg.ew...@canterbury.ac.nz wrote: Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? print(ascii(ಠ_ಠ)) '\u0ca0_\u0ca0' Antoine. ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Steven D'Aprano
Greg Ewing wrote: Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? I think that, depending on the typeface you view it with, it is supposed to be some sort of smiley: two big wide open square eyes with tightly pursed lips. Presumably it is supposed to be a look of shock and

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Steven D'Aprano
Steven D'Aprano wrote: Greg Ewing wrote: Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? I think that, depending on the typeface you view it with, it is supposed to be some sort of smiley: two big wide open square eyes with tightly pursed lips. Presumably it is supposed to be

Re: [Python-Dev] Inconsistent script/console behaviour

2011-12-17 Thread Fernando Perez
On Fri, 23 Sep 2011 16:32:30 -0700, Guido van Rossum wrote: You can't fix this without completely changing the way the interactive console treats blank lines. None that it's not just that a blank line is required after a function definition -- you also *can't* have a blank line *inside* a